GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-68395: Avoid naming conflicts by mangling variable names in Argument Clinic by erlend-aasland · Pull Request #104065 · python/cpython

Conversation

@erlend-aasland

@erlend-aasland erlend-aasland commented May 1, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Add all internally used variable names to CLINIC_PREFIXED_ARGS.

  • Issue: Argument Clinic doesn't mangle conflicting names #68395

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@erlend-aasland
erlend-aasland requested a review from serhiy-storchaka May 1, 2023 21:45
@bedevere-bot bedevere-bot added the awaiting core review label May 1, 2023
@bedevere-bot bedevere-bot mentioned this pull request May 1, 2023
Argument Clinic doesn't mangle conflicting names #68395
Closed
@erlend-aasland
pythongh-68395: Avoid naming conflicts by mangling variable names in …
9a74d01
…Argument Clinic

Add all internally used variable names to CLINIC_PREFIXED_ARGS.
@erlend-aasland
erlend-aasland force-pushed the clinic-mangle-more-names branch from 8acfbe7 to 9a74d01 Compare May 1, 2023 21:45
@erlend-aasland erlend-aasland added the skip news label May 1, 2023
@erlend-aasland

erlend-aasland commented May 1, 2023

Copy link
Copy Markdown
Contributor Author

We can skip NEWS here; this is an implementation detail of the internal tooling.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@erlend-aasland
erlend-aasland enabled auto-merge (squash) May 1, 2023 21:51
@erlend-aasland
erlend-aasland disabled auto-merge May 1, 2023 21:51
@erlend-aasland erlend-aasland mentioned this pull request May 1, 2023
Argument Clinic name conflict #83922
Closed
hauntsaninja
hauntsaninja approved these changes May 2, 2023
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels May 2, 2023
@erlend-aasland erlend-aasland self-assigned this May 2, 2023
@erlend-aasland

erlend-aasland commented May 2, 2023

Copy link
Copy Markdown
Contributor Author

I'll wait a few days to give Serhiy a chance to chime in, before merging this.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@erlend-aasland

erlend-aasland commented May 4, 2023

Copy link
Copy Markdown
Contributor Author

@serhiy-storchaka, I aim on landing this by tomorrow evening (CET).

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

kumaraditya303
kumaraditya303 approved these changes May 5, 2023
View reviewed changes
This was linked to issues May 5, 2023
Argument Clinic name conflict #83922
Closed
Argument Clinic doesn't mangle conflicting names #68395
Closed
@erlend-aasland

erlend-aasland commented May 5, 2023

Copy link
Copy Markdown
Contributor Author

Two green lights, no complaints; I'm landing this. Thanks for the reviews!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@erlend-aasland
erlend-aasland merged commit 5245cb6 into python:main May 5, 2023
@bedevere-bot bedevere-bot removed the awaiting merge label May 5, 2023
@erlend-aasland
erlend-aasland deleted the clinic-mangle-more-names branch May 5, 2023 11:40
carljm added a commit to carljm/cpython that referenced this pull request May 5, 2023
@carljm
Merge branch 'main' into inlinecomp2
8a78a36
* main: (61 commits)
  pythongh-64595: Argument Clinic: Touch source file if any output file changed (python#104152)
  pythongh-64631: Test exception messages in cloned Argument Clinic funcs (python#104167)
  pythongh-68395: Avoid naming conflicts by mangling variable names in Argument Clinic (python#104065)
  pythongh-64658: Expand Argument Clinic return converter docs (python#104175)
  pythonGH-103092: port `_asyncio` freelist to module state (python#104196)
  pythongh-104051: fix crash in test_xxtestfuzz with -We (python#104052)
  pythongh-104190: fix ubsan crash (python#104191)
  pythongh-104106: Add gcc fallback of mkfifoat/mknodat for macOS (pythongh-104129)
  pythonGH-104142: Fix _Py_RefcntAdd to respect immortality (pythonGH-104143)
  pythongh-104112: link from cached_property docs to method-caching FAQ (python#104113)
  pythongh-68968: Correcting message display issue with assertEqual (python#103937)
  pythonGH-103899: Provide a hint when accidentally calling a module (pythonGH-103900)
  pythongh-103963: fix 'make regen-opcode' in out-of-tree builds (python#104177)
  pythongh-102500: Add PEP 688 and 698 to the 3.12 release highlights (python#104174)
  pythonGH-81079: Add case_sensitive argument to `pathlib.Path.glob()` (pythonGH-102710)
  pythongh-91896: Deprecate collections.abc.ByteString (python#102096)
  pythongh-99593: Add tests for Unicode C API (part 2) (python#99868)
  pythongh-102500: Document PEP 688 (python#102571)
  pythongh-102500: Implement PEP 688 (python#102521)
  pythongh-96534: socketmodule: support FreeBSD divert(4) socket (python#96536)
  ...
jbower-fb pushed a commit to jbower-fb/cpython that referenced this pull request May 8, 2023
@erlend-aasland @jbower-fb
pythongh-68395: Avoid naming conflicts by mangling variable names in …
582fe9a
…Argument Clinic (python#104065)

Add all internally used variable names to CLINIC_PREFIXED_ARGS.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hauntsaninja hauntsaninja hauntsaninja approved these changes
@kumaraditya303 kumaraditya303 kumaraditya303 approved these changes
@serhiy-storchaka serhiy-storchaka Awaiting requested review from serhiy-storchaka

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@erlend-aasland erlend-aasland

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Argument Clinic name conflict Argument Clinic doesn't mangle conflicting names

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@erlend-aasland @hauntsaninja @kumaraditya303 @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.