GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-104190: fix ubsan crash by sunmy2019 · Pull Request #104191 · python/cpython

Conversation

@sunmy2019

@sunmy2019 sunmy2019 commented May 5, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: usan failure on main #104190

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
brandtbucher reacted with thumbs up emoji erlend-aasland reacted with hooray emoji eduardo-elizondo reacted with heart emoji
All reactions
  • 👍 1 reaction
  • 🎉 1 reaction
  • ❤️ 1 reaction
@sunmy2019
fix python#104190
c634b91
@bedevere-bot bedevere-bot mentioned this pull request May 5, 2023
usan failure on main #104190
Closed
@bedevere-bot bedevere-bot added awaiting review labels May 5, 2023
@gaogaotiantian gaogaotiantian added skip news 🔨 test-with-buildbots Test PR w/ buildbots; report in status section type-crash A hard crash of the interpreter, possibly with a core dump labels May 5, 2023
@bedevere-bot

bedevere-bot commented May 5, 2023

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @gaogaotiantian for commit c634b91 🤖

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label May 5, 2023
@gaogaotiantian

gaogaotiantian commented May 5, 2023

Copy link
Copy Markdown
Member

Good catch! It seems to me that ObjExtraData_Type is a bad name here - super confusing with all the other similar names being the PyTypeObject instead of the pointer. Maybe we should consider renaming the variable.
sunmy2019 reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@sunmy2019

sunmy2019 commented May 5, 2023

Copy link
Copy Markdown
Member Author

Maybe we should consider renaming the variable.

It makes sense in some respects. But a quick search in the code base, most variable names receiving PyType_FromModuleAndSpec has patterns

xxx_xxx_type (count=30)
XxxXxx_Type (count=15)
XxxXxxType (count=6)

No strong preference was found. I am OK either way.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
kumaraditya303
kumaraditya303 approved these changes May 5, 2023
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels May 5, 2023
@kumaraditya303
kumaraditya303 merged commit 1630345 into python:main May 5, 2023
@bedevere-bot bedevere-bot removed the awaiting merge label May 5, 2023
@brandtbucher brandtbucher mentioned this pull request May 5, 2023
gh-103743: Add PyUnstable_Object_GC_NewWithExtraData #103744
Merged
@Fidget-Spinner

Fidget-Spinner commented May 5, 2023

Copy link
Copy Markdown
Member

@sunmy2019 sorry for hijacking this issue, but could you please email me at [email protected] to discuss potential triage permissions?
sunmy2019 and erlend-aasland reacted with thumbs up emoji
All reactions
  • 👍 2 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
carljm added a commit to carljm/cpython that referenced this pull request May 5, 2023
@carljm
Merge branch 'main' into inlinecomp2
8a78a36 
* main: (61 commits)
  pythongh-64595: Argument Clinic: Touch source file if any output file changed (python#104152)
  pythongh-64631: Test exception messages in cloned Argument Clinic funcs (python#104167)
  pythongh-68395: Avoid naming conflicts by mangling variable names in Argument Clinic (python#104065)
  pythongh-64658: Expand Argument Clinic return converter docs (python#104175)
  pythonGH-103092: port `_asyncio` freelist to module state (python#104196)
  pythongh-104051: fix crash in test_xxtestfuzz with -We (python#104052)
  pythongh-104190: fix ubsan crash (python#104191)
  pythongh-104106: Add gcc fallback of mkfifoat/mknodat for macOS (pythongh-104129)
  pythonGH-104142: Fix _Py_RefcntAdd to respect immortality (pythonGH-104143)
  pythongh-104112: link from cached_property docs to method-caching FAQ (python#104113)
  pythongh-68968: Correcting message display issue with assertEqual (python#103937)
  pythonGH-103899: Provide a hint when accidentally calling a module (pythonGH-103900)
  pythongh-103963: fix 'make regen-opcode' in out-of-tree builds (python#104177)
  pythongh-102500: Add PEP 688 and 698 to the 3.12 release highlights (python#104174)
  pythonGH-81079: Add case_sensitive argument to `pathlib.Path.glob()` (pythonGH-102710)
  pythongh-91896: Deprecate collections.abc.ByteString (python#102096)
  pythongh-99593: Add tests for Unicode C API (part 2) (python#99868)
  pythongh-102500: Document PEP 688 (python#102571)
  pythongh-102500: Implement PEP 688 (python#102521)
  pythongh-96534: socketmodule: support FreeBSD divert(4) socket (python#96536)
  ...
jbower-fb pushed a commit to jbower-fb/cpython that referenced this pull request May 8, 2023
@sunmy2019 @jbower-fb
pythongh-104190: fix ubsan crash (python#104191)
3205457
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kumaraditya303 kumaraditya303 kumaraditya303 approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news type-crash A hard crash of the interpreter, possibly with a core dump

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@sunmy2019 @bedevere-bot @gaogaotiantian @Fidget-Spinner @kumaraditya303
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.