GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-64658: Expand Argument Clinic return converter docs by erlend-aasland · Pull Request #104175 · python/cpython

Conversation

@erlend-aasland

@erlend-aasland erlend-aasland commented May 4, 2023 •
edited by github-actions Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor
  • Issue: [doc] No Argument Clinic documentation on how to specify a return converter #64658

📚 Documentation preview 📚: https://cpython-previews--104175.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@erlend-aasland
pythongh-64658: Amend Argument Clinic return converter docs
3de3972
@erlend-aasland
erlend-aasland requested a review from AlexWaygood May 4, 2023 15:44
@bedevere-bot bedevere-bot mentioned this pull request May 4, 2023
[doc] No Argument Clinic documentation on how to specify a return converter #64658
Closed
@bedevere-bot bedevere-bot added docs Documentation in the Doc dir skip news awaiting core review labels May 4, 2023
@erlend-aasland erlend-aasland linked an issue May 4, 2023 that may be closed by this pull request
[doc] No Argument Clinic documentation on how to specify a return converter #64658
Closed
erlend-aasland
erlend-aasland commented May 4, 2023
View reviewed changes
Comment thread Doc/howto/clinic.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

AlexWaygood
AlexWaygood reviewed May 4, 2023
View reviewed changes

@AlexWaygood AlexWaygood left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only understand AC in the vaguest terms, but that is definitely a sentence that makes grammatical sense! :)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

erlend-aasland reacted with laugh emoji
All reactions
  • 😄 1 reaction
@erlend-aasland

This comment was marked as outdated.

Sign in to view
erlend-aasland added 4 commits May 4, 2023 21:12
@erlend-aasland
Fix init return converter name
e7233a4
@erlend-aasland
Sort the return converter table alphabetically
28876a7
@erlend-aasland
Further amendments
c361abd
@erlend-aasland
Add example
fc83243
@erlend-aasland erlend-aasland changed the title gh-64658: Amend Argument Clinic return converter docs gh-64658: Expand Argument Clinic return converter docs May 4, 2023
@erlend-aasland

erlend-aasland commented May 4, 2023

Copy link
Copy Markdown
Contributor Author

BTW, I removed the reference to the init converter; it's only used internally by AC anyways.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@erlend-aasland
erlend-aasland requested a review from AlexWaygood May 4, 2023 19:56
@erlend-aasland erlend-aasland added the needs backport to 3.11 only security fixes label May 5, 2023
@erlend-aasland

erlend-aasland commented May 5, 2023

Copy link
Copy Markdown
Contributor Author

FTR, I'm landing this soon. We can easily fix nitpicks in the docs later (no issue needed).

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

AlexWaygood
AlexWaygood reviewed May 5, 2023
View reviewed changes

@AlexWaygood AlexWaygood left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks fine to me, but I still feel like a very underqualified reviewer here :)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

erlend-aasland reacted with heart emoji
All reactions
  • ❤️ 1 reaction
Comment thread Doc/howto/clinic.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

@erlend-aasland @AlexWaygood
Update Doc/howto/clinic.rst
88ed3c1
Co-authored-by: Alex Waygood <[email protected]>
erlend-aasland
erlend-aasland commented May 5, 2023
View reviewed changes
Comment thread Doc/howto/clinic.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

@erlend-aasland
Update Doc/howto/clinic.rst
7e24669
@erlend-aasland
erlend-aasland merged commit 721a783 into python:main May 5, 2023
@erlend-aasland
erlend-aasland deleted the clinic-doc-ret-conv branch May 5, 2023 11:32
@erlend-aasland erlend-aasland removed the needs backport to 3.11 only security fixes label May 5, 2023
@bedevere-bot

bedevere-bot commented May 5, 2023

Copy link
Copy Markdown

GH-104198 is a backport of this pull request to the 3.11 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

erlend-aasland added a commit to erlend-aasland/cpython that referenced this pull request May 5, 2023
@erlend-aasland
[3.11] pythongh-64658: Expand Argument Clinic return converter docs (p…
ea0eac3
…ython#104175)
erlend-aasland added a commit that referenced this pull request May 5, 2023
@erlend-aasland
[3.11] gh-64658: Expand Argument Clinic return converter docs (#104175)…
a635d63
… (#104198)
carljm added a commit to carljm/cpython that referenced this pull request May 5, 2023
@carljm
Merge branch 'main' into inlinecomp2
8a78a36
* main: (61 commits)
  pythongh-64595: Argument Clinic: Touch source file if any output file changed (python#104152)
  pythongh-64631: Test exception messages in cloned Argument Clinic funcs (python#104167)
  pythongh-68395: Avoid naming conflicts by mangling variable names in Argument Clinic (python#104065)
  pythongh-64658: Expand Argument Clinic return converter docs (python#104175)
  pythonGH-103092: port `_asyncio` freelist to module state (python#104196)
  pythongh-104051: fix crash in test_xxtestfuzz with -We (python#104052)
  pythongh-104190: fix ubsan crash (python#104191)
  pythongh-104106: Add gcc fallback of mkfifoat/mknodat for macOS (pythongh-104129)
  pythonGH-104142: Fix _Py_RefcntAdd to respect immortality (pythonGH-104143)
  pythongh-104112: link from cached_property docs to method-caching FAQ (python#104113)
  pythongh-68968: Correcting message display issue with assertEqual (python#103937)
  pythonGH-103899: Provide a hint when accidentally calling a module (pythonGH-103900)
  pythongh-103963: fix 'make regen-opcode' in out-of-tree builds (python#104177)
  pythongh-102500: Add PEP 688 and 698 to the 3.12 release highlights (python#104174)
  pythonGH-81079: Add case_sensitive argument to `pathlib.Path.glob()` (pythonGH-102710)
  pythongh-91896: Deprecate collections.abc.ByteString (python#102096)
  pythongh-99593: Add tests for Unicode C API (part 2) (python#99868)
  pythongh-102500: Document PEP 688 (python#102571)
  pythongh-102500: Implement PEP 688 (python#102521)
  pythongh-96534: socketmodule: support FreeBSD divert(4) socket (python#96536)
  ...
jbower-fb pushed a commit to jbower-fb/cpython that referenced this pull request May 8, 2023
@erlend-aasland @jbower-fb
pythongh-64658: Expand Argument Clinic return converter docs (python#…
be60d71
…104175)
erlend-aasland added a commit to erlend-aasland/devguide that referenced this pull request Sep 8, 2023
@erlend-aasland
python/cpython#64658: Expand Argument Clinic return converter docs (p…
3edac31
…ython/cpython#104175)
AA-Turner pushed a commit to AA-Turner/devguide that referenced this pull request Sep 13, 2023
@erlend-aasland
python/cpython#64658: Expand Argument Clinic return converter docs (p…
59eef01
…ython/cpython#104175)
erlend-aasland added a commit to python/devguide that referenced this pull request Sep 26, 2023
@erlend-aasland
python/cpython#64658: Expand Argument Clinic return converter docs (p…
769053f
…ython/cpython#104175)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AlexWaygood AlexWaygood AlexWaygood left review comments

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting core review docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[doc] No Argument Clinic documentation on how to specify a return converter

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@erlend-aasland @bedevere-bot @AlexWaygood
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.