GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-97696 Add documentation for get_coro() behavior with eager tasks by jbower-fb · Pull Request #104189 · python/cpython

Conversation

@jbower-fb

@jbower-fb jbower-fb commented May 5, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

This PR caught the plague and had to be killed with fire. A new one was opened to replace it #104304.

In response to comments on this issue.

  • Issue: Add eager task creation API to asyncio #97696

📚 Documentation preview 📚: https://cpython-previews--104189.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@jbower-fb
pythongh-97696 Add documentation for get_coro() behavior with eager t…
5c30058 
…asks
@jbower-fb
jbower-fb requested review from 1st1, asvetlov, gvanrossum, kumaraditya303 and willingc as code owners May 5, 2023 05:54
@bedevere-bot bedevere-bot mentioned this pull request May 5, 2023
Add eager task creation API to asyncio #97696
Closed
@bedevere-bot bedevere-bot added awaiting review docs Documentation in the Doc dir skip news labels May 5, 2023
@jbower-fb jbower-fb mentioned this pull request May 5, 2023
gh-97696: asyncio eager tasks factory #102853
Merged
gaogaotiantian
gaogaotiantian reviewed May 5, 2023
View reviewed changes
Comment thread Doc/library/asyncio-task.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
gvanrossum
gvanrossum reviewed May 5, 2023
View reviewed changes

@gvanrossum gvanrossum left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG, but let's wait until Kumar's feedback has been resolved.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@jbower-fb
Update asyncio-task.rst
248b78b
kumaraditya303
kumaraditya303 requested changes May 6, 2023
View reviewed changes
Comment thread Doc/library/asyncio-task.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot added awaiting changes and removed awaiting review labels May 6, 2023
@bedevere-bot

bedevere-bot commented May 6, 2023

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
gvanrossum
gvanrossum reviewed May 6, 2023
View reviewed changes
Comment thread Doc/library/asyncio-task.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
sunmy2019 and others added 11 commits May 8, 2023 12:06
@sunmy2019 @jbower-fb
pythongh-104190: fix ubsan crash (python#104191)
3205457
@iritkatriel @jbower-fb
pythongh-104051: fix crash in test_xxtestfuzz with -We (python#104052)
4126669
@kumaraditya303 @jbower-fb
pythonGH-103092: port _asyncio freelist to module state (python#104196
992dead 
)
@erlend-aasland @jbower-fb
pythongh-64658: Expand Argument Clinic return converter docs (python#…
be60d71 
…104175)
@erlend-aasland @jbower-fb
pythongh-68395: Avoid naming conflicts by mangling variable names in …
582fe9a 
…Argument Clinic (python#104065)

Add all internally used variable names to CLINIC_PREFIXED_ARGS.
@erlend-aasland @jbower-fb
pythongh-64631: Test exception messages in cloned Argument Clinic fun…
78dc058 
…cs (python#104167)
@erlend-aasland @jbower-fb
pythongh-64595: Argument Clinic: Touch source file if any output file…
d3192a2 
… changed (python#104152)
@markshannon @jbower-fb
pythonGH-96803: Add three C-API functions to make _PyInterpreterFrame…
5405b60 
… less opaque for users of PEP 523. (pythonGH-96849)
@gaogaotiantian @jbower-fb
pythongh-103533: Use PEP 669 APIs for cprofile (pythonGH-103534)
21fb990
@nametkin @orsenthil @jbower-fb
pythongh-69152: Add _proxy_response_headers attribute to HTTPConnecti…
ef989ab 
…on (python#26152)

Add _proxy_response_headers attribute to HTTPConnection (python#26152)

---------

Co-authored-by: Senthil Kumaran <[email protected]>
@barneygale @AlexWaygood @jbower-fb
pythonGH-100479: Add pathlib.PurePath.with_segments() (pythonGH-103975
0b62e96 
)

Add `pathlib.PurePath.with_segments()`, which creates a path object from arguments. This method is called whenever a derivative path is created, such as from `pathlib.PurePath.parent`. Subclasses may override this method to share information between path objects.

Co-authored-by: Alex Waygood <[email protected]>
@hugovk
hugovk removed request for 1st1, AlexWaygood, Fidget-Spinner, JelleZijlstra, abalkin, asvetlov, barneygale, berkerpeksag, brettcannon, corona10, encukou, ericsnowcurrently, erlend-aasland, ezio-melotti, gpshead, hugovk, iritkatriel, isidentical, lysnikolaou, markshannon, ncoghlan, pablogsal, pganssle, rhettinger, tiran, warsaw and willingc May 8, 2023 19:19
@jbower-fb jbower-fb mentioned this pull request May 8, 2023
gh-97696 Add documentation for get_coro() behavior with eager tasks #104304
Merged
@bedevere-bot bedevere-bot added awaiting review and removed awaiting changes labels May 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gvanrossum gvanrossum gvanrossum left review comments
@gaogaotiantian gaogaotiantian gaogaotiantian left review comments
@kumaraditya303 kumaraditya303 kumaraditya303 requested changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting review docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

20 participants

@jbower-fb @bedevere-bot @gvanrossum @gaogaotiantian @kumaraditya303 @sunmy2019 @iritkatriel @erlend-aasland @markshannon @nametkin @barneygale @ericsnowcurrently @itamaro @vstinner @yrro @AA-Turner @sobolevn @terryjreedy @AlexWaygood @arhadthedev
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.