GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — gh-97696 Remove unnecessary check for eager_start kwarg by jbower-fb · Pull Request #104188 · python/cpython

Conversation

jbower-fb commented May 5, 2023

Copy link

Copy Markdown

Contributor

Part of gh-97696 in response to comments on #102853.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          Remove unnecessary check for eager_start kwarg

703e784

jbower-fb requested review from 1st1, asvetlov, gvanrossum, kumaraditya303 and willingc as code owners

May 5, 2023 05:39

bedevere-bot added the awaiting review label

May 5, 2023

jbower-fb changed the title ~~Remove unnecessary check for eager_start kwarg~~ gh-97696 Remove unnecessary check for eager_start kwarg

May 5, 2023

bedevere-bot mentioned this pull request

May 5, 2023

Add eager task creation API to asyncio #97696

Closed

gaogaotiantian added the topic-asyncio label

May 5, 2023

arhadthedev added skip news stdlib Standard Library Python modules in the Lib/ directory labels

May 5, 2023

gvanrossum removed their request for review

May 5, 2023 16:38

itamaro approved these changes

May 5, 2023

View reviewed changes

itamaro left a comment

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this trades off a clear and upfront (as soon as the factory is set) error:

TypeError: Provided constructor does not support eager task execution

with a delayed (until the first task creation) and less clear error:

TypeError: AsyncTree.run.<locals>.loop_factory.<locals>.counting_task_constructor() got an unexpected keyword argument 'eager_start'

I think the "less clear" error is still clear enough to be actionable, and I wasn't crazy about that use of inspect and the fact that it rejects ctors that take and pass down **kwargs, so in balance I think this change is good.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

bedevere-bot added awaiting core review and removed awaiting review labels

May 5, 2023

gvanrossum reviewed

May 5, 2023

View reviewed changes

gvanrossum left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about instead we add a docstring explaining the requirement?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

carljm commented May 6, 2023

Copy link

Copy Markdown

Member

How about instead we add a docstring explaining the requirement?

cf also @kumaraditya303 's observation in #97696 (comment) that the new eager_start argument to the Task constructor needs to be documented, and perhaps create_eager_task_factory could generally use stronger documentation with an example.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.


          Add docstring to create_eager_task_factory

86c8b43

jbower-fb commented May 6, 2023

Copy link

Copy Markdown

Contributor Author

To get us started, I've added a possible docstring for create_eager_task_factory().

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

carljm reviewed

May 6, 2023

View reviewed changes

Comment thread

Lib/asyncio/tasks.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Lib/asyncio/tasks.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

jbower-fb added 2 commits

May 5, 2023 18:23


          Improve create_eager_task_factory() docstring

defcfe8


          Make docstring PEP 257 compliant

26409a2

gvanrossum reviewed

May 6, 2023

View reviewed changes

gvanrossum left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have some suggestions for the docstring.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

Lib/asyncio/tasks.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

gvanrossum reviewed

May 8, 2023

View reviewed changes

gvanrossum left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Who's waiting for whom here?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          Further improve create_eager_task_factory docstring

8b5f6c5

gvanrossum approved these changes

May 9, 2023

View reviewed changes

gvanrossum left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great -- will merge once tests pass!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

jbower-fb reacted with thumbs up emoji

All reactions

👍 1 reaction

bedevere-bot added awaiting merge and removed awaiting core review labels

May 9, 2023


          Further docstring refinement

fe94a2b

gvanrossum enabled auto-merge (squash)

May 9, 2023 00:22


          Remove trailing whitespace

68fff10

auto-merge was automatically disabled

May 9, 2023 00:25

Head branch was pushed to by a user without write access

jbower-fb commented May 9, 2023

Copy link

Copy Markdown

Contributor Author

Thanks for the review, took me a few commits to tidy things up though. I hope it's good to go now.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

gvanrossum enabled auto-merge (squash)

May 9, 2023 00:33

gvanrossum merged commit bf89d42 into python:main

May 9, 2023

bedevere-bot removed the awaiting merge label

May 9, 2023

carljm added a commit to carljm/cpython that referenced this pull request

May 9, 2023


          Merge branch 'main' into inlinecomp2

76077cd

* main: (47 commits)
  pythongh-97696 Remove unnecessary check for eager_start kwarg (python#104188)
  pythonGH-104308: socket.getnameinfo should release the GIL (python#104307)
  pythongh-104310: Add importlib.util.allowing_all_extensions() (pythongh-104311)
  pythongh-99113: A Per-Interpreter GIL! (pythongh-104210)
  pythonGH-104284: Fix documentation gettext build (python#104296)
  pythongh-89550: Buffer GzipFile.write to reduce execution time by ~15% (python#101251)
  pythongh-104223: Fix issues with inheriting from buffer classes (python#104227)
  pythongh-99108: fix typo in Modules/Setup (python#104293)
  pythonGH-104145: Use fully-qualified cross reference types for the bisect module (python#104172)
  pythongh-103193: Improve `getattr_static` test coverage (python#104286)
  Trim trailing whitespace and test on CI (python#104275)
  pythongh-102500: Remove mention of bytes shorthand (python#104281)
  pythongh-97696: Improve and fix documentation for asyncio eager tasks (python#104256)
  pythongh-99108: Replace SHA3 implementation HACL* version (python#103597)
  pythongh-104273: Remove redundant len() calls in argparse function (python#104274)
  pythongh-64660: Don't hardcode Argument Clinic return converter result variable name (python#104200)
  pythongh-104265 Disallow instantiation of `_csv.Reader` and `_csv.Writer` (python#104266)
  pythonGH-102613: Improve performance of `pathlib.Path.rglob()` (pythonGH-104244)
  pythongh-103650: Fix perf maps address format (python#103651)
  pythonGH-89812: Churn `pathlib.Path` methods (pythonGH-104243)
  ...

carljm added a commit to carljm/cpython that referenced this pull request

May 9, 2023


          Merge branch 'main' into fixsendfamily

a614216

* main: (29 commits)
  pythongh-104276: Make `_struct.unpack_iterator` type use type flag instead of custom constructor (python#104277)
  pythongh-97696: Move around and update the whatsnew entry for asyncio eager task factory (python#104298)
  pythongh-103193: Fix refleaks in `test_inspect` and `test_typing` (python#104320)
  require-pr-label.yml: Add missing "permissions:" (python#104309)
  pythongh-90656: Add platform triplets for 64-bit LoongArch (LA64) (python#30939)
  pythongh-104180: Read SOCKS proxies from macOS System Configuration (python#104181)
  pythongh-97696 Remove unnecessary check for eager_start kwarg (python#104188)
  pythonGH-104308: socket.getnameinfo should release the GIL (python#104307)
  pythongh-104310: Add importlib.util.allowing_all_extensions() (pythongh-104311)
  pythongh-99113: A Per-Interpreter GIL! (pythongh-104210)
  pythonGH-104284: Fix documentation gettext build (python#104296)
  pythongh-89550: Buffer GzipFile.write to reduce execution time by ~15% (python#101251)
  pythongh-104223: Fix issues with inheriting from buffer classes (python#104227)
  pythongh-99108: fix typo in Modules/Setup (python#104293)
  pythonGH-104145: Use fully-qualified cross reference types for the bisect module (python#104172)
  pythongh-103193: Improve `getattr_static` test coverage (python#104286)
  Trim trailing whitespace and test on CI (python#104275)
  pythongh-102500: Remove mention of bytes shorthand (python#104281)
  pythongh-97696: Improve and fix documentation for asyncio eager tasks (python#104256)
  pythongh-99108: Replace SHA3 implementation HACL* version (python#103597)
  ...

jbower-fb deleted the removeeagerstartintrospect branch

May 9, 2023 17:08

carljm added a commit to carljm/cpython that referenced this pull request

May 9, 2023


          Merge branch 'main' into supermon

c48eee3

* main: (156 commits)
  pythongh-97696 Add documentation for get_coro() behavior with eager tasks (python#104304)
  pythongh-97933: (PEP 709) inline list/dict/set comprehensions (python#101441)
  pythongh-99889: Fix directory traversal security flaw in uu.decode() (python#104096)
  pythongh-104184: fix building --with-pydebug --enable-pystats (python#104217)
  pythongh-104139: Add itms-services to uses_netloc urllib.parse. (python#104312)
  pythongh-104240: return code unit metadata from codegen (python#104300)
  pythongh-104276: Make `_struct.unpack_iterator` type use type flag instead of custom constructor (python#104277)
  pythongh-97696: Move around and update the whatsnew entry for asyncio eager task factory (python#104298)
  pythongh-103193: Fix refleaks in `test_inspect` and `test_typing` (python#104320)
  require-pr-label.yml: Add missing "permissions:" (python#104309)
  pythongh-90656: Add platform triplets for 64-bit LoongArch (LA64) (python#30939)
  pythongh-104180: Read SOCKS proxies from macOS System Configuration (python#104181)
  pythongh-97696 Remove unnecessary check for eager_start kwarg (python#104188)
  pythonGH-104308: socket.getnameinfo should release the GIL (python#104307)
  pythongh-104310: Add importlib.util.allowing_all_extensions() (pythongh-104311)
  pythongh-99113: A Per-Interpreter GIL! (pythongh-104210)
  pythonGH-104284: Fix documentation gettext build (python#104296)
  pythongh-89550: Buffer GzipFile.write to reduce execution time by ~15% (python#101251)
  pythongh-104223: Fix issues with inheriting from buffer classes (python#104227)
  pythongh-99108: fix typo in Modules/Setup (python#104293)
  ...

carljm added a commit to carljm/cpython that referenced this pull request

May 9, 2023


          Merge branch 'main' into fixloadsuperspec

cf11908

* main: (35 commits)
  pythongh-97696 Add documentation for get_coro() behavior with eager tasks (python#104304)
  pythongh-97933: (PEP 709) inline list/dict/set comprehensions (python#101441)
  pythongh-99889: Fix directory traversal security flaw in uu.decode() (python#104096)
  pythongh-104184: fix building --with-pydebug --enable-pystats (python#104217)
  pythongh-104139: Add itms-services to uses_netloc urllib.parse. (python#104312)
  pythongh-104240: return code unit metadata from codegen (python#104300)
  pythongh-104276: Make `_struct.unpack_iterator` type use type flag instead of custom constructor (python#104277)
  pythongh-97696: Move around and update the whatsnew entry for asyncio eager task factory (python#104298)
  pythongh-103193: Fix refleaks in `test_inspect` and `test_typing` (python#104320)
  require-pr-label.yml: Add missing "permissions:" (python#104309)
  pythongh-90656: Add platform triplets for 64-bit LoongArch (LA64) (python#30939)
  pythongh-104180: Read SOCKS proxies from macOS System Configuration (python#104181)
  pythongh-97696 Remove unnecessary check for eager_start kwarg (python#104188)
  pythonGH-104308: socket.getnameinfo should release the GIL (python#104307)
  pythongh-104310: Add importlib.util.allowing_all_extensions() (pythongh-104311)
  pythongh-99113: A Per-Interpreter GIL! (pythongh-104210)
  pythonGH-104284: Fix documentation gettext build (python#104296)
  pythongh-89550: Buffer GzipFile.write to reduce execution time by ~15% (python#101251)
  pythongh-104223: Fix issues with inheriting from buffer classes (python#104227)
  pythongh-99108: fix typo in Modules/Setup (python#104293)
  ...

Reviewers

carljm

carljm left review comments

itamaro

itamaro approved these changes

gvanrossum

gvanrossum approved these changes

1st1

Awaiting requested review from 1st1

1st1 is a code owner

asvetlov

Awaiting requested review from asvetlov

asvetlov is a code owner

kumaraditya303

Awaiting requested review from kumaraditya303

kumaraditya303 is a code owner

willingc

Awaiting requested review from willingc

willingc is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news stdlib

Standard Library Python modules in the Lib/ directory

topic-asyncio

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

7 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.