GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-104301: Allow leading whitespace in disambiguated pdb statements by SnoopJ · Pull Request #104342 · python/cpython

Conversation

@SnoopJ

@SnoopJ SnoopJ commented May 9, 2023 •
edited by github-actions Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

This changeset fixes #104301 by allowing leading whitespace in statements prefixed by ! in pdb, as an alternate to #104302, suggested here.

This PR also adds a corresponding example of the pdb documentation.

  • Issue: Misleading documentation of ! prefix in pdb #104301

📚 Documentation preview 📚: https://cpython-previews--104342.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
SnoopJ added 2 commits May 9, 2023 18:41
@SnoopJ
Allow leading whitespace in disambiguated pdb statements
c889443
@SnoopJ
Add example of disambiguated statement to pdb docs
34c84e2
@bedevere-bot bedevere-bot mentioned this pull request May 9, 2023
Misleading documentation of ! prefix in pdb #104301
Closed
@bedevere-bot bedevere-bot added the awaiting review label May 9, 2023
@SnoopJ
Add NEWS entry
3cf0d8a
gaogaotiantian
gaogaotiantian reviewed May 10, 2023
View reviewed changes
Comment thread Lib/pdb.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@SnoopJ
Use strip() instead of lstrip()
3968695
gaogaotiantian
gaogaotiantian approved these changes May 11, 2023
View reviewed changes
@bedevere-bot bedevere-bot added awaiting core review and removed awaiting review labels May 11, 2023
@gaogaotiantian
gaogaotiantian requested a review from iritkatriel May 11, 2023 00:55
@iritkatriel

iritkatriel commented May 11, 2023

Copy link
Copy Markdown
Member

Do we have tests for this feature?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@gaogaotiantian

gaogaotiantian commented May 11, 2023

Copy link
Copy Markdown
Member

Ah right, totally forgot about that. @SnoopJ could you add some test case to use ! with spaces? The doctests in test_pdb.py should not be too hard to follow, let me know if you have any questions.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@SnoopJ
Add test for disambiguated statements in pdb
ebf179d
@SnoopJ

SnoopJ commented May 11, 2023

Copy link
Copy Markdown
Contributor Author

No problem, added in ebf179d. I couldn't find any pre-existing tests of the feature, so let me know if the test I added should also explicitly test the spelling without any leading whitespace
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
iritkatriel
iritkatriel reviewed May 11, 2023
View reviewed changes
Comment thread Lib/test/test_pdb.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
iritkatriel
iritkatriel reviewed May 11, 2023
View reviewed changes
Comment thread Lib/test/test_pdb.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
SnoopJ and others added 2 commits May 11, 2023 11:22
@SnoopJ
Use more explicit print()
ac6e0e3
@SnoopJ @iritkatriel
Use better name for test
778a4ef 
Co-authored-by: Irit Katriel <[email protected]>
@SnoopJ
SnoopJ force-pushed the gh-104301_pdb-allow-leading-statement-whitespace branch from 84ad82a to 778a4ef Compare May 11, 2023 15:25
@SnoopJ

SnoopJ commented May 11, 2023

Copy link
Copy Markdown
Contributor Author

Sorry about the force-push, I wanted to be sure that the Co-authored-by attribution was present since I didn't use the suggestion UI to make that change.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
iritkatriel
iritkatriel approved these changes May 11, 2023
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels May 11, 2023
@iritkatriel iritkatriel added type-feature A feature request or enhancement stdlib Standard Library Python modules in the Lib/ directory labels May 11, 2023
@iritkatriel

iritkatriel commented May 11, 2023

Copy link
Copy Markdown
Member

Sorry about the force-push, I wanted to be sure that the Co-authored-by attribution was present since I didn't use the suggestion UI to make that change.

There's no need for it (minor code review suggestions do not typically need to imply coauthorship).
SnoopJ reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@iritkatriel

iritkatriel commented May 11, 2023

Copy link
Copy Markdown
Member

there's a test failure
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@SnoopJ
Use correct name in doctest expected output
5f6aecb
@SnoopJ SnoopJ mentioned this pull request May 11, 2023
gh-104301: Tidy pdb documentation of exclamation prefix #104302
Closed
@iritkatriel
iritkatriel merged commit 0449ffe into python:main May 11, 2023
@bedevere-bot bedevere-bot removed the awaiting merge label May 11, 2023
@SnoopJ
SnoopJ deleted the gh-104301_pdb-allow-leading-statement-whitespace branch May 11, 2023 17:18
carljm added a commit to carljm/cpython that referenced this pull request May 12, 2023
@carljm
Merge branch 'main' into supermon
8efd7c6 
* main:
  pythongh-91896: Fixup some docs issues following ByteString deprecation (python#104422)
  pythonGH-104371: check return value of calling `mv.release` (python#104417)
  pythongh-104415: Fix refleak tests for `typing.ByteString` deprecation (python#104416)
  pythonGH-86275: Implementation of hypothesis stubs for property-based tests, with zoneinfo tests (python#22863)
  pythonGH-103082: Filter LINE events in VM, to simplify tool implementation. (pythonGH-104387)
  pythongh-93649: Split gc- and allocation tests from _testcapimodule.c (pythonGH-104403)
  pythongh-104389: Add 'unused' keyword to Argument Clinic C converters (python#104390)
  pythongh-101819: Prepare _io._IOBase for module state (python#104386)
  pythongh-104413: Fix refleak when super attribute throws AttributeError (python#104414)
  Fix refleak in `super_descr_get` (python#104408)
  pythongh-87526: Remove dead initialization from _zoneinfo parse_abbr() (python#24700)
  pythongh-91896: Improve visibility of `ByteString` deprecation warnings (python#104294)
  pythongh-104371: Fix calls to `__release_buffer__` while an exception is active (python#104378)
  pythongh-104377: fix cell in comprehension that is free in outer scope (python#104394)
  pythongh-104392: Remove _paramspec_tvars from typing (python#104393)
  pythongh-104396: uuid.py to skip platform check for emscripten and wasi (pythongh-104397)
  pythongh-99108: Refresh HACL* from upstream (python#104401)
  pythongh-104301: Allow leading whitespace in disambiguated pdb statements (python#104342)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iritkatriel iritkatriel iritkatriel approved these changes
@gaogaotiantian gaogaotiantian gaogaotiantian approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

stdlib Standard Library Python modules in the Lib/ directory type-feature A feature request or enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Misleading documentation of ! prefix in pdb

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@SnoopJ @iritkatriel @gaogaotiantian @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.