GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-91896: Fixup some docs issues following ByteString deprecation by AlexWaygood · Pull Request #104422 · python/cpython

Conversation

@AlexWaygood

@AlexWaygood AlexWaygood commented May 12, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Get the doctests for collections.abc working again (see https://github.com/python/cpython/actions/runs/4957850824/jobs/8870015699 as an example failure). It was broken by gh-91896: Improve visibility of ByteString deprecation warnings #104294
  • Explicitly note in whatsnew that typing.ByteString now causes DeprecationWarnings, as well as collections.abc.ByteString.
  • Issue: Deprecate and schedule removal of collections.abc.ByteString and typing.ByteString #91896

📚 Documentation preview 📚: https://cpython-previews--104422.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@AlexWaygood
pythongh-102500: Fixup some docs issues following ByteString deprecation
efc9106
@AlexWaygood AlexWaygood added skip news topic-typing 3.12 only security fixes labels May 12, 2023
@AlexWaygood
AlexWaygood requested review from JelleZijlstra and hauntsaninja May 12, 2023 14:22
@AlexWaygood
AlexWaygood requested a review from rhettinger as a code owner May 12, 2023 14:22
@bedevere-bot bedevere-bot added the awaiting core review label May 12, 2023
@bedevere-bot bedevere-bot mentioned this pull request May 12, 2023
Implement PEP 688: Making the buffer protocol accessible in Python #102500
Closed
@bedevere-bot bedevere-bot added the docs Documentation in the Doc dir label May 12, 2023
@AlexWaygood AlexWaygood changed the title gh-102500: Fixup some docs issues following ByteString deprecation gh-91896: Fixup some docs issues following ByteString deprecation May 12, 2023
@bedevere-bot bedevere-bot mentioned this pull request May 12, 2023
Deprecate and schedule removal of collections.abc.ByteString and typing.ByteString #91896
Closed
JelleZijlstra
JelleZijlstra reviewed May 12, 2023
View reviewed changes
Comment thread Doc/whatsnew/3.12.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Doc/library/collections.abc.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
@AlexWaygood @JelleZijlstra
Update Doc/library/collections.abc.rst
937ce5e 
Co-authored-by: Jelle Zijlstra <[email protected]>
JelleZijlstra
JelleZijlstra approved these changes May 12, 2023
View reviewed changes

@JelleZijlstra JelleZijlstra left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to get this merged so we can get CI green, but we should consider whether the import * case is important enough to drop the warning. This would be annoying:

% ./python.exe -Werr
Python 3.12.0a7+ (heads/tvobject-dirty:bc3757969b, May 12 2023, 06:50:26) [Clang 14.0.0 (clang-1400.0.29.202)] on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>> from typing import *
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/Users/jelle/py/cpython/Lib/typing.py", line 3328, in __getattr__
    warnings._deprecated("typing.ByteString", remove=(3, 14))
  File "/Users/jelle/py/cpython/Lib/warnings.py", line 529, in _deprecated
    warn(msg, DeprecationWarning, stacklevel=3)
DeprecationWarning: 'typing.ByteString' is deprecated and slated for removal in Python 3.14
>>>

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels May 12, 2023
@AlexWaygood
AlexWaygood merged commit ce4eecf into python:main May 12, 2023
@bedevere-bot bedevere-bot removed the awaiting merge label May 12, 2023
@AlexWaygood AlexWaygood mentioned this pull request May 12, 2023
gh-91896: Revert some very noisy DeprecationWarnings for ByteString #104424
Merged
carljm added a commit to carljm/cpython that referenced this pull request May 12, 2023
@carljm
Merge branch 'main' into supermon
8efd7c6 
* main:
  pythongh-91896: Fixup some docs issues following ByteString deprecation (python#104422)
  pythonGH-104371: check return value of calling `mv.release` (python#104417)
  pythongh-104415: Fix refleak tests for `typing.ByteString` deprecation (python#104416)
  pythonGH-86275: Implementation of hypothesis stubs for property-based tests, with zoneinfo tests (python#22863)
  pythonGH-103082: Filter LINE events in VM, to simplify tool implementation. (pythonGH-104387)
  pythongh-93649: Split gc- and allocation tests from _testcapimodule.c (pythonGH-104403)
  pythongh-104389: Add 'unused' keyword to Argument Clinic C converters (python#104390)
  pythongh-101819: Prepare _io._IOBase for module state (python#104386)
  pythongh-104413: Fix refleak when super attribute throws AttributeError (python#104414)
  Fix refleak in `super_descr_get` (python#104408)
  pythongh-87526: Remove dead initialization from _zoneinfo parse_abbr() (python#24700)
  pythongh-91896: Improve visibility of `ByteString` deprecation warnings (python#104294)
  pythongh-104371: Fix calls to `__release_buffer__` while an exception is active (python#104378)
  pythongh-104377: fix cell in comprehension that is free in outer scope (python#104394)
  pythongh-104392: Remove _paramspec_tvars from typing (python#104393)
  pythongh-104396: uuid.py to skip platform check for emscripten and wasi (pythongh-104397)
  pythongh-99108: Refresh HACL* from upstream (python#104401)
  pythongh-104301: Allow leading whitespace in disambiguated pdb statements (python#104342)
@AlexWaygood
AlexWaygood deleted the more-bytestring-deprecations branch May 12, 2023 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes
@hauntsaninja hauntsaninja Awaiting requested review from hauntsaninja
@rhettinger rhettinger Awaiting requested review from rhettinger rhettinger is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

3.12 only security fixes docs Documentation in the Doc dir skip news topic-typing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@AlexWaygood @JelleZijlstra @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.