GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-87526: Remove dead initialization from parse_abbr function by alexhenrie · Pull Request #24700 · python/cpython

Conversation

@alexhenrie

@alexhenrie alexhenrie commented Mar 2, 2021 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Straightforward dead code elimination.

https://bugs.python.org/issue43360

  • Issue: Dead initialization in parse_abbr function #87526

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Mar 2, 2021
@bedevere-bot bedevere-bot added the awaiting review label Mar 2, 2021
@github-actions

github-actions Bot commented Apr 2, 2021

Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot added the stale Stale PR or inactive for long period of time. label Apr 2, 2021
@ezio-melotti ezio-melotti removed the CLA signed label Jul 13, 2022
@github-actions github-actions Bot removed the stale Stale PR or inactive for long period of time. label Aug 4, 2022
furkanonder
furkanonder approved these changes May 9, 2023
View reviewed changes
@bedevere-bot bedevere-bot added awaiting core review and removed awaiting review labels May 9, 2023
@furkanonder

furkanonder commented May 9, 2023

Copy link
Copy Markdown
Contributor

LGTM. @alexhenrie Can you add the news entry?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@furkanonder

furkanonder commented May 9, 2023

Copy link
Copy Markdown
Contributor

CC: @vstinner
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@arhadthedev

arhadthedev commented May 9, 2023

Copy link
Copy Markdown
Member

Can you add the news entry?

This change is invisible to users and irrelevant for contributors so adding skip news .
furkanonder reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@arhadthedev arhadthedev added the skip news label May 9, 2023
@arhadthedev arhadthedev changed the title bpo-43360: Remove dead initialization from parse_abbr function gh-87526: Remove dead initialization from parse_abbr function May 9, 2023
@bedevere-bot bedevere-bot added awaiting review and removed awaiting core review labels May 9, 2023
vstinner
vstinner reviewed May 9, 2023
View reviewed changes
Comment thread Modules/_zoneinfo.c Outdated
{
const char *ptr = p;
char buff = *ptr;
char buff;

@vstinner vstinner May 9, 2023

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest to move the variable declaration closer to where it's used: inside the if block at least.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@alexhenrie alexhenrie May 12, 2023

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@alexhenrie
bpo-43360: Remove dead initialization from parse_abbr function
56c7acf
@alexhenrie
alexhenrie force-pushed the parse_abbr branch from c91d86f to 56c7acf Compare May 12, 2023 01:39
@vstinner
vstinner merged commit 3c2992e into python:main May 12, 2023
@bedevere-bot bedevere-bot removed the awaiting review label May 12, 2023
@vstinner

vstinner commented May 12, 2023

Copy link
Copy Markdown
Member

Merged, thanks.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@alexhenrie alexhenrie mannequin mentioned this pull request Apr 5, 2023
Dead initialization in parse_abbr function #87526
Closed
carljm added a commit to carljm/cpython that referenced this pull request May 12, 2023
@carljm
Merge branch 'main' into supermon
8efd7c6 
* main:
  pythongh-91896: Fixup some docs issues following ByteString deprecation (python#104422)
  pythonGH-104371: check return value of calling `mv.release` (python#104417)
  pythongh-104415: Fix refleak tests for `typing.ByteString` deprecation (python#104416)
  pythonGH-86275: Implementation of hypothesis stubs for property-based tests, with zoneinfo tests (python#22863)
  pythonGH-103082: Filter LINE events in VM, to simplify tool implementation. (pythonGH-104387)
  pythongh-93649: Split gc- and allocation tests from _testcapimodule.c (pythonGH-104403)
  pythongh-104389: Add 'unused' keyword to Argument Clinic C converters (python#104390)
  pythongh-101819: Prepare _io._IOBase for module state (python#104386)
  pythongh-104413: Fix refleak when super attribute throws AttributeError (python#104414)
  Fix refleak in `super_descr_get` (python#104408)
  pythongh-87526: Remove dead initialization from _zoneinfo parse_abbr() (python#24700)
  pythongh-91896: Improve visibility of `ByteString` deprecation warnings (python#104294)
  pythongh-104371: Fix calls to `__release_buffer__` while an exception is active (python#104378)
  pythongh-104377: fix cell in comprehension that is free in outer scope (python#104394)
  pythongh-104392: Remove _paramspec_tvars from typing (python#104393)
  pythongh-104396: uuid.py to skip platform check for emscripten and wasi (pythongh-104397)
  pythongh-99108: Refresh HACL* from upstream (python#104401)
  pythongh-104301: Allow leading whitespace in disambiguated pdb statements (python#104342)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner left review comments
@furkanonder furkanonder furkanonder approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

7 participants

@alexhenrie @furkanonder @arhadthedev @vstinner @the-knights-who-say-ni @ezio-melotti @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.