GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-67056: document that registering/unregistering an atexit func from within an atexit func is undefined by iritkatriel · Pull Request #104473 · python/cpython

Conversation

@iritkatriel

@iritkatriel iritkatriel commented May 14, 2023 •
edited by github-actions Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Fixes #67056.

  • Issue: document behavior of calling atexit.register() while atexit._run_exitfuncs is running #67056

📚 Documentation preview 📚: https://cpython-previews--104473.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@iritkatriel
pythongh-67056: document that registering/unregistering an atexit fun…
d3127cd 
…c from within an atexit func is undefined
@iritkatriel iritkatriel added docs Documentation in the Doc dir stdlib Standard Library Python modules in the Lib/ directory needs backport to 3.11 only security fixes labels May 14, 2023
@bedevere-bot bedevere-bot added the awaiting core review label May 14, 2023
@bedevere-bot bedevere-bot mentioned this pull request May 14, 2023
document behavior of calling atexit.register() while atexit._run_exitfuncs is running #67056
Closed
@bedevere-bot bedevere-bot added the skip news label May 14, 2023
iritkatriel and others added 2 commits May 14, 2023 12:11
@iritkatriel
add news
ed682f6
@iritkatriel
Merge branch 'main' into atexit-doc
38d6721
@iritkatriel

iritkatriel commented May 14, 2023

Copy link
Copy Markdown
Member Author

@smontanaro how's this?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Eclips4
Eclips4 reviewed May 14, 2023
View reviewed changes
Comment thread Misc/NEWS.d/next/Documentation/2023-05-14-12-11-28.gh-issue-67056.nVC2Rf.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
@iritkatriel @Eclips4
typo
3c6901e 
Co-authored-by: Kirill Podoprigora <[email protected]>
@smontanaro

smontanaro commented May 14, 2023

Copy link
Copy Markdown
Contributor

LGTM. I probably would have just added a Note to the top of the rst file (near the other note) instead of adding the same text to both function descriptions.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
iritkatriel added 2 commits May 14, 2023 22:35
@iritkatriel
Revert "pythongh-67056: document that registering/unregistering an at…
e23c17b 
…exit func from within an atexit func is undefined"

This reverts commit d3127cd.
@iritkatriel
add comment at the top
09a26fd
@iritkatriel

iritkatriel commented May 14, 2023

Copy link
Copy Markdown
Member Author

LGTM. I probably would have just added a Note to the top of the rst file (near the other note) instead of adding the same text to both function descriptions.

I agree. How's this version?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
iritkatriel
iritkatriel commented May 14, 2023
View reviewed changes
Comment thread Doc/library/atexit.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
@iritkatriel
typo
0972d0a
@smontanaro

smontanaro commented May 14, 2023 via email

Copy link
Copy Markdown
Contributor
👍
…
On Sun, May 14, 2023, 4:39 PM Irit Katriel ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In Doc/library/atexit.rst <#104473 (comment)>: > @@ -20,6 +20,9 @@ at interpreter termination time they will be run in the order ``C``, ``B``, program is killed by a signal not handled by Python, when a Python fatal internal error is detected, or when :func:`os._exit` is called. +**Note:** The effect of registering or unregistering functions from within +a cleanup function is underfined. ⬇️ Suggested change -a cleanup function is underfined. +a cleanup function is undefined. — Reply to this email directly, view it on GitHub <#104473 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AA2E3INK7W2X4FNXETPIQF3XGFGH3ANCNFSM6AAAAAAYBC4DE4> . You are receiving this because you were mentioned.Message ID: ***@***.***>
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@iritkatriel
iritkatriel merged commit b15a1a6 into python:main May 15, 2023
@miss-islington

miss-islington commented May 15, 2023

Copy link
Copy Markdown
Contributor

Thanks @iritkatriel for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting core review label May 15, 2023
@bedevere-bot

bedevere-bot commented May 15, 2023

Copy link
Copy Markdown

GH-104500 is a backport of this pull request to the 3.11 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label May 15, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 15, 2023
@iritkatriel @miss-islington
pythongh-67056: document that registering/unregistering an atexit fun…
6ade9ea 
…c from within an atexit func is undefined (pythonGH-104473)

(cherry picked from commit b15a1a6)

Co-authored-by: Irit Katriel <[email protected]>
iritkatriel pushed a commit that referenced this pull request May 15, 2023
@miss-islington
[3.11] gh-67056: document that registering/unregistering an atexit fu…
a712c5f 
…nc from within an atexit func is undefined (GH-104473) (#104500)
carljm added a commit to carljm/cpython that referenced this pull request May 15, 2023
@carljm
Merge branch 'main' into supermon
343867a 
* main: (29 commits)
  pythongh-101819: Fix _io clinic input for unused base class method stubs (python#104418)
  pythongh-101819: Isolate `_io` (python#101948)
  Bump mypy from 1.2.0 to 1.3.0 in /Tools/clinic (python#104501)
  pythongh-104494: Update certain Tkinter pack/place tests for Tk 8.7 errors (python#104495)
  pythongh-104050: Run mypy on `clinic.py` in CI (python#104421)
  pythongh-104490: Consistently define phony make targets (python#104491)
  pythongh-67056: document that registering/unregistering an atexit func from within an atexit func is undefined (python#104473)
  pythongh-104487: PYTHON_FOR_REGEN must be minimum Python 3.10 (python#104488)
  pythongh-101282: move BOLT config after PGO (pythongh-104493)
  pythongh-104469 Convert _testcapi/float.c to use AC (pythongh-104470)
  pythongh-104456: Fix ref leak in _ctypes.COMError (python#104457)
  pythongh-98539: Make _SSLTransportProtocol.abort() safe to call when closed (python#104474)
  pythongh-104337: Clarify random.gammavariate doc entry  (python#104410)
  Minor improvements to typing docs (python#104465)
  pythongh-87092: avoid gcc warning on uninitialized struct field in assemble.c (python#104460)
  pythonGH-71383: IDLE - Document testing subsets of modules (python#104463)
  pythongh-104454: Fix refleak in AttributeError_reduce (python#104455)
  pythongh-75710: IDLE - add docstrings and comments to editor module (python#104446)
  pythongh-91896: Revert some very noisy DeprecationWarnings for `ByteString` (python#104424)
  Add a mention of PYTHONBREAKPOINT to breakpoint() docs (python#104430)
  ...
carljm added a commit to carljm/cpython that referenced this pull request May 15, 2023
@carljm
Merge branch 'main' into cached_property_docs
452d9f5 
* main: (204 commits)
  pythongh-101819: Fix _io clinic input for unused base class method stubs (python#104418)
  pythongh-101819: Isolate `_io` (python#101948)
  Bump mypy from 1.2.0 to 1.3.0 in /Tools/clinic (python#104501)
  pythongh-104494: Update certain Tkinter pack/place tests for Tk 8.7 errors (python#104495)
  pythongh-104050: Run mypy on `clinic.py` in CI (python#104421)
  pythongh-104490: Consistently define phony make targets (python#104491)
  pythongh-67056: document that registering/unregistering an atexit func from within an atexit func is undefined (python#104473)
  pythongh-104487: PYTHON_FOR_REGEN must be minimum Python 3.10 (python#104488)
  pythongh-101282: move BOLT config after PGO (pythongh-104493)
  pythongh-104469 Convert _testcapi/float.c to use AC (pythongh-104470)
  pythongh-104456: Fix ref leak in _ctypes.COMError (python#104457)
  pythongh-98539: Make _SSLTransportProtocol.abort() safe to call when closed (python#104474)
  pythongh-104337: Clarify random.gammavariate doc entry  (python#104410)
  Minor improvements to typing docs (python#104465)
  pythongh-87092: avoid gcc warning on uninitialized struct field in assemble.c (python#104460)
  pythonGH-71383: IDLE - Document testing subsets of modules (python#104463)
  pythongh-104454: Fix refleak in AttributeError_reduce (python#104455)
  pythongh-75710: IDLE - add docstrings and comments to editor module (python#104446)
  pythongh-91896: Revert some very noisy DeprecationWarnings for `ByteString` (python#104424)
  Add a mention of PYTHONBREAKPOINT to breakpoint() docs (python#104430)
  ...
@iritkatriel
iritkatriel deleted the atexit-doc branch July 25, 2023 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Eclips4 Eclips4 Eclips4 left review comments

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news stdlib Standard Library Python modules in the Lib/ directory

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

document behavior of calling atexit.register() while atexit._run_exitfuncs is running

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@iritkatriel @smontanaro @miss-islington @bedevere-bot @Eclips4
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.