GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fix inaccuracies in "Assorted Topics" section of "Defining Extension Types" tutorial by chgnrdv · Pull Request #104969 · python/cpython

Conversation

@chgnrdv

@chgnrdv chgnrdv commented May 26, 2023 •
edited by github-actions Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

📚 Documentation preview 📚: https://cpython-previews--104969.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
chgnrdv added 2 commits May 26, 2023 14:24
@chgnrdv
Fix inaccuracies in "Assorted Topics" section of "Defining Extension …
88e707d 
…Types" tutorial
@chgnrdv
fixed names in richcmp signature
113d6cf
@bedevere-bot bedevere-bot added awaiting review docs Documentation in the Doc dir skip news labels May 26, 2023
@arhadthedev arhadthedev added the skip issue label May 26, 2023
@chgnrdv

chgnrdv commented May 26, 2023

Copy link
Copy Markdown
Contributor Author

Guess it needs to be backported to 3.11 and 3.12.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Eclips4
Eclips4 approved these changes May 26, 2023
View reviewed changes
@bedevere-bot bedevere-bot added awaiting core review and removed awaiting review labels May 26, 2023
kumaraditya303
kumaraditya303 approved these changes Jun 16, 2023
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Jun 16, 2023
@kumaraditya303 kumaraditya303 added needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Jun 16, 2023
@kumaraditya303
kumaraditya303 enabled auto-merge (squash) June 16, 2023 07:10
@kumaraditya303
kumaraditya303 merged commit 0d09637 into python:main Jun 16, 2023
@miss-islington

miss-islington commented Jun 16, 2023

Copy link
Copy Markdown
Contributor

Thanks @chgnrdv for the PR, and @kumaraditya303 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting merge label Jun 16, 2023
@miss-islington

miss-islington commented Jun 16, 2023

Copy link
Copy Markdown
Contributor

Sorry, @chgnrdv and @kumaraditya303, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 0d0963737a0f4b7cadedfae7e8fd33ed18269289 3.11
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington miss-islington assigned kumaraditya303 Jun 16, 2023
@bedevere-bot

bedevere-bot commented Jun 16, 2023

Copy link
Copy Markdown

GH-105850 is a backport of this pull request to the 3.12 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.12 only security fixes label Jun 16, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 16, 2023
@chgnrdv @miss-islington
Fix inaccuracies in "Assorted Topics" section of "Defining Extension …
e295710 
…Types" tutorial (pythonGH-104969)

(cherry picked from commit 0d09637)

Co-authored-by: chgnrdv <[email protected]>
kumaraditya303 pushed a commit that referenced this pull request Jun 16, 2023
@miss-islington @chgnrdv
[3.12] Fix inaccuracies in "Assorted Topics" section of "Defining Ext…
6f0f27e 
…ension Types" tutorial (GH-104969) (#105850)

Fix inaccuracies in "Assorted Topics" section of "Defining Extension Types" tutorial (GH-104969)
(cherry picked from commit 0d09637)

Co-authored-by: chgnrdv <[email protected]>
carljm added a commit to carljm/cpython that referenced this pull request Jun 16, 2023
@carljm
Merge branch 'main' into modulelocals
b096651 
* main:
  pythongh-104799: PEP 695 backward compatibility for ast.unparse (python#105846)
  pythongh-105834: Add tests for calling `issubclass()` between two protocols (python#105835)
  CI: Remove docs build from Azure Pipelines (python#105823)
  pythongh-105844: Consistently use 'minor version' for X.Y versions (python#105851)
  Fix inaccuracies in "Assorted Topics" section of "Defining Extension Types" tutorial (python#104969)
  pythongh-105433: Add `pickle` tests for PEP695 (python#105443)
  bpo-44530: Document the change in MAKE_FUNCTION behavior (python#93189)
  pythonGH-103124: Multiline statement support for pdb (pythonGH-103125)
  pythonGH-105588: Add missing error checks to some obj2ast_* converters (pythonGH-105589)
gvanrossum pushed a commit to gvanrossum/cpython that referenced this pull request Jun 18, 2023
@chgnrdv @gvanrossum
Fix inaccuracies in "Assorted Topics" section of "Defining Extension …
48f5a2b 
…Types" tutorial (python#104969)
@ZeroIntensity ZeroIntensity removed the needs backport to 3.11 only security fixes label Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kumaraditya303 kumaraditya303 kumaraditya303 approved these changes
@Eclips4 Eclips4 Eclips4 approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@kumaraditya303 kumaraditya303

Labels

docs Documentation in the Doc dir skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

7 participants

@chgnrdv @miss-islington @bedevere-bot @kumaraditya303 @Eclips4 @arhadthedev @ZeroIntensity
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.