GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-103921: Minor PEP-695 fixes to the `ast` module docs by AlexWaygood · Pull Request #105093 · python/cpython

Conversation

@AlexWaygood

@AlexWaygood AlexWaygood commented May 30, 2023 •
edited by github-actions Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Following #104828 (and #104974, the backport to 3.12), the ast docs are no longer quite accurate on some new PEP-695 fields.

  • Issue: Document PEP 695 #103921

📚 Documentation preview 📚: https://cpython-previews--105093.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@AlexWaygood
Minor PEP-695 fixes to the ast module docs
a4acf10
@AlexWaygood
AlexWaygood requested a review from JelleZijlstra May 30, 2023 14:55
@bedevere-bot bedevere-bot added the awaiting core review label May 30, 2023
@bedevere-bot bedevere-bot mentioned this pull request May 30, 2023
Document PEP 695 #103921
Closed
9 tasks done
@bedevere-bot bedevere-bot added docs Documentation in the Doc dir skip news labels May 30, 2023
@AlexWaygood AlexWaygood added the needs backport to 3.12 only security fixes label May 30, 2023
carljm
carljm approved these changes May 30, 2023
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels May 30, 2023
JelleZijlstra
JelleZijlstra approved these changes May 30, 2023
View reviewed changes
@JelleZijlstra
JelleZijlstra merged commit c8c1e73 into python:main May 30, 2023
@miss-islington

miss-islington commented May 30, 2023

Copy link
Copy Markdown
Contributor

Thanks @AlexWaygood for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting merge label May 30, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 30, 2023
@AlexWaygood @miss-islington
pythongh-103921: Minor PEP-695 fixes to the ast module docs (python…
9f193f3 
…GH-105093)

(cherry picked from commit c8c1e73)

Co-authored-by: Alex Waygood <[email protected]>
@bedevere-bot

bedevere-bot commented May 30, 2023

Copy link
Copy Markdown

GH-105101 is a backport of this pull request to the 3.12 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.12 only security fixes label May 30, 2023
@AlexWaygood
AlexWaygood deleted the 695-ast-docs branch May 30, 2023 16:19
JelleZijlstra pushed a commit that referenced this pull request May 30, 2023
@miss-islington @AlexWaygood
[3.12] gh-103921: Minor PEP-695 fixes to the ast module docs (GH-10…
9fb7abb 
…5093) (#105101)

(cherry picked from commit c8c1e73)

Co-authored-by: Alex Waygood <[email protected]>
carljm added a commit to carljm/cpython that referenced this pull request May 30, 2023
@carljm
Merge branch 'main' into superbadgetattro
24e1159 
* main:
  CI: Temporarily skip paths with spaces to avoid error (python#105110)
  pythongh-105071: add missing versionadded directive (python#105097)
  pythongh-80064: Fix is_valid_wide_char() return type (python#105099)
  Small speedup for dataclass __eq__ and __repr__ (python#104904)
  pythongh-103921: Minor PEP-695 fixes to the `ast` module docs (python#105093)
  pythongh-105091: stable_abi.py: Remove "Unixy" check from --all on other platforms (pythonGH-105092)
@erlend-aasland erlend-aasland mentioned this pull request Jun 6, 2023
3.12 backport gh 105236 #105358
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@carljm carljm carljm approved these changes
@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@AlexWaygood @miss-islington @bedevere-bot @carljm @JelleZijlstra
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.