GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — gh-146245: Fix reference and buffer leaks via audit hook in socket module by aisk · Pull Request #146248 · python/cpython

Conversation

aisk commented Mar 21, 2026 •

edited by bedevere-app Bot

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Member

Issue: socketmodule.c: Reference and buffer leaks via audit hook failures #146245

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

aisk added 2 commits

March 21, 2026 16:32


          Fix reference and buffer leaks audit hook in socket module

bef84d6


          Add tests for socket audit hook leak

8c837e7

bedevere-app Bot mentioned this pull request

Mar 21, 2026

socketmodule.c: Reference and buffer leaks via audit hook failures #146245

Closed

bedevere-app Bot added the awaiting review label

Mar 21, 2026

blurb-it Bot and others added 3 commits

March 21, 2026 08:48


          📜🤖 Added by blurb_it.

27f2e2f


          Fix news entry

1321d47


          Utilize assertAlmostEqual with delta in tests

026d272

aisk changed the title ~~gh-146245: Fix reference and buffer leaks audit hook in socket module~~ gh-146245: Fix reference and buffer leaks via audit hook in socket module

Mar 21, 2026

serhiy-storchaka reviewed

Mar 21, 2026

View reviewed changes

serhiy-storchaka left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix LGTM. I am not sure that it is worth to add such complicated and costly test. There is no precedence.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

Lib/test/test_socket.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

aisk added 2 commits

March 21, 2026 19:26


          Simplify the codes

396b8c6


          Revert the tests

6e079ab

aisk commented Mar 21, 2026

Copy link

Copy Markdown

Member Author

The fix LGTM. I am not sure that it is worth to add such complicated and costly test. There is no precedence.

The tests are reverted.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

serhiy-storchaka approved these changes

Mar 22, 2026

View reviewed changes

serhiy-storchaka left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 👍

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

bedevere-app Bot added awaiting merge and removed awaiting review labels

Mar 22, 2026

serhiy-storchaka added needs backport to 3.13

only security fixes

needs backport to 3.14 bugs and security fixes and removed awaiting merge labels

Mar 22, 2026

serhiy-storchaka merged commit c30fae4 into python:main

Mar 22, 2026

94 of 102 checks passed

Uh oh!

There was an error while loading. Please reload this page.

miss-islington-app Bot commented Mar 22, 2026

Copy link

Copy Markdown

Thanks @aisk for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Mar 22, 2026


          pythongh-146245: Fix reference and buffer leaks via audit hook in soc…

6bfcd89

…ket module (pythonGH-146248)

(cherry picked from commit c30fae4)

Co-authored-by: AN Long <[email protected]>

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Mar 22, 2026


          pythongh-146245: Fix reference and buffer leaks via audit hook in soc…

c64d830

…ket module (pythonGH-146248)

(cherry picked from commit c30fae4)

Co-authored-by: AN Long <[email protected]>

bedevere-app Bot commented Mar 22, 2026

Copy link

Copy Markdown

GH-146274 is a backport of this pull request to the 3.14 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label

Mar 22, 2026

bedevere-app Bot commented Mar 22, 2026

Copy link

Copy Markdown

GH-146275 is a backport of this pull request to the 3.13 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-app Bot removed the needs backport to 3.13 only security fixes label

Mar 22, 2026

serhiy-storchaka pushed a commit that referenced this pull request

Mar 22, 2026


          [3.13] gh-146245: Fix reference and buffer leaks via audit hook in so…

2f1e341

…cket module (GH-146248) (GH-146275)

(cherry picked from commit c30fae4)

Co-authored-by: AN Long <[email protected]>

serhiy-storchaka pushed a commit that referenced this pull request

Mar 22, 2026


          [3.14] gh-146245: Fix reference and buffer leaks via audit hook in so…

69a37be

…cket module (GH-146248) (GH-146274)

(cherry picked from commit c30fae4)

Co-authored-by: AN Long <[email protected]>

CuriousLearner added a commit to CuriousLearner/cpython that referenced this pull request

Mar 23, 2026


          Merge branch 'main' of github.com:python/cpython into fix-pythongh-13…

3e05fa3

…8577

* 'main' of github.com:python/cpython:
  pythongh-146197: Run -m test.pythoninfo on the Emscripten CI (python#146332)
  pythongh-146325: Use `test.support.requires_fork` in test_fastpath_cache_cleared_in_forked_child (python#146330)
  pythongh-146197: Add Emscripten to CI (python#146198)
  pythongh-143387: Raise an exception instead of returning None when metadata file is missing. (python#146234)
  pythongh-108907: ctypes: Document _type_ codes (pythonGH-145837)
  pythongh-146175: Soft-deprecate outdated macros; convert internal usage (pythonGH-146178)
  pythongh-146056: Rework ref counting in treebuilder_handle_end() (python#146167)
  Add a warning about untrusted input to `configparser` docs (python#146276)
  pythongh-145264: Do not ignore excess Base64 data after the first padded quad (pythonGH-145267)
  pythongh-146308: Fix error handling issues in _remote_debugging module (python#146309)
  pythongh-146192: Add base32 support to binascii (pythonGH-146193)
  pythongh-135953: Properly obtain main thread identifier in Gecko Collector (python#146045)
  pythongh-143414: Implement unique reference tracking for JIT, optimize unpacking of such tuples (pythonGH-144300)
  pythongh-146261: Fix bug in `_Py_uop_sym_set_func_version` (pythonGH-146291)
  pythongh-145144: Add more tests for UserList, UserDict, etc (pythonGH-145145)
  pythongh-143959: Fix test_datetime if _datetime is unavailable (pythonGH-145248)
  pythongh-146245: Fix reference and buffer leaks via audit hook in socket module (pythonGH-146248)
  pythongh-140049: Colorize exception notes in `traceback.py` (python#140051)
  Update docs for pythongh-146056 (pythonGH-146213)

pablogsal mentioned this pull request

Apr 4, 2026

gh-130273: Fix traceback color output with unicode characters #142529

Merged

ljfp pushed a commit to ljfp/cpython that referenced this pull request

Apr 25, 2026


          pythongh-146245: Fix reference and buffer leaks via audit hook in soc…

fec6f91

…ket module (pythonGH-146248)

aisk deleted the socket-audit-leak branch

June 20, 2026 10:41

Reviewers

serhiy-storchaka

serhiy-storchaka approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

aisk commented Mar 21, 2026 • edited by bedevere-app Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

serhiy-storchaka left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

aisk commented Mar 21, 2026

Uh oh!

serhiy-storchaka left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

miss-islington-app Bot commented Mar 22, 2026

Uh oh!

bedevere-app Bot commented Mar 22, 2026

Uh oh!

bedevere-app Bot commented Mar 22, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

aisk commented Mar 21, 2026 •

edited by bedevere-app Bot

Loading

Uh oh!

There was an error while loading. Please reload this page.