GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Minor edits to the Descriptor HowTo Guide by geryogam · Pull Request #24901 · python/cpython

Conversation

@geryogam

@geryogam geryogam commented Mar 17, 2021 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

This PR provides the following changes to the Descriptor HowTo Guide:

  • fix a typo;
  • fix a Sphinx tag preventing syntax highlighting;
  • fix a bug in ClassMethod;
  • reuse an existing cls name in Object;
  • allow keyword arguments in Type.__new__ and Object.__new__;
  • allow attribute lookup from a class in Member.__get__;
  • use two more super() in Object and Type for consistency.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@geryogam
Fix wrong Sphinx markup preventing syntax highlighting
58b799d
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Mar 17, 2021
@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels Mar 17, 2021
geryogam added 3 commits March 17, 2021 11:32
@geryogam
Fix a bug in the ClassMethod Python equivalent
f77b0f9
@geryogam
Fix the description of the ClassMethod Python equivalent
1dbd876
@geryogam
Raise TypeError for __get__(None, None) calls
d0d301e
@geryogam geryogam changed the title Fix a bug in the ClassMethod Python equivalent of the Descriptor HowTo Guide Fix a few bugs in the Python equivalent code of the Descriptor HowTo Guide Mar 19, 2021
@geryogam geryogam changed the title Fix a few bugs in the Python equivalent code of the Descriptor HowTo Guide Fix a few bugs in the Python equivalents of the Descriptor HowTo Guide Mar 19, 2021
geryogam added 4 commits March 22, 2021 16:43
@geryogam
Fix a typo
e87fe37
@geryogam
Use the existing cls variable
52a06d0
@geryogam
Allow keyword arguments in Object.__new__
2f9971b
@geryogam
Use two more super() for consistency
2f335ca
@geryogam geryogam changed the title Fix a few bugs in the Python equivalents of the Descriptor HowTo Guide Fix the Python equivalents of the Descriptor HowTo Guide Mar 31, 2021
geryogam added 7 commits March 31, 2021 18:18
@geryogam
Add Object.__getattribute__ to raise AttributeError with the correct …
4886dbb 
…message for misspelled attributes (including __dict__)
@geryogam
Allow attribute lookup from a class in Member.__get__
705c577
@geryogam
Allow keyword arguments in Type.__new__
c0e6432
@geryogam
Raise ValueError for slot names conflicting with class variables
81ec93c
@geryogam
Update descriptor.rst
34eef3a
@geryogam
Raise TypeError for non-empty __slots__ in subclasses of variable-len…
ae8c622 
…gth built-in types (int, tuple, bytes)
@geryogam
Raise TypeError for non-empty __slots__ in subclasses of variable-len…
1d5fb96 
…gth built-in types (int, tuple, bytes)
@github-actions

github-actions Bot commented Jun 5, 2021

Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot added the stale Stale PR or inactive for long period of time. label Jun 5, 2021
@merwok

merwok commented Feb 11, 2022

Copy link
Copy Markdown
Member

Can you open a ticket (with Raymond Hettinger in nosy) to discuss the problems you have identified here?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@geryogam

geryogam commented Feb 11, 2022

Copy link
Copy Markdown
Contributor Author

@merwok Thanks for the suggestion, that’s what I intended to do. The rest of the PR is completed but I still have to finish the last section on __slots__ (I completed my tests on it last year but I did not take the extra days necessary to update this PR). I will try to find a weekend shortly to do it.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
rhettinger
rhettinger reviewed May 10, 2022
View reviewed changes
Comment thread Doc/howto/descriptor.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
rhettinger
rhettinger requested changes May 10, 2022
View reviewed changes
Comment thread Doc/howto/descriptor.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Doc/howto/descriptor.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Doc/howto/descriptor.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Doc/howto/descriptor.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Doc/howto/descriptor.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Doc/howto/descriptor.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Doc/howto/descriptor.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Doc/howto/descriptor.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Doc/howto/descriptor.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Doc/howto/descriptor.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting review label May 10, 2022
@bedevere-bot

bedevere-bot commented May 10, 2022

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot added the awaiting changes label May 10, 2022
@geryogam
geryogam requested a review from rhettinger October 4, 2022 21:37
@rhettinger
Merge branch 'main' into patch-14
c853e6b
@merwok

merwok commented Oct 7, 2022

Copy link
Copy Markdown
Member

Please open a ticket to track this properly.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@geryogam geryogam mentioned this pull request Oct 7, 2022
Improve the Descriptor HowTo Guide #98038
Closed
@geryogam

geryogam commented Oct 7, 2022

Copy link
Copy Markdown
Contributor Author

Please open a ticket to track this properly.

Done: #98038
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@rhettinger rhettinger added skip issue skip news needs backport to 3.11 only security fixes labels Oct 7, 2022
rhettinger
rhettinger requested changes Oct 7, 2022
View reviewed changes
Comment thread Doc/howto/descriptor.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
@rhettinger rhettinger changed the title Improve the Descriptor HowTo Guide Minor edits to the Descriptor HowTo Guide Oct 7, 2022
@geryogam
Update descriptor.rst
bcc9da0
@rhettinger
rhettinger merged commit 2d2e01a into python:main Oct 9, 2022
@miss-islington

miss-islington commented Oct 9, 2022

Copy link
Copy Markdown
Contributor

Thanks @maggyero for the PR, and @rhettinger for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting changes label Oct 9, 2022
@bedevere-bot

bedevere-bot commented Oct 9, 2022

Copy link
Copy Markdown

GH-98112 is a backport of this pull request to the 3.11 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Oct 9, 2022
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 9, 2022
@geryogam @miss-islington
Minor edits to the Descriptor HowTo Guide (pythonGH-24901)
3699a37 
Co-authored-by: Raymond Hettinger <[email protected]>
(cherry picked from commit 2d2e01a)

Co-authored-by: Géry Ogam <[email protected]>
@rhettinger rhettinger added the needs backport to 3.10 label Oct 9, 2022
@miss-islington

miss-islington commented Oct 9, 2022

Copy link
Copy Markdown
Contributor

Thanks @maggyero for the PR, and @rhettinger for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot

bedevere-bot commented Oct 9, 2022

Copy link
Copy Markdown

GH-98114 is a backport of this pull request to the 3.10 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.10 label Oct 9, 2022
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 9, 2022
@geryogam @miss-islington
Minor edits to the Descriptor HowTo Guide (pythonGH-24901)
c05b145 
Co-authored-by: Raymond Hettinger <[email protected]>
(cherry picked from commit 2d2e01a)

Co-authored-by: Géry Ogam <[email protected]>
miss-islington added a commit that referenced this pull request Oct 9, 2022
@miss-islington @geryogam
Minor edits to the Descriptor HowTo Guide (GH-24901)
6554598 
Co-authored-by: Raymond Hettinger <[email protected]>
(cherry picked from commit 2d2e01a)

Co-authored-by: Géry Ogam <[email protected]>
rhettinger pushed a commit that referenced this pull request Oct 9, 2022
@miss-islington
[3.10] Minor edits to the Descriptor HowTo Guide (GH-24901) (GH-98114)
820ef62
carljm added a commit to carljm/cpython that referenced this pull request Oct 9, 2022
@carljm
Merge branch 'main' into typewatch
71d48c1 
* main:
  Minor edits to the Descriptor HowTo Guide (pythonGH-24901)
  Fix link to Lifecycle of a Pull Request in CONTRIBUTING (python#98102)
  pythonGH-94597: deprecate `SafeChildWatcher`, `FastChildWatcher` and `MultiLoopChildWatcher` child watchers  (python#98089)
  Auto-cancel old builds when new commit pushed to branch (python#98009)
  pythongh-95011: Migrate syslog module to Argument Clinic (pythonGH-95012)
carljm added a commit to carljm/cpython that referenced this pull request Oct 9, 2022
@carljm
Merge branch 'main' into urllibnonet
132c32e 
* main: (5519 commits)
  Minor edits to the Descriptor HowTo Guide (pythonGH-24901)
  Fix link to Lifecycle of a Pull Request in CONTRIBUTING (python#98102)
  pythonGH-94597: deprecate `SafeChildWatcher`, `FastChildWatcher` and `MultiLoopChildWatcher` child watchers  (python#98089)
  Auto-cancel old builds when new commit pushed to branch (python#98009)
  pythongh-95011: Migrate syslog module to Argument Clinic (pythonGH-95012)
  pythongh-68686: Retire eptag ptag scripts (python#98064)
  pythongh-97922: Run the GC only on eval breaker (python#97920)
  GitHub Workflows security hardening (python#96492)
  Add `@ezio-melotti` as codeowner for `.github/`. (python#98079)
  pythongh-97913 Docs: Add walrus operator to the index (python#97921)
  [doc] Fix broken links to C extensions accelerating stdlib modules (python#96914)
  pythongh-97822: Fix http.server documentation reference to test() function (python#98027)
  pythongh-91052: Add PyDict_Unwatch for unwatching a dictionary (python#98055)
  pythonGH-98023: Change default child watcher to PidfdChildWatcher on supported systems (python#98024)
  pythonGH-94182: Run the PidfdChildWatcher on the running loop (python#94184)
  pythongh-92886: make test_ast pass with -O (assertions off) (pythonGH-98058)
  pythongh-92886: make test_coroutines pass with -O (assertions off) (pythonGH-98060)
  pythongh-57179: Add note on symlinks for os.walk (python#94799)
  pythongh-94808: Fix regex on exotic platforms (python#98036)
  pythongh-90085: Remove vestigial -t and -c timeit options (python#94941)
  ...
@geryogam

geryogam commented Oct 9, 2022

Copy link
Copy Markdown
Contributor Author

Thanks for the review.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@geryogam
geryogam deleted the patch-14 branch October 10, 2022 21:53
mpage pushed a commit to mpage/cpython that referenced this pull request Oct 11, 2022
@geryogam @rhettinger @mpage
Minor edits to the Descriptor HowTo Guide (pythonGH-24901)
cef2db9 
Co-authored-by: Raymond Hettinger <[email protected]>
pablogsal pushed a commit that referenced this pull request Oct 22, 2022
@miss-islington @geryogam @pablogsal
Minor edits to the Descriptor HowTo Guide (GH-24901)
7460cf4 
Co-authored-by: Raymond Hettinger <[email protected]>
(cherry picked from commit 2d2e01a)

Co-authored-by: Géry Ogam <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@merwok merwok merwok left review comments
@rhettinger rhettinger rhettinger requested changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@rhettinger rhettinger

Labels

docs Documentation in the Doc dir skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

7 participants

@geryogam @merwok @bedevere-bot @miss-islington @rhettinger @the-knights-who-say-ni @ezio-melotti
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.