GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Auto-cancel old builds when new commit pushed to branch by hugovk · Pull Request #98009 · python/cpython

Conversation

@hugovk

@hugovk hugovk commented Oct 7, 2022

Copy link
Copy Markdown
Member

Let's use GitHub Actions' concurrency to cancel outdated runs.

So if you push more than once to a given branch, it auto-cancels runs for older commits to make way for the newest commit to run.

This will help when there's a large backlog of builds and we're hitting limits.

Docs:

  • https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#concurrency
  • https://docs.github.com/en/actions/learn-github-actions/contexts#github-context

Is an issue needed?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
noamcohen97 reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@hugovk
Auto-cancel old builds when new commit pushed to branch
bbefafc
@bedevere-bot bedevere-bot added the awaiting review label Oct 7, 2022
@hugovk hugovk added the skip news label Oct 7, 2022
@ambv ambv added the skip issue label Oct 7, 2022
ezio-melotti
ezio-melotti reviewed Oct 7, 2022
View reviewed changes
Comment thread .github/workflows/build.yml Resolved

Uh oh!

There was an error while loading. Please reload this page.
@hugovk @ezio-melotti
Add a fallback
ee74a85 
Co-authored-by: Ezio Melotti <[email protected]>
ambv
ambv reviewed Oct 7, 2022
View reviewed changes
Comment thread .github/workflows/build_msi.yml Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread .github/workflows/doc.yml Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread .github/workflows/verify-ensurepip-wheels.yml Resolved

Uh oh!

There was an error while loading. Please reload this page.
ezio-melotti
ezio-melotti reviewed Oct 8, 2022
View reviewed changes
Comment thread .github/workflows/build_msi.yml Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread .github/workflows/doc.yml Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread .github/workflows/verify-ensurepip-wheels.yml Resolved

Uh oh!

There was an error while loading. Please reload this page.
@ezio-melotti
Use the same group for all workflows.
19007ae
ezio-melotti
ezio-melotti approved these changes Oct 8, 2022
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Oct 8, 2022
@ezio-melotti ezio-melotti self-assigned this Oct 8, 2022
@ezio-melotti

ezio-melotti commented Oct 8, 2022

Copy link
Copy Markdown
Member

I'm going to merge this and see what happens. If everything works well I will backport it.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ezio-melotti
ezio-melotti merged commit 75751f4 into python:main Oct 8, 2022
@bedevere-bot bedevere-bot removed the awaiting merge label Oct 8, 2022
@ezio-melotti

ezio-melotti commented Oct 8, 2022

Copy link
Copy Markdown
Member

This seems to be working well:
image
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ezio-melotti ezio-melotti added needs backport to 3.10 needs backport to 3.11 only security fixes labels Oct 8, 2022
@miss-islington

miss-islington commented Oct 8, 2022

Copy link
Copy Markdown
Contributor

Thanks @hugovk for the PR, and @ezio-melotti for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington

miss-islington commented Oct 8, 2022

Copy link
Copy Markdown
Contributor

Thanks @hugovk for the PR, and @ezio-melotti for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington

miss-islington commented Oct 8, 2022

Copy link
Copy Markdown
Contributor

Sorry, @hugovk and @ezio-melotti, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 75751f4aa5d70f65856645a9128fd42d92d6692c 3.11
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington

miss-islington commented Oct 8, 2022

Copy link
Copy Markdown
Contributor

Sorry @hugovk and @ezio-melotti, I had trouble checking out the 3.10 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 75751f4aa5d70f65856645a9128fd42d92d6692c 3.10
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ezio-melotti

ezio-melotti commented Oct 9, 2022

Copy link
Copy Markdown
Member

(If we backport #92999 the conflict should go away and make the workflow files more consistent between branches, so I'm waiting for that before backporting this.)
hugovk reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@hugovk
hugovk deleted the cancel-old-builds branch October 9, 2022 06:24
carljm added a commit to carljm/cpython that referenced this pull request Oct 9, 2022
@carljm
Merge branch 'main' into typewatch
71d48c1 
* main:
  Minor edits to the Descriptor HowTo Guide (pythonGH-24901)
  Fix link to Lifecycle of a Pull Request in CONTRIBUTING (python#98102)
  pythonGH-94597: deprecate `SafeChildWatcher`, `FastChildWatcher` and `MultiLoopChildWatcher` child watchers  (python#98089)
  Auto-cancel old builds when new commit pushed to branch (python#98009)
  pythongh-95011: Migrate syslog module to Argument Clinic (pythonGH-95012)
carljm added a commit to carljm/cpython that referenced this pull request Oct 9, 2022
@carljm
Merge branch 'main' into urllibnonet
132c32e 
* main: (5519 commits)
  Minor edits to the Descriptor HowTo Guide (pythonGH-24901)
  Fix link to Lifecycle of a Pull Request in CONTRIBUTING (python#98102)
  pythonGH-94597: deprecate `SafeChildWatcher`, `FastChildWatcher` and `MultiLoopChildWatcher` child watchers  (python#98089)
  Auto-cancel old builds when new commit pushed to branch (python#98009)
  pythongh-95011: Migrate syslog module to Argument Clinic (pythonGH-95012)
  pythongh-68686: Retire eptag ptag scripts (python#98064)
  pythongh-97922: Run the GC only on eval breaker (python#97920)
  GitHub Workflows security hardening (python#96492)
  Add `@ezio-melotti` as codeowner for `.github/`. (python#98079)
  pythongh-97913 Docs: Add walrus operator to the index (python#97921)
  [doc] Fix broken links to C extensions accelerating stdlib modules (python#96914)
  pythongh-97822: Fix http.server documentation reference to test() function (python#98027)
  pythongh-91052: Add PyDict_Unwatch for unwatching a dictionary (python#98055)
  pythonGH-98023: Change default child watcher to PidfdChildWatcher on supported systems (python#98024)
  pythonGH-94182: Run the PidfdChildWatcher on the running loop (python#94184)
  pythongh-92886: make test_ast pass with -O (assertions off) (pythonGH-98058)
  pythongh-92886: make test_coroutines pass with -O (assertions off) (pythonGH-98060)
  pythongh-57179: Add note on symlinks for os.walk (python#94799)
  pythongh-94808: Fix regex on exotic platforms (python#98036)
  pythongh-90085: Remove vestigial -t and -c timeit options (python#94941)
  ...
@ezio-melotti ezio-melotti added needs backport to 3.10 and removed needs backport to 3.10 needs backport to 3.11 only security fixes labels Oct 10, 2022
@ezio-melotti ezio-melotti added the needs backport to 3.11 only security fixes label Oct 10, 2022
@miss-islington

miss-islington commented Oct 10, 2022

Copy link
Copy Markdown
Contributor

Thanks @hugovk for the PR, and @ezio-melotti for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington

miss-islington commented Oct 10, 2022

Copy link
Copy Markdown
Contributor

Thanks @hugovk for the PR, and @ezio-melotti for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington

miss-islington commented Oct 10, 2022

Copy link
Copy Markdown
Contributor

Sorry @hugovk and @ezio-melotti, I had trouble checking out the 3.10 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 75751f4aa5d70f65856645a9128fd42d92d6692c 3.10
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 10, 2022
@hugovk @miss-islington
Auto-cancel old builds when new commit pushed to branch (pythonGH-98009)
d25cac6 
* Auto-cancel old builds when new commit pushed to branch

* Add a fallback

Co-authored-by: Ezio Melotti <[email protected]>

* Use the same group for all workflows.

Co-authored-by: Ezio Melotti <[email protected]>
(cherry picked from commit 75751f4)

Co-authored-by: Hugo van Kemenade <[email protected]>
@bedevere-bot

bedevere-bot commented Oct 10, 2022

Copy link
Copy Markdown

GH-98162 is a backport of this pull request to the 3.11 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Oct 10, 2022
@bedevere-bot

bedevere-bot commented Oct 10, 2022

Copy link
Copy Markdown

GH-98163 is a backport of this pull request to the 3.10 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.10 label Oct 10, 2022
miss-islington added a commit that referenced this pull request Oct 10, 2022
@miss-islington @hugovk
Auto-cancel old builds when new commit pushed to branch (GH-98009)
9d44ca5 
* Auto-cancel old builds when new commit pushed to branch

* Add a fallback

Co-authored-by: Ezio Melotti <[email protected]>

* Use the same group for all workflows.

Co-authored-by: Ezio Melotti <[email protected]>
(cherry picked from commit 75751f4)

Co-authored-by: Hugo van Kemenade <[email protected]>
ezio-melotti added a commit that referenced this pull request Oct 10, 2022
@ezio-melotti @hugovk
[3.10] Auto-cancel old builds when new commit pushed to branch (GH-98009
428bd02 
) (#98163)

* Auto-cancel old builds when new commit pushed to branch

* Add a fallback

Co-authored-by: Ezio Melotti <[email protected]>

* Use the same group for all workflows.

Co-authored-by: Ezio Melotti <[email protected]>
(cherry picked from commit 75751f4)

Co-authored-by: Hugo van Kemenade <[email protected]>

Co-authored-by: Hugo van Kemenade <[email protected]>
@ezio-melotti

ezio-melotti commented Oct 10, 2022

Copy link
Copy Markdown
Member

Backported 🥳
hugovk reacted with hooray emoji
All reactions
  • 🎉 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
mpage pushed a commit to mpage/cpython that referenced this pull request Oct 11, 2022
@hugovk @ezio-melotti @mpage
Auto-cancel old builds when new commit pushed to branch (python#98009)
5723b53 
* Auto-cancel old builds when new commit pushed to branch

* Add a fallback

Co-authored-by: Ezio Melotti <[email protected]>

* Use the same group for all workflows.

Co-authored-by: Ezio Melotti <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ambv ambv ambv left review comments
@sobolevn sobolevn sobolevn left review comments
@ezio-melotti ezio-melotti ezio-melotti approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@ezio-melotti ezio-melotti

Labels

skip issue skip news

Projects

Sprint
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@hugovk @ezio-melotti @miss-islington @bedevere-bot @ambv @sobolevn
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.