GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — gh-97913 Docs: Add walrus operator to the index by hugovk · Pull Request #97921 · python/cpython

Conversation

hugovk commented Oct 5, 2022 •

edited by bedevere-bot

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Member

The walrus operator for assignment expressions isn't in the indices:

Let's add it.

Preview

Issue: Mention "assignment expressions" and/or walrus in genindex-all #97913

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

bedevere-bot added awaiting review docs

Documentation in the Doc dir

skip news labels

Oct 5, 2022

hugovk added the skip issue label

Oct 5, 2022


          Add walrus operator to the index

7d092b4

hugovk force-pushed the add-walrus-index branch from abb74ce to 7d092b4 Compare

October 5, 2022 18:06

hugovk changed the title ~~Docs: Add walrus operator to the index~~ gh-97913 Docs: Add walrus operator to the index

Oct 5, 2022

hugovk removed the skip issue label

Oct 5, 2022

Mariatta added skip issue needs backport to 3.10 needs backport to 3.11 only security fixes labels

Oct 5, 2022

Mariatta approved these changes

Oct 5, 2022

View reviewed changes

bedevere-bot added awaiting merge and removed awaiting review labels

Oct 5, 2022

hugovk mentioned this pull request

Oct 5, 2022

Mention "assignment expressions" and/or walrus in genindex-all #97913

Closed

Mariatta reviewed

Oct 5, 2022

View reviewed changes

Comment thread

Doc/reference/expressions.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

simon04 mentioned this pull request

Oct 5, 2022

docs(expressions): add := and "walrus" to index #97932

Closed


          Add named expression to the index

3e20368

Co-authored-by: Mariatta Wijaya <[email protected]>

ezio-melotti reviewed

Oct 5, 2022

View reviewed changes

ezio-melotti left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this use operator: instead of single, at least on the first entry (and possibly on the others too)?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

Doc/reference/expressions.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.


          Fix indentation and add missing newline

5eb1267

Co-authored-by: Ezio Melotti <[email protected]>

hugovk commented Oct 6, 2022

Copy link

Copy Markdown

Member Author

Should this use operator: instead of single, at least on the first entry (and possibly on the others too)?

https://www.sphinx-doc.org/en/master/usage/restructuredtext/directives.html#index-generating-markup says of "module, keyword, operator, object, exception, statement, builtin":

These are Python-specific and therefore deprecated.

So maybe not?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

ezio-melotti commented Oct 6, 2022

Copy link

Copy Markdown

Member

We have several of those in our docs already, so there are a few options:

keep using them if it's a silent deprecation with no removal plans
reimplement them in pyspecific.py, if we want to keep use them (and if it's possible to reimplement them)
remove them and stick to the non-deprecated ones

I'll open a separate issue about this.

hugovk reacted with thumbs up emoji

All reactions

👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

ezio-melotti mentioned this pull request

Oct 6, 2022

Docs use deprecated Sphinx .. index:: entries #97950

Closed

ezio-melotti approved these changes

Oct 8, 2022

View reviewed changes

ezio-melotti merged commit 2963130 into python:main

Oct 8, 2022

miss-islington commented Oct 8, 2022

Copy link

Copy Markdown

Contributor

Thanks @hugovk for the PR, and @ezio-melotti for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-bot removed awaiting merge needs backport to 3.11 only security fixes labels

Oct 8, 2022

bedevere-bot commented Oct 8, 2022

Copy link

Copy Markdown

GH-98087 is a backport of this pull request to the 3.11 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-bot removed the needs backport to 3.10 label

Oct 8, 2022

bedevere-bot commented Oct 8, 2022

Copy link

Copy Markdown

GH-98088 is a backport of this pull request to the 3.10 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Oct 8, 2022


          pythongh-97913 Docs: Add walrus operator to the index (pythonGH-97921)

d24a9ed

* Add walrus operator to the index

* Add named expression to the index

Co-authored-by: Mariatta Wijaya <[email protected]>

* Fix indentation and add missing newline

Co-authored-by: Ezio Melotti <[email protected]>

Co-authored-by: Mariatta Wijaya <[email protected]>
Co-authored-by: Ezio Melotti <[email protected]>
(cherry picked from commit 2963130)

Co-authored-by: Hugo van Kemenade <[email protected]>

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Oct 8, 2022


          pythongh-97913 Docs: Add walrus operator to the index (pythonGH-97921)

b67da64

* Add walrus operator to the index

* Add named expression to the index

Co-authored-by: Mariatta Wijaya <[email protected]>

* Fix indentation and add missing newline

Co-authored-by: Ezio Melotti <[email protected]>

Co-authored-by: Mariatta Wijaya <[email protected]>
Co-authored-by: Ezio Melotti <[email protected]>
(cherry picked from commit 2963130)

Co-authored-by: Hugo van Kemenade <[email protected]>

miss-islington added a commit that referenced this pull request

Oct 8, 2022


          gh-97913 Docs: Add walrus operator to the index (GH-97921)

9828ccb

* Add walrus operator to the index

* Add named expression to the index

Co-authored-by: Mariatta Wijaya <[email protected]>

* Fix indentation and add missing newline

Co-authored-by: Ezio Melotti <[email protected]>

Co-authored-by: Mariatta Wijaya <[email protected]>
Co-authored-by: Ezio Melotti <[email protected]>
(cherry picked from commit 2963130)

Co-authored-by: Hugo van Kemenade <[email protected]>

miss-islington added a commit that referenced this pull request

Oct 8, 2022


          gh-97913 Docs: Add walrus operator to the index (GH-97921)

a2ce21f

* Add walrus operator to the index

* Add named expression to the index

Co-authored-by: Mariatta Wijaya <[email protected]>

* Fix indentation and add missing newline

Co-authored-by: Ezio Melotti <[email protected]>

Co-authored-by: Mariatta Wijaya <[email protected]>
Co-authored-by: Ezio Melotti <[email protected]>
(cherry picked from commit 2963130)

Co-authored-by: Hugo van Kemenade <[email protected]>

hugovk deleted the add-walrus-index branch

October 8, 2022 14:23

carljm added a commit to carljm/cpython that referenced this pull request

Oct 8, 2022


          Merge branch 'main' into typewatch

d67d6fd

* main:
  pythongh-68686: Retire eptag ptag scripts (python#98064)
  pythongh-97922: Run the GC only on eval breaker (python#97920)
  GitHub Workflows security hardening (python#96492)
  Add `@ezio-melotti` as codeowner for `.github/`. (python#98079)
  pythongh-97913 Docs: Add walrus operator to the index (python#97921)
  [doc] Fix broken links to C extensions accelerating stdlib modules (python#96914)
  pythongh-97822: Fix http.server documentation reference to test() function (python#98027)
  pythongh-91052: Add PyDict_Unwatch for unwatching a dictionary (python#98055)
  pythonGH-98023: Change default child watcher to PidfdChildWatcher on supported systems (python#98024)
  pythonGH-94182: Run the PidfdChildWatcher on the running loop (python#94184)

carljm added a commit to carljm/cpython that referenced this pull request

Oct 9, 2022


          Merge branch 'main' into urllibnonet

132c32e

* main: (5519 commits)
  Minor edits to the Descriptor HowTo Guide (pythonGH-24901)
  Fix link to Lifecycle of a Pull Request in CONTRIBUTING (python#98102)
  pythonGH-94597: deprecate `SafeChildWatcher`, `FastChildWatcher` and `MultiLoopChildWatcher` child watchers  (python#98089)
  Auto-cancel old builds when new commit pushed to branch (python#98009)
  pythongh-95011: Migrate syslog module to Argument Clinic (pythonGH-95012)
  pythongh-68686: Retire eptag ptag scripts (python#98064)
  pythongh-97922: Run the GC only on eval breaker (python#97920)
  GitHub Workflows security hardening (python#96492)
  Add `@ezio-melotti` as codeowner for `.github/`. (python#98079)
  pythongh-97913 Docs: Add walrus operator to the index (python#97921)
  [doc] Fix broken links to C extensions accelerating stdlib modules (python#96914)
  pythongh-97822: Fix http.server documentation reference to test() function (python#98027)
  pythongh-91052: Add PyDict_Unwatch for unwatching a dictionary (python#98055)
  pythonGH-98023: Change default child watcher to PidfdChildWatcher on supported systems (python#98024)
  pythonGH-94182: Run the PidfdChildWatcher on the running loop (python#94184)
  pythongh-92886: make test_ast pass with -O (assertions off) (pythonGH-98058)
  pythongh-92886: make test_coroutines pass with -O (assertions off) (pythonGH-98060)
  pythongh-57179: Add note on symlinks for os.walk (python#94799)
  pythongh-94808: Fix regex on exotic platforms (python#98036)
  pythongh-90085: Remove vestigial -t and -c timeit options (python#94941)
  ...

mpage pushed a commit to mpage/cpython that referenced this pull request

Oct 11, 2022


          pythongh-97913 Docs: Add walrus operator to the index (python#97921)

637bf6a

* Add walrus operator to the index

* Add named expression to the index

Co-authored-by: Mariatta Wijaya <[email protected]>

* Fix indentation and add missing newline

Co-authored-by: Ezio Melotti <[email protected]>

Co-authored-by: Mariatta Wijaya <[email protected]>
Co-authored-by: Ezio Melotti <[email protected]>

pablogsal pushed a commit that referenced this pull request

Oct 22, 2022


          gh-97913 Docs: Add walrus operator to the index (GH-97921)

9b6afbe

* Add walrus operator to the index

* Add named expression to the index

Co-authored-by: Mariatta Wijaya <[email protected]>

* Fix indentation and add missing newline

Co-authored-by: Ezio Melotti <[email protected]>

Co-authored-by: Mariatta Wijaya <[email protected]>
Co-authored-by: Ezio Melotti <[email protected]>
(cherry picked from commit 2963130)

Co-authored-by: Hugo van Kemenade <[email protected]>

Reviewers

Mariatta

Mariatta approved these changes

ezio-melotti

ezio-melotti approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

docs

Documentation in the Doc dir

skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

hugovk commented Oct 5, 2022 • edited by bedevere-bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Preview

Uh oh!

Uh oh!

ezio-melotti left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

hugovk commented Oct 6, 2022

Uh oh!

ezio-melotti commented Oct 6, 2022

Uh oh!

miss-islington commented Oct 8, 2022

Uh oh!

bedevere-bot commented Oct 8, 2022

Uh oh!

bedevere-bot commented Oct 8, 2022

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

hugovk commented Oct 5, 2022 •

edited by bedevere-bot

Loading

Uh oh!

There was an error while loading. Please reload this page.