GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | |||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | |||||
GeezerVison is showing github.com — bpo-45243: Add support for setting/getting `sqlite3` connection limits by erlend-aasland · Pull Request #28463 · python/cpython Conversation
|
|
Thinking about this, I wonder if connection limits are better implemented as attributes: import sqlite3 cx = sqlite3.connect(":memory:") lim = cx.SQLITE_LIMIT_LENGTH cx.SQLITE_LIMIT_LENGTH = 100 # instead of lim = cx.getlimit(sqlite3.SQLITE_LIMIT_LENGTH) cx.setlimit(sqlite3.SQLITE_LIMIT_LENGTH, 100) I added GH-28790 as an alternative implementation. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
- Use 'category' for limit category - Use 'limit' for the new limit
|
@serhiy-storchaka I changed the argument spec:
I believe this is clearer and more aligned with the SQLite documentation. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
PTAL, @serhiy-storchaka. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
@serhiy-storchaka I believe all comments have been resolved. Would you like to take another look at this PR? |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
@pablogsal would you mind taking a look at this? I believe I've addressed all of Serhiy's comments. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sorry, something went wrong.
There was an error while loading. Please reload this page.
- Blob from python/cpython#30680 (and anticipating that python/cpython#91550 will be merged) - Aggregate window functions from python/cpython#20903 - Serialize/deserialize from python/cpython#26728 - Limit setting from python/cpython#28463
- Blob from python/cpython#30680 (and anticipating that python/cpython#91550 will be merged) - Aggregate window functions from python/cpython#20903 - Serialize/deserialize from python/cpython#26728 - Limit setting from python/cpython#28463
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.