GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — sqlite3: add 3.11 additions by JelleZijlstra · Pull Request #7625 · python/typeshed

Conversation

JelleZijlstra commented Apr 15, 2022

Copy link

Copy Markdown

Member

Blob from gh-69093: Support basic incremental I/O to blobs in sqlite3 cpython#30680 (and anticipating that gh-69093: Expose sqlite3.Blob as a class cpython#91550 will be merged)
Aggregate window functions from gh-79097: Add support for aggregate window functions in sqlite3 cpython#20903
Serialize/deserialize from bpo-41930: Add support for SQLite serialise/deserialise API cpython#26728
Limit setting from bpo-45243: Add support for setting/getting sqlite3 connection limits cpython#28463

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          sqlite3: add 3.11 additions

0ba23bb

- Blob from python/cpython#30680 (and anticipating that python/cpython#91550 will be merged)
- Aggregate window functions from python/cpython#20903
- Serialize/deserialize from python/cpython#26728
- Limit setting from python/cpython#28463

This comment has been minimized.

srittau requested changes

Apr 15, 2022

View reviewed changes

srittau left a comment

Copy link

Copy Markdown

Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exciting changes to sqlite!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

stdlib/sqlite3/dbapi2.pyi Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

stdlib/sqlite3/dbapi2.pyi Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

stdlib/sqlite3/dbapi2.pyi Resolved

Uh oh!

There was an error while loading. Please reload this page.

JelleZijlstra added 3 commits

April 15, 2022 21:28


          blob.__enter__ from python/cpython#91562

6024e3f


          Sebastian's feedback

b0c6e85


          derp

fe01c60

This comment has been minimized.

AlexWaygood requested changes

Apr 16, 2022

View reviewed changes

AlexWaygood left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few typos :)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

stdlib/sqlite3/dbapi2.pyi Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

stdlib/sqlite3/dbapi2.pyi Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

stdlib/sqlite3/dbapi2.pyi Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

stdlib/sqlite3/dbapi2.pyi Resolved

Uh oh!

There was an error while loading. Please reload this page.

AlexWaygood reviewed

Apr 16, 2022

View reviewed changes

Comment thread

stdlib/sqlite3/dbapi2.pyi

		def seek(self, __offset: int, __whence: int = ...) -> None: ...
		def __len__(self) -> int: ...
		def __enter__(self: Self) -> Self: ...
		def __exit__(self, __typ: object, __val: object, __tb: object) -> Literal[False]: ...

AlexWaygood Apr 16, 2022

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is going to anger my unreleased Y036 check over at flake8-pyi :/ PyCQA/flake8-pyi@b7f7e9a

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

JelleZijlstra Apr 16, 2022

Copy link

Copy Markdown

Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hm, do you think we should change it? This __exit__ method really does take object; that's what the AC annotations say.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

AlexWaygood Apr 16, 2022 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'Kay, I'll work up a patch for flake8-pyi. It should be fine to merge this before flake8-pyi is fixed.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

srittau approved these changes

Apr 16, 2022

View reviewed changes

srittau left a comment

Copy link

Copy Markdown

Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, apart from the things @AlexWaygood pointed out.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          I can spell

eed1824

AlexWaygood approved these changes

Apr 16, 2022

View reviewed changes

AlexWaygood left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typos have been corrected to my satisfaction :)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

github-actions Bot commented Apr 16, 2022

Copy link

Copy Markdown

Contributor

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

srittau merged commit d802e65 into python:master

Apr 16, 2022

JelleZijlstra deleted the sqlite branch

April 16, 2022 14:09

AlexWaygood mentioned this pull request

Apr 16, 2022

Relax Y036 check a little bit PyCQA/flake8-pyi#209

Merged

AlexWaygood mentioned this pull request

Jan 17, 2023

Update Unused and __exit__ parameters in stdlib #9519

Merged

AlexWaygood mentioned this pull request

Feb 25, 2023

Update __exit__ parameters in stubs #9696

Merged

srittau mentioned this pull request

Jun 24, 2024

Fix SQLite Aggregation Protocols #12192

Closed

Reviewers

srittau

srittau approved these changes

AlexWaygood

AlexWaygood approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

JelleZijlstra commented Apr 15, 2022

Uh oh!

This comment has been minimized.

srittau left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

This comment has been minimized.

This comment has been minimized.

AlexWaygood left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

AlexWaygood Apr 16, 2022

Choose a reason for hiding this comment

Uh oh!

JelleZijlstra Apr 16, 2022

Choose a reason for hiding this comment

Uh oh!

AlexWaygood Apr 16, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

srittau left a comment

Choose a reason for hiding this comment

Uh oh!

AlexWaygood left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Apr 16, 2022

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

AlexWaygood Apr 16, 2022 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.