GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-69093: Expose sqlite3.Blob as a class by JelleZijlstra · Pull Request #91550 · python/cpython

Conversation

@JelleZijlstra

@JelleZijlstra JelleZijlstra commented Apr 15, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

I noticed this was missing while writing typeshed stubs. It's
useful to expose it for use in annotations.

GH-69093

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@JelleZijlstra
pythongh-69093: Expose sqlite3.Blob as a class
15709f9 
I noticed this was missing while writing typeshed stubs. It's
useful to expose it for use in annotations.
@JelleZijlstra
JelleZijlstra requested a review from berkerpeksag as a code owner April 15, 2022 00:37
@bedevere-bot bedevere-bot added the awaiting core review label Apr 15, 2022
@JelleZijlstra
JelleZijlstra requested a review from erlend-aasland April 15, 2022 00:37
@JelleZijlstra JelleZijlstra added the skip news label Apr 15, 2022
@JelleZijlstra

JelleZijlstra commented Apr 15, 2022

Copy link
Copy Markdown
Member Author

Skipping news because this is a simple followup for #30680, which was merged just now.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@JelleZijlstra JelleZijlstra mentioned this pull request Apr 15, 2022
sqlite3: add 3.11 additions python/typeshed#7625
Merged
JelleZijlstra added a commit to JelleZijlstra/typeshed that referenced this pull request Apr 15, 2022
@JelleZijlstra
sqlite3: add 3.11 additions
0ba23bb 
- Blob from python/cpython#30680 (and anticipating that python/cpython#91550 will be merged)
- Aggregate window functions from python/cpython#20903
- Serialize/deserialize from python/cpython#26728
- Limit setting from python/cpython#28463
@erlend-aasland

erlend-aasland commented Apr 15, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

I don't use typing, but I guess this is ok.

BTW, we need to disallow instantiation for blob types. I should've thought about that in the first place, but with this change it's even more important. We can embed that change here, or do it in another PR; I'm fine with both.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
erlend-aasland
erlend-aasland approved these changes Apr 15, 2022
View reviewed changes
srittau
srittau approved these changes Apr 15, 2022
View reviewed changes
@JelleZijlstra
JelleZijlstra merged commit b7f83bd into python:main Apr 15, 2022
@bedevere-bot bedevere-bot removed the awaiting core review label Apr 15, 2022
@JelleZijlstra
JelleZijlstra deleted the exposeblob branch April 15, 2022 13:30
@JelleZijlstra

JelleZijlstra commented Apr 15, 2022

Copy link
Copy Markdown
Member Author

Thanks! Also I don't think it's useful only for annotations: we also mention this class in the docs as if it is accessible, and it's useful for interactive exploration if you can do dir(sqlite3.Blob).
erlend-aasland reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@erlend-aasland

erlend-aasland commented Apr 15, 2022

Copy link
Copy Markdown
Contributor

Thanks! Also I don't think it's useful only for annotations: we also mention this class in the docs as if it is accessible, and it's useful for interactive exploration if you can do dir(sqlite3.Blob).

Good point!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
srittau pushed a commit to python/typeshed that referenced this pull request Apr 16, 2022
@JelleZijlstra
sqlite3: add 3.11 additions (#7625)
d802e65 
- Blob from python/cpython#30680 (and anticipating that python/cpython#91550 will be merged)
- Aggregate window functions from python/cpython#20903
- Serialize/deserialize from python/cpython#26728
- Limit setting from python/cpython#28463
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erlend-aasland erlend-aasland erlend-aasland approved these changes
@berkerpeksag berkerpeksag Awaiting requested review from berkerpeksag
+1 more reviewer
@srittau srittau srittau approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@JelleZijlstra @erlend-aasland @srittau @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.