GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — Dataclasses: Fix example on 30.6.8, add method should receive a list rather than an integer. by TomFaulkner · Pull Request #8038 · python/cpython

Conversation

TomFaulkner commented Jul 1, 2018

Copy link

Copy Markdown

Contributor

Fix example on 30.6.8, add method should receive a list rather than an integer.

Current example gives a TypeError.

Traceback (most recent call last):
  File "<input>", line 1, in <module>
    l += 1
TypeError: 'int' object is not iterable

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          Update dataclasses.rst

6a16862

Fix example on 30.6.8, add method should receive a list rather than an integer.

Current example gives a TypeError.
```
Traceback (most recent call last):
  File "<input>", line 1, in <module>
    l += 1
TypeError: 'int' object is not iterable
```

TomFaulkner requested a review from ericvsmith as a code owner

July 1, 2018 03:40

the-knights-who-say-ni commented Jul 1, 2018

Copy link

Copy Markdown

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

When your account is ready, please add a comment in this pull request
and a Python core developer will remove the CLA not signed label
to make the bot check again.

Thanks again for your contribution, we look forward to reviewing it!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

the-knights-who-say-ni added the CLA not signed label

Jul 1, 2018

bedevere-bot added the awaiting review label

Jul 1, 2018

TomFaulkner commented Jul 3, 2018

Copy link

Copy Markdown

Contributor Author

Legal paperwork is signed.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

ericvsmith reviewed

Jul 3, 2018

View reviewed changes

Comment thread

Doc/library/dataclasses.rst

		o1 = C()
		o2 = C()
		o1.add(1)
		o2.add(2)

ericvsmith Jul 3, 2018

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd rather keep this interface, and instead make the change in the add() method. Especially so since the name of the parameter is element. add() would become self.x.append(element).

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

ericvsmith added skip issue skip news needs backport to 3.7 awaiting changes and removed awaiting review labels

Jul 3, 2018


          Update dataclasses.rst

78c036c

Change function to append rather than add lists.

the-knights-who-say-ni added CLA signed and removed CLA not signed labels

Jul 11, 2018

TomFaulkner commented Jul 11, 2018

Copy link

Copy Markdown

Contributor Author

@ericvsmith Sorry about the delay, I made the requested change.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

ericvsmith merged commit da5e947 into python:master

Jul 11, 2018

bedevere-bot removed the awaiting changes label

Jul 11, 2018

miss-islington commented Jul 11, 2018

Copy link

Copy Markdown

Contributor

Thanks @TomFaulkner for the PR, and @ericvsmith for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

ericvsmith commented Jul 11, 2018

Copy link

Copy Markdown

Member

Thanks!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-bot removed the needs backport to 3.7 label

Jul 11, 2018

bedevere-bot commented Jul 11, 2018

Copy link

Copy Markdown

GH-8237 is a backport of this pull request to the 3.7 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Jul 11, 2018


          Dataclasses: Fix example on 30.6.8, add method should receive a list …

7692f50

…rather than an integer. (pythonGH-8038)

Change example function to append rather than add lists.
(cherry picked from commit da5e947)

Co-authored-by: Tom Faulkner <[email protected]>

ericvsmith pushed a commit that referenced this pull request

Jul 11, 2018


          Dataclasses: Fix example on 30.6.8, add method should receive a list …

bcea15a

…rather than an integer. (GH-8038) (GH-8237)

Change example function to append rather than add lists.
(cherry picked from commit da5e947)

Co-authored-by: Tom Faulkner <[email protected]>

TomFaulkner deleted the patch-1 branch

July 11, 2018 15:49

CuriousLearner added a commit to CuriousLearner/cpython that referenced this pull request

Jul 14, 2018


          Merge branch 'master' into bitwise_docs

11c1706

* master: (2633 commits)
  bpo-34087: Fix buffer overflow in int(s) and similar functions (pythonGH-8274)
  bpo-34108: Fix double carriage return in 2to3 on Windows (python#8271)
  bpo-4260: Document that ctypes.xFUNCTYPE are decorators (pythonGH-7924)
  bpo-33723: Fix test_time.test_thread_time() (pythonGH-8267)
  bpo-33967: Remove use of deprecated assertRaisesRegexp() (pythonGH-8261)
  bpo-34080: Fix a memory leak in the compiler. (pythonGH-8222)
  Enable GUI testing on Travis Linux builds via Xvfb (pythonGH-7887)
  bpo-23927: Make getargs.c skipitem() skipping 'w*'. (pythonGH-8192)
  bpo-33648: Remove PY_WARN_ON_C_LOCALE (pythonGH-7114)
  bpo-34092, test_logging: increase SMTPHandlerTest timeout (pythonGH-8245)
  Simplify __all__ in multiprocessing (pythonGH-6856)
  bpo-34083: Update dict order in Functional HOWTO (pythonGH-8230)
  Doc: Point to Simple statements section instead of PEP (pythonGH-8238)
  bpo-29442: Replace optparse with argparse in setup.py (pythonGH-139)
  bpo-33597: Add What's New for PyGC_Head (pythonGH-8236)
  Dataclasses: Fix example on 30.6.8, add method should receive a list rather than an integer. (pythonGH-8038)
  Fix documentation for input and output tutorial (pythonGH-8231)
  bpo-34009: Expand on platform support changes (pythonGH-8022)
  Factor-out two substantially identical code blocks. (pythonGH-8219)
  bpo-34031: fix incorrect usage of self.fail in two tests (pythonGH-8091)
  ...

CuriousLearner added a commit to CuriousLearner/cpython that referenced this pull request

Jul 15, 2018


          Merge branch 'master' into fix-issue8525

fdc3a3d

* master: (1159 commits)
  bpo-34087: Fix buffer overflow in int(s) and similar functions (pythonGH-8274)
  bpo-34108: Fix double carriage return in 2to3 on Windows (python#8271)
  bpo-4260: Document that ctypes.xFUNCTYPE are decorators (pythonGH-7924)
  bpo-33723: Fix test_time.test_thread_time() (pythonGH-8267)
  bpo-33967: Remove use of deprecated assertRaisesRegexp() (pythonGH-8261)
  bpo-34080: Fix a memory leak in the compiler. (pythonGH-8222)
  Enable GUI testing on Travis Linux builds via Xvfb (pythonGH-7887)
  bpo-23927: Make getargs.c skipitem() skipping 'w*'. (pythonGH-8192)
  bpo-33648: Remove PY_WARN_ON_C_LOCALE (pythonGH-7114)
  bpo-34092, test_logging: increase SMTPHandlerTest timeout (pythonGH-8245)
  Simplify __all__ in multiprocessing (pythonGH-6856)
  bpo-34083: Update dict order in Functional HOWTO (pythonGH-8230)
  Doc: Point to Simple statements section instead of PEP (pythonGH-8238)
  bpo-29442: Replace optparse with argparse in setup.py (pythonGH-139)
  bpo-33597: Add What's New for PyGC_Head (pythonGH-8236)
  Dataclasses: Fix example on 30.6.8, add method should receive a list rather than an integer. (pythonGH-8038)
  Fix documentation for input and output tutorial (pythonGH-8231)
  bpo-34009: Expand on platform support changes (pythonGH-8022)
  Factor-out two substantially identical code blocks. (pythonGH-8219)
  bpo-34031: fix incorrect usage of self.fail in two tests (pythonGH-8091)
  ...

CuriousLearner added a commit to CuriousLearner/cpython that referenced this pull request

Jul 21, 2018


          Merge branch 'master' of github.com:CuriousLearner/cpython into fix-i…

7b039a0

…ssue-33014

* 'master' of github.com:CuriousLearner/cpython: (722 commits)
  bpo-34087: Fix buffer overflow in int(s) and similar functions (pythonGH-8274)
  bpo-34108: Fix double carriage return in 2to3 on Windows (python#8271)
  bpo-4260: Document that ctypes.xFUNCTYPE are decorators (pythonGH-7924)
  bpo-33723: Fix test_time.test_thread_time() (pythonGH-8267)
  bpo-33967: Remove use of deprecated assertRaisesRegexp() (pythonGH-8261)
  bpo-34080: Fix a memory leak in the compiler. (pythonGH-8222)
  Enable GUI testing on Travis Linux builds via Xvfb (pythonGH-7887)
  bpo-23927: Make getargs.c skipitem() skipping 'w*'. (pythonGH-8192)
  bpo-33648: Remove PY_WARN_ON_C_LOCALE (pythonGH-7114)
  bpo-34092, test_logging: increase SMTPHandlerTest timeout (pythonGH-8245)
  Simplify __all__ in multiprocessing (pythonGH-6856)
  bpo-34083: Update dict order in Functional HOWTO (pythonGH-8230)
  Doc: Point to Simple statements section instead of PEP (pythonGH-8238)
  bpo-29442: Replace optparse with argparse in setup.py (pythonGH-139)
  bpo-33597: Add What's New for PyGC_Head (pythonGH-8236)
  Dataclasses: Fix example on 30.6.8, add method should receive a list rather than an integer. (pythonGH-8038)
  Fix documentation for input and output tutorial (pythonGH-8231)
  bpo-34009: Expand on platform support changes (pythonGH-8022)
  Factor-out two substantially identical code blocks. (pythonGH-8219)
  bpo-34031: fix incorrect usage of self.fail in two tests (pythonGH-8091)
  ...

Reviewers

ericvsmith

ericvsmith left review comments

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.