GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — bpo-34108: Fix double carriage return in 2to3 on Windows by jaraco · Pull Request #8271 · python/cpython

Conversation

jaraco commented Jul 13, 2018 •

edited by bedevere-bot

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Member

Uh oh!

There was an error while loading. Please reload this page.

cgohlke reacted with thumbs up emoji

aaronang reacted with heart emoji

All reactions

👍 1 reaction
❤️ 1 reaction


          bpo-34108: Add test capturing failure.

62558ee

the-knights-who-say-ni added the CLA signed label

Jul 13, 2018

bedevere-bot added the awaiting merge label

Jul 13, 2018

jaraco added 2 commits

July 13, 2018 08:38


          bpo-34108: Honor newlines as present in the original file.

bdd249c


          bpo-34108: add blurb

39750ab

jaraco commented Jul 13, 2018

Copy link

Copy Markdown

Member Author

We can see in the VSTS run on Windows before the fix is applied:

2018-07-13T12:54:49.8119753Z ======================================================================
2018-07-13T12:54:49.8120135Z FAIL: test_crlf_unchanged (lib2to3.tests.test_refactor.TestRefactoringTool)
2018-07-13T12:54:49.8120356Z ----------------------------------------------------------------------
2018-07-13T12:54:49.8120535Z Traceback (most recent call last):
2018-07-13T12:54:49.8120751Z   File "D:\a\1\s\lib\lib2to3\tests\test_refactor.py", line 303, in test_crlf_unchanged
2018-07-13T12:54:49.8120964Z     self.assertNotIn(b"\r\r\n", new)
2018-07-13T12:54:49.8121205Z AssertionError: b'\r\r\n' unexpectedly found in b'print("hi")\r\r\n\r\r\nprint("Like bad Windows newlines?")\r\r\n'
2018-07-13T12:54:49.8121353Z 
2018-07-13T12:54:49.8121528Z ----------------------------------------------------------------------

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

jaraco added the needs backport to 3.7 label

Jul 13, 2018

jaraco merged commit cafaf04 into python:master

Jul 13, 2018

miss-islington commented Jul 13, 2018

Copy link

Copy Markdown

Contributor

Thanks @jaraco for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-bot commented Jul 13, 2018

Copy link

Copy Markdown

@jaraco: Please replace # with GH- in the commit message next time. Thanks!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-bot removed the awaiting merge label

Jul 13, 2018

jaraco deleted the issue-34108 branch

July 13, 2018 15:26

bedevere-bot removed the needs backport to 3.7 label

Jul 13, 2018

bedevere-bot commented Jul 13, 2018

Copy link

Copy Markdown

GH-8275 is a backport of this pull request to the 3.7 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Jul 13, 2018


          bpo-34108: Fix double carriage return in 2to3 on Windows (pythonGH-8271)

ef7e06d

* Add test capturing failure.
* Honor newlines as present in the original file.
(cherry picked from commit cafaf04)

Co-authored-by: Jason R. Coombs <[email protected]>

aaronang mentioned this pull request

Jul 13, 2018

Pip installation fails pydata/numexpr#305

Closed

jaraco added a commit that referenced this pull request

Jul 13, 2018


          bpo-34108: Fix double carriage return in 2to3 on Windows (GH-8271) (#…

cf21d00

…8275)

* Add test capturing failure.
* Honor newlines as present in the original file.
(cherry picked from commit cafaf04)

Co-authored-by: Jason R. Coombs <[email protected]>

CuriousLearner added a commit to CuriousLearner/cpython that referenced this pull request

Jul 14, 2018


          Merge branch 'master' into bitwise_docs

11c1706

* master: (2633 commits)
  bpo-34087: Fix buffer overflow in int(s) and similar functions (pythonGH-8274)
  bpo-34108: Fix double carriage return in 2to3 on Windows (python#8271)
  bpo-4260: Document that ctypes.xFUNCTYPE are decorators (pythonGH-7924)
  bpo-33723: Fix test_time.test_thread_time() (pythonGH-8267)
  bpo-33967: Remove use of deprecated assertRaisesRegexp() (pythonGH-8261)
  bpo-34080: Fix a memory leak in the compiler. (pythonGH-8222)
  Enable GUI testing on Travis Linux builds via Xvfb (pythonGH-7887)
  bpo-23927: Make getargs.c skipitem() skipping 'w*'. (pythonGH-8192)
  bpo-33648: Remove PY_WARN_ON_C_LOCALE (pythonGH-7114)
  bpo-34092, test_logging: increase SMTPHandlerTest timeout (pythonGH-8245)
  Simplify __all__ in multiprocessing (pythonGH-6856)
  bpo-34083: Update dict order in Functional HOWTO (pythonGH-8230)
  Doc: Point to Simple statements section instead of PEP (pythonGH-8238)
  bpo-29442: Replace optparse with argparse in setup.py (pythonGH-139)
  bpo-33597: Add What's New for PyGC_Head (pythonGH-8236)
  Dataclasses: Fix example on 30.6.8, add method should receive a list rather than an integer. (pythonGH-8038)
  Fix documentation for input and output tutorial (pythonGH-8231)
  bpo-34009: Expand on platform support changes (pythonGH-8022)
  Factor-out two substantially identical code blocks. (pythonGH-8219)
  bpo-34031: fix incorrect usage of self.fail in two tests (pythonGH-8091)
  ...

CuriousLearner added a commit to CuriousLearner/cpython that referenced this pull request

Jul 15, 2018


          Merge branch 'master' into fix-issue8525

fdc3a3d

* master: (1159 commits)
  bpo-34087: Fix buffer overflow in int(s) and similar functions (pythonGH-8274)
  bpo-34108: Fix double carriage return in 2to3 on Windows (python#8271)
  bpo-4260: Document that ctypes.xFUNCTYPE are decorators (pythonGH-7924)
  bpo-33723: Fix test_time.test_thread_time() (pythonGH-8267)
  bpo-33967: Remove use of deprecated assertRaisesRegexp() (pythonGH-8261)
  bpo-34080: Fix a memory leak in the compiler. (pythonGH-8222)
  Enable GUI testing on Travis Linux builds via Xvfb (pythonGH-7887)
  bpo-23927: Make getargs.c skipitem() skipping 'w*'. (pythonGH-8192)
  bpo-33648: Remove PY_WARN_ON_C_LOCALE (pythonGH-7114)
  bpo-34092, test_logging: increase SMTPHandlerTest timeout (pythonGH-8245)
  Simplify __all__ in multiprocessing (pythonGH-6856)
  bpo-34083: Update dict order in Functional HOWTO (pythonGH-8230)
  Doc: Point to Simple statements section instead of PEP (pythonGH-8238)
  bpo-29442: Replace optparse with argparse in setup.py (pythonGH-139)
  bpo-33597: Add What's New for PyGC_Head (pythonGH-8236)
  Dataclasses: Fix example on 30.6.8, add method should receive a list rather than an integer. (pythonGH-8038)
  Fix documentation for input and output tutorial (pythonGH-8231)
  bpo-34009: Expand on platform support changes (pythonGH-8022)
  Factor-out two substantially identical code blocks. (pythonGH-8219)
  bpo-34031: fix incorrect usage of self.fail in two tests (pythonGH-8091)
  ...

cgohlke mentioned this pull request

Jul 21, 2018

Python 3.7: exit code -1073741819 (0xC0000005) when reading Date from Excel mhammond/pywin32#1221

Closed

CuriousLearner added a commit to CuriousLearner/cpython that referenced this pull request

Jul 21, 2018


          Merge branch 'master' of github.com:CuriousLearner/cpython into fix-i…

7b039a0

…ssue-33014

* 'master' of github.com:CuriousLearner/cpython: (722 commits)
  bpo-34087: Fix buffer overflow in int(s) and similar functions (pythonGH-8274)
  bpo-34108: Fix double carriage return in 2to3 on Windows (python#8271)
  bpo-4260: Document that ctypes.xFUNCTYPE are decorators (pythonGH-7924)
  bpo-33723: Fix test_time.test_thread_time() (pythonGH-8267)
  bpo-33967: Remove use of deprecated assertRaisesRegexp() (pythonGH-8261)
  bpo-34080: Fix a memory leak in the compiler. (pythonGH-8222)
  Enable GUI testing on Travis Linux builds via Xvfb (pythonGH-7887)
  bpo-23927: Make getargs.c skipitem() skipping 'w*'. (pythonGH-8192)
  bpo-33648: Remove PY_WARN_ON_C_LOCALE (pythonGH-7114)
  bpo-34092, test_logging: increase SMTPHandlerTest timeout (pythonGH-8245)
  Simplify __all__ in multiprocessing (pythonGH-6856)
  bpo-34083: Update dict order in Functional HOWTO (pythonGH-8230)
  Doc: Point to Simple statements section instead of PEP (pythonGH-8238)
  bpo-29442: Replace optparse with argparse in setup.py (pythonGH-139)
  bpo-33597: Add What's New for PyGC_Head (pythonGH-8236)
  Dataclasses: Fix example on 30.6.8, add method should receive a list rather than an integer. (pythonGH-8038)
  Fix documentation for input and output tutorial (pythonGH-8231)
  bpo-34009: Expand on platform support changes (pythonGH-8022)
  Factor-out two substantially identical code blocks. (pythonGH-8219)
  bpo-34031: fix incorrect usage of self.fail in two tests (pythonGH-8091)
  ...

grelston mentioned this pull request

Jun 11, 2019

SyntaxError on import of mayavi.api (double CR in apptools/persistence/state_pickler.py) ContinuumIO/anaconda-issues#10984

Open

PalmsDragon commented Dec 20, 2019

Copy link

Copy Markdown

help !
Python 3.7 in Windows

I cannot get: hdfile = pd.HDFStore('hfile25.h5')
to work. Im' receiving the following error:

File "CSV_to_H5.py", line 17, in
hdfile = pd.HDFStore('hfile25.h5')
File "C:\Users\cdgon\AppData\Local\Programs\Python\Python38-32\lib\site-packages\pandas\io\pytables.py", line 484, in init
tables = import_optional_dependency("tables")
File "C:\Users\cdgon\AppData\Local\Programs\Python\Python38-32\lib\site-packages\pandas\compat_optional.py", line 93, in import_optional_dependency
raise ImportError(message.format(name=name, extra=extra)) from None
ImportError: Missing optional dependency 'tables'. Use pip or conda to install tables.

Help !

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

jaraco commented Jul 13, 2018 • edited by bedevere-bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jaraco commented Jul 13, 2018

Uh oh!

miss-islington commented Jul 13, 2018

Uh oh!

bedevere-bot commented Jul 13, 2018

Uh oh!

bedevere-bot commented Jul 13, 2018

Uh oh!

PalmsDragon commented Dec 20, 2019

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

jaraco commented Jul 13, 2018 •

edited by bedevere-bot

Loading

Uh oh!

There was an error while loading. Please reload this page.