GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-97850: Remove deprecated functions from `importlib.utils` by sobolevn · Pull Request #97898 · python/cpython

Conversation

@sobolevn

@sobolevn sobolevn commented Oct 5, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

I've cleaned up all deprecated functions from importlib.utils:

  • Source
  • Docs
  • Tests

All are gone!

  • Issue: Meta issue for cleaning up import system cruft #97850

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot added the awaiting review label Oct 5, 2022
This was referenced Oct 5, 2022
Meta issue for cleaning up import system cruft #97850
Open
gh-65961: Raise DeprecationWarning when __package__ differs from __spec__.parent #97879
Merged
sobolevn added 2 commits October 6, 2022 01:29
@sobolevn
pythongh-97850: Remove deprecated functions from importlib.utils
b3a8ee6
@sobolevn
Rebase and remove set_package from diff
d45eba2
@sobolevn
sobolevn force-pushed the issue-97850 branch from cb4e97c to d45eba2 Compare October 5, 2022 22:30
@sobolevn

sobolevn commented Oct 5, 2022

Copy link
Copy Markdown
Member Author

@brettcannon rebased! set_package is removed from the scope of this PR.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@brettcannon
brettcannon requested review from brettcannon and warsaw October 7, 2022 00:50
warsaw
warsaw approved these changes Oct 7, 2022
View reviewed changes

@warsaw warsaw left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks for this long overdue clean up @sobolevn !

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
sobolevn reacted with heart emoji
All reactions
  • ❤️ 1 reaction
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Oct 7, 2022
@warsaw
warsaw merged commit 27025e1 into python:main Oct 7, 2022
@bedevere-bot bedevere-bot removed the awaiting merge label Oct 7, 2022
carljm added a commit to carljm/cpython that referenced this pull request Oct 8, 2022
@carljm
Merge branch 'main' into typewatch
0de5aff 
* main:
  pythongh-86298: Ensure that __loader__ and __spec__.loader agree in warnings.warn_explicit() (pythonGH-97803)
  pythongh-82874: Convert remaining importlib format uses to f-str. (python#98005)
  Docs: Fix backtick errors found by sphinx-lint (python#97998)
  pythongh-97850: Remove deprecated functions from `importlib.utils` (python#97898)
  Remove extra spaces in custom openSSL documentation. (python#93568)
  pythonGH-90985: Revert  "Deprecate passing a message into cancel()" (python#97999)
mpage pushed a commit to mpage/cpython that referenced this pull request Oct 11, 2022
@sobolevn @mpage
pythongh-97850: Remove deprecated functions from importlib.utils (p…
04a52de 
…ython#97898)

* pythongh-97850: Remove deprecated functions from `importlib.utils`

* Rebase and remove `set_package` from diff
@AlexWaygood AlexWaygood mentioned this pull request Aug 31, 2023
gh-97850: Note in py312 whatsnew that importlib.util.set_loader and importlib.util.module_for_loader have been removed #108719
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@warsaw warsaw warsaw approved these changes
@brettcannon brettcannon Awaiting requested review from brettcannon brettcannon is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@sobolevn @warsaw @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.