GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — Docs: Fix backtick errors found by sphinx-lint by hugovk · Pull Request #97998 · python/cpython

Conversation

hugovk commented Oct 6, 2022

Copy link

Copy Markdown

Member

No description provided.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

hugovk added 2 commits

October 6, 2022 15:41


          Fix backtick errors found by sphinx-lint

2acf3e8


          Remove 15-year-old TODO that causes lint errors

a91cf65

hugovk requested review from a team, 1st1, abalkin, asvetlov, ethanfurman, gvanrossum, pganssle, rhettinger, tiran and vsajip as code owners

October 6, 2022 22:45

bedevere-bot added the awaiting review label

Oct 6, 2022

hugovk added skip issue skip news docs Documentation in the Doc dir labels

Oct 6, 2022

ezio-melotti reviewed

Oct 6, 2022

View reviewed changes

Comment thread

Doc/howto/logging.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Doc/library/concurrent.futures.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Doc/library/concurrent.futures.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Doc/library/dis.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Doc/library/hashlib.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

hugovk commented

Oct 6, 2022

View reviewed changes

hugovk left a comment •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use ... for True/False/None

Edit: oops, this was meant to be the review commit message! The buttons are next to each other... Will try again!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

hugovk and others added 2 commits

October 7, 2022 02:07


          Use ... for True/False/None

96f26d4

Co-authored-by: Ezio Melotti <[email protected]>


          Make formatting consistent

192432d

Co-authored-by: Ezio Melotti <[email protected]>

ambv merged commit fa2d43e into python:main

Oct 7, 2022

bedevere-bot removed the awaiting review label

Oct 7, 2022

hugovk deleted the fix-sphinx-lint branch

October 7, 2022 01:02

CAM-Gerlach commented Oct 7, 2022

Copy link

Copy Markdown

Member

I can manually backport the changes (minus the Sphinx-lint for 3.10) since they do fix genuine defects and will avoid future merge conflicts when backporting other PRs, and can follow up later with a PR bumping 3.11 and 3.12 to the latest version of Sphinx-Lint (0.6.5, at this writing, which fixes an additional false positive found in the CPython docs that this PR worked around).

ezio-melotti and hugovk reacted with thumbs up emoji

All reactions

👍 2 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

ezio-melotti commented Oct 7, 2022

Copy link

Copy Markdown

Member

SGTM. Coordinate on Discord/IRL so that we don't step on each other's toes, and feel free to @mention me on issues/PRs.

CAM-Gerlach reacted with thumbs up emoji

All reactions

👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

CAM-Gerlach commented Oct 7, 2022

Copy link

Copy Markdown

Member

Yup, talked to @hugovk about it—was sitting right next to him IRL yesterday and made sure we didn't duplicate each others' work on the various issues that came up 👍

ezio-melotti reacted with thumbs up emoji

All reactions

👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

carljm added a commit to carljm/cpython that referenced this pull request

Oct 8, 2022


          Merge branch 'main' into typewatch

0de5aff

* main:
  pythongh-86298: Ensure that __loader__ and __spec__.loader agree in warnings.warn_explicit() (pythonGH-97803)
  pythongh-82874: Convert remaining importlib format uses to f-str. (python#98005)
  Docs: Fix backtick errors found by sphinx-lint (python#97998)
  pythongh-97850: Remove deprecated functions from `importlib.utils` (python#97898)
  Remove extra spaces in custom openSSL documentation. (python#93568)
  pythonGH-90985: Revert  "Deprecate passing a message into cancel()" (python#97999)

mpage pushed a commit to mpage/cpython that referenced this pull request

Oct 11, 2022


          Docs: Fix backtick errors found by sphinx-lint (python#97998)

bd03a34

Co-authored-by: Ezio Melotti <[email protected]>

CAM-Gerlach mentioned this pull request

Oct 17, 2022

Add notes from 2022-10 python/docs-community#61

Merged

CAM-Gerlach pushed a commit to CAM-Gerlach/cpython that referenced this pull request

Oct 17, 2022


          [3.11] Docs: Fix backtick errors found by sphinx-lint (pythonGH-97998)

a6ea2cc

Co-authored-by: Ezio Melotti <[email protected]>.
(cherry picked from commit fa2d43e)

Co-authored-by: Hugo van Kemenade <[email protected]>

CAM-Gerlach mentioned this pull request

Oct 17, 2022

[3.11] Docs: Fix backtick errors found by sphinx-lint (GH-97998) #98371

Merged

bedevere-bot commented Oct 17, 2022

Copy link

Copy Markdown

GH-98371 is a backport of this pull request to the 3.11 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

CAM-Gerlach pushed a commit to CAM-Gerlach/cpython that referenced this pull request

Oct 17, 2022


          [3.10] Docs: Fix backtick errors found by sphinx-lint (pythonGH-97998)

b12e449

Co-authored-by: Ezio Melotti <[email protected]>.
(cherry picked from commit fa2d43e)

Co-authored-by: Hugo van Kemenade <[email protected]>

CAM-Gerlach mentioned this pull request

Oct 17, 2022

[3.10] Docs: Fix backtick errors found by sphinx-lint (GH-97998) #98373

Merged

bedevere-bot commented Oct 17, 2022

Copy link

Copy Markdown

GH-98373 is a backport of this pull request to the 3.10 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

CAM-Gerlach removed request for a team, 1st1, abalkin, asvetlov, ethanfurman, gvanrossum, pganssle, rhettinger, tiran and vsajip

October 17, 2022 23:40

ezio-melotti pushed a commit that referenced this pull request

Oct 17, 2022


          [3.11] Docs: Fix backtick errors found by sphinx-lint (GH-97998) (#98371

ea19c28

)

Co-authored-by: Ezio Melotti <[email protected]>.
(cherry picked from commit fa2d43e)

Co-authored-by: Hugo van Kemenade <[email protected]>

Co-authored-by: Hugo van Kemenade <[email protected]>

ezio-melotti pushed a commit that referenced this pull request

Oct 17, 2022


          [3.10] Docs: Fix backtick errors found by sphinx-lint (GH-97998) (#98373

b2db1c2

)

Co-authored-by: Ezio Melotti <[email protected]>.
(cherry picked from commit fa2d43e)

Co-authored-by: Hugo van Kemenade <[email protected]>

Co-authored-by: Hugo van Kemenade <[email protected]>

pablogsal pushed a commit that referenced this pull request

Oct 22, 2022


          [3.11] Docs: Fix backtick errors found by sphinx-lint (GH-97998) (#98371

f1ca2f6

)

Co-authored-by: Ezio Melotti <[email protected]>.
(cherry picked from commit fa2d43e)

Co-authored-by: Hugo van Kemenade <[email protected]>

Co-authored-by: Hugo van Kemenade <[email protected]>

Reviewers

ezio-melotti

ezio-melotti left review comments

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

docs

Documentation in the Doc dir

skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

hugovk commented Oct 6, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

hugovk left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

CAM-Gerlach commented Oct 7, 2022

Uh oh!

ezio-melotti commented Oct 7, 2022

Uh oh!

CAM-Gerlach commented Oct 7, 2022

Uh oh!

bedevere-bot commented Oct 17, 2022

Uh oh!

bedevere-bot commented Oct 17, 2022

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

hugovk left a comment •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.