GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Handle unknown error codes gracefully by rytilahti · Pull Request #1016 · python-kasa/python-kasa

Conversation

@rytilahti

@rytilahti rytilahti commented Jun 26, 2024

Copy link
Copy Markdown
Member

Makes unknown error codes to be reported through KasaException which may be recoverable in some cases (i.e., a single command failing in the multi request).

Related to home-assistant/core#118446

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@rytilahti
Handle unknown error codes gracefully
23c09b2
@rytilahti rytilahti added the bug Something isn't working label Jun 26, 2024
@rytilahti rytilahti mentioned this pull request Jun 26, 2024
Tp Link Tapo P105 broken after firmware update home-assistant/core#118446
Closed
@codecov

codecov Bot commented Jun 26, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.22%. Comparing base (0a85243) to head (00952a8).
Report is 79 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1016      +/-   ##
==========================================
+ Coverage   91.20%   91.22%   +0.01%     
==========================================
  Files          84       84              
  Lines        5627     5638      +11     
  Branches     1374     1374              
==========================================
+ Hits         5132     5143      +11     
  Misses        384      384              
  Partials      111      111

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
sdb9696
sdb9696 requested changes Jun 26, 2024
View reviewed changes

@sdb9696 sdb9696 left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but this should also be implemented in aestransport

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@rytilahti

rytilahti commented Jun 26, 2024

Copy link
Copy Markdown
Member Author

Looks good but this should also be implemented in aestransport

Ohh, I thought that this would be only above the transport layer, but I see that it also has some error handling. I'll look into that, thanks for the review!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@rytilahti
Add unknown error code handling for aestransport, rename error to ind…
00952a8 
…icate its internal use
@rytilahti

rytilahti commented Jun 26, 2024

Copy link
Copy Markdown
Member Author

Added for aestransport & renamed the error to indicate that it's our internal error.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
sdb9696
sdb9696 approved these changes Jun 26, 2024
View reviewed changes

@sdb9696 sdb9696 left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@rytilahti rytilahti added this to the 0.7.0.2 milestone Jun 26, 2024
@rytilahti
rytilahti merged commit cf24a94 into master Jun 27, 2024
@rytilahti
rytilahti deleted the fix/handle_unknown_error_codes branch June 27, 2024 14:58
@sdb9696 sdb9696 mentioned this pull request Jul 1, 2024
Prepare 0.7.0.2 #1028
Merged
sdb9696 added a commit that referenced this pull request Jul 1, 2024
@sdb9696
Prepare 0.7.0.2 (#1028)
38a8c96 
## [0.7.0.2](https://github.com/python-kasa/python-kasa/tree/0.7.0.2) (2024-07-01)

[Full Changelog](0.7.0.1...0.7.0.2)

This patch release fixes some minor issues found out during testing against all new homeassistant platforms.

**Fixed bugs:**

- Disable multi-request on unknown errors [\#1027](#1027) (@sdb9696)
- Disable multi requests on json decode error during multi-request [\#1025](#1025) (@sdb9696)
- Fix changing brightness when effect is active [\#1019](#1019) (@rytilahti)
- Update light transition module to work with child devices [\#1017](#1017) (@sdb9696)
- Handle unknown error codes gracefully [\#1016](#1016) (@rytilahti)

**Project maintenance:**

- Make parent attribute on device consistent across iot and smart [\#1023](#1023) (@sdb9696)
- Cache SmartErrorCode creation [\#1022](#1022) (@bdraco)
pillarsdotnet pushed a commit to pillarsdotnet/python-kasa that referenced this pull request Oct 22, 2026
@rytilahti
Handle unknown error codes gracefully (python-kasa#1016)
dbe9fb5 
Makes unknown error codes to be reported through KasaException which may
be recoverable in some cases (i.e., a single command failing in the
multi request).

Related to home-assistant/core#118446
pillarsdotnet pushed a commit to pillarsdotnet/python-kasa that referenced this pull request Oct 22, 2026
@sdb9696
Prepare 0.7.0.2 (python-kasa#1028)
c89adc3 
## [0.7.0.2](https://github.com/python-kasa/python-kasa/tree/0.7.0.2) (2024-07-01)

[Full Changelog](python-kasa/python-kasa@0.7.0.1...0.7.0.2)

This patch release fixes some minor issues found out during testing against all new homeassistant platforms.

**Fixed bugs:**

- Disable multi-request on unknown errors [\python-kasa#1027](python-kasa#1027) (@sdb9696)
- Disable multi requests on json decode error during multi-request [\python-kasa#1025](python-kasa#1025) (@sdb9696)
- Fix changing brightness when effect is active [\python-kasa#1019](python-kasa#1019) (@rytilahti)
- Update light transition module to work with child devices [\python-kasa#1017](python-kasa#1017) (@sdb9696)
- Handle unknown error codes gracefully [\python-kasa#1016](python-kasa#1016) (@rytilahti)

**Project maintenance:**

- Make parent attribute on device consistent across iot and smart [\python-kasa#1023](python-kasa#1023) (@sdb9696)
- Cache SmartErrorCode creation [\python-kasa#1022](python-kasa#1022) (@bdraco)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sdb9696 sdb9696 sdb9696 approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

bug Something isn't working

Projects

None yet

Milestone

0.7.0.2

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@rytilahti @sdb9696
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.