GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Update light transition module to work with child devices by sdb9696 · Pull Request #1017 · python-kasa/python-kasa

Conversation

@sdb9696

@sdb9696 sdb9696 commented Jun 26, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

The PR contains a few fixes and improvements for the LightTransition module:

  • Fixes it to work with child devices, i.e. ks240
  • Exposes a features to test for supported and allow getting the maximum values from the module interface
  • Interrogates the data to see whether maximums are available. Now possible with _post_update_hook
  • Fixes a bug whereby setting a duration while the feature is not enabled does not actually enable it.

N.B. the ks240 has component version 2 but does support the maximum values

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
sdb9696 added 3 commits June 26, 2024 13:56
@sdb9696
Update light transition module to work with child devices
490a82b
@sdb9696
Do not send 0 durations
eb99f00
@sdb9696
Fix TypeAlias import for lower python versions
da24ca3
@codecov

codecov Bot commented Jun 26, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 97.95918% with 1 line in your changes missing coverage. Please review.

Project coverage is 91.33%. Comparing base (cf24a94) to head (7638045).
Report is 78 commits behind head on master.

Files with missing lines Patch % Lines
kasa/smart/modules/lighttransition.py 97.87% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1017      +/-   ##
==========================================
+ Coverage   91.22%   91.33%   +0.11%     
==========================================
  Files          84       84              
  Lines        5638     5657      +19     
  Branches     1374     1371       -3     
==========================================
+ Hits         5143     5167      +24     
+ Misses        384      382       -2     
+ Partials      111      108       -3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
rytilahti
rytilahti requested changes Jun 26, 2024
View reviewed changes
Comment thread kasa/feature.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread kasa/tests/device_fixtures.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread kasa/tests/discovery_fixtures.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread kasa/tests/fakeprotocol_smart.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread kasa/tests/fixtureinfo.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread kasa/tests/test_device_factory.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread kasa/smart/modules/lighttransition.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@rytilahti rytilahti added this to the 0.7.0.2 milestone Jun 26, 2024
rytilahti
rytilahti reviewed Jun 26, 2024
View reviewed changes
Comment thread kasa/smart/modules/lighttransition.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@sdb9696
Do not use a default when setting enabled for v2
324942b
@sdb9696
sdb9696 requested a review from rytilahti June 27, 2024 13:35
rytilahti
rytilahti reviewed Jun 27, 2024
View reviewed changes
Comment thread kasa/tests/smart/modules/test_lighttransition.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
rytilahti
rytilahti reviewed Jun 27, 2024
View reviewed changes
Comment thread kasa/smart/smartchilddevice.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@sdb9696
Update post review
f12b72e
@sdb9696
sdb9696 requested a review from rytilahti June 27, 2024 16:45
@sdb9696
Merge branch 'master' into fix/child_transition
7638045
rytilahti
rytilahti approved these changes Jun 27, 2024
View reviewed changes

@rytilahti rytilahti left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested to work with v1 L920 and V3 L530!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@sdb9696 sdb9696 added the bug Something isn't working label Jun 27, 2024
@sdb9696
sdb9696 merged commit 2a62849 into master Jun 27, 2024
@sdb9696
sdb9696 deleted the fix/child_transition branch June 27, 2024 17:52
@sdb9696 sdb9696 mentioned this pull request Jul 1, 2024
Prepare 0.7.0.2 #1028
Merged
sdb9696 added a commit that referenced this pull request Jul 1, 2024
@sdb9696
Prepare 0.7.0.2 (#1028)
38a8c96 
## [0.7.0.2](https://github.com/python-kasa/python-kasa/tree/0.7.0.2) (2024-07-01)

[Full Changelog](0.7.0.1...0.7.0.2)

This patch release fixes some minor issues found out during testing against all new homeassistant platforms.

**Fixed bugs:**

- Disable multi-request on unknown errors [\#1027](#1027) (@sdb9696)
- Disable multi requests on json decode error during multi-request [\#1025](#1025) (@sdb9696)
- Fix changing brightness when effect is active [\#1019](#1019) (@rytilahti)
- Update light transition module to work with child devices [\#1017](#1017) (@sdb9696)
- Handle unknown error codes gracefully [\#1016](#1016) (@rytilahti)

**Project maintenance:**

- Make parent attribute on device consistent across iot and smart [\#1023](#1023) (@sdb9696)
- Cache SmartErrorCode creation [\#1022](#1022) (@bdraco)
pillarsdotnet pushed a commit to pillarsdotnet/python-kasa that referenced this pull request Oct 22, 2026
@sdb9696
Update light transition module to work with child devices (python-kas…
d6cca73 
…a#1017)

Fixes module to work with child devices, i.e. ks240
Interrogates the data to see whether maximums are available.
Fixes a bug whereby setting a duration while the feature is not
enabled does not actually enable it.
pillarsdotnet pushed a commit to pillarsdotnet/python-kasa that referenced this pull request Oct 22, 2026
@sdb9696
Prepare 0.7.0.2 (python-kasa#1028)
c89adc3 
## [0.7.0.2](https://github.com/python-kasa/python-kasa/tree/0.7.0.2) (2024-07-01)

[Full Changelog](python-kasa/python-kasa@0.7.0.1...0.7.0.2)

This patch release fixes some minor issues found out during testing against all new homeassistant platforms.

**Fixed bugs:**

- Disable multi-request on unknown errors [\python-kasa#1027](python-kasa#1027) (@sdb9696)
- Disable multi requests on json decode error during multi-request [\python-kasa#1025](python-kasa#1025) (@sdb9696)
- Fix changing brightness when effect is active [\python-kasa#1019](python-kasa#1019) (@rytilahti)
- Update light transition module to work with child devices [\python-kasa#1017](python-kasa#1017) (@sdb9696)
- Handle unknown error codes gracefully [\python-kasa#1016](python-kasa#1016) (@rytilahti)

**Project maintenance:**

- Make parent attribute on device consistent across iot and smart [\python-kasa#1023](python-kasa#1023) (@sdb9696)
- Cache SmartErrorCode creation [\python-kasa#1022](python-kasa#1022) (@bdraco)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rytilahti rytilahti rytilahti approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

bug Something isn't working

Projects

None yet

Milestone

0.7.0.2

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@sdb9696 @rytilahti
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.