GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Make parent attribute on device consistent across iot and smart by sdb9696 · Pull Request #1023 · python-kasa/python-kasa

Conversation

@sdb9696

@sdb9696 sdb9696 commented Jun 30, 2024

Copy link
Copy Markdown
Contributor

Currently parent on IotStripPlug, this PR makes it _parent which already exists on the base Device class.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@sdb9696
Make iot strip parent attribute consistent with smart
6f436cb
@codecov

codecov Bot commented Jun 30, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.38%. Comparing base (368590c) to head (6b7dea5).
Report is 88 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1023      +/-   ##
==========================================
+ Coverage   91.34%   91.38%   +0.03%     
==========================================
  Files          84       84              
  Lines        5662     5665       +3     
  Branches     1374     1374              
==========================================
+ Hits         5172     5177       +5     
+ Misses        382      381       -1     
+ Partials      108      107       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
rytilahti
rytilahti reviewed Jun 30, 2024
View reviewed changes

@rytilahti rytilahti left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I'm wondering if we should add a property getter for the parent?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@sdb9696

sdb9696 commented Jun 30, 2024

Copy link
Copy Markdown
Contributor Author

LGTM, but I'm wondering if we should add a property getter for the parent?

Yeah I did wonder. There’s no harm so will add one.
rytilahti reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
sdb9696 added 2 commits July 1, 2024 09:47
@sdb9696
Expose public parent property
acfdea4
@sdb9696
Fix coverage
6b7dea5
@sdb9696
sdb9696 force-pushed the janitor/consistent_parent branch from 93d89b3 to 6b7dea5 Compare July 1, 2024 09:22
rytilahti
rytilahti approved these changes Jul 1, 2024
View reviewed changes

@rytilahti rytilahti left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, shall we merge this for the patch release?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
sdb9696 reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@sdb9696
sdb9696 merged commit 2687c71 into master Jul 1, 2024
@sdb9696
sdb9696 deleted the janitor/consistent_parent branch July 1, 2024 10:51
@sdb9696 sdb9696 added the maintenance Project improvements and maintenance label Jul 1, 2024
@sdb9696 sdb9696 added this to the 0.7.0.2 milestone Jul 1, 2024
@sdb9696 sdb9696 mentioned this pull request Jul 1, 2024
Prepare 0.7.0.2 #1028
Merged
sdb9696 added a commit that referenced this pull request Jul 1, 2024
@sdb9696
Prepare 0.7.0.2 (#1028)
38a8c96 
## [0.7.0.2](https://github.com/python-kasa/python-kasa/tree/0.7.0.2) (2024-07-01)

[Full Changelog](0.7.0.1...0.7.0.2)

This patch release fixes some minor issues found out during testing against all new homeassistant platforms.

**Fixed bugs:**

- Disable multi-request on unknown errors [\#1027](#1027) (@sdb9696)
- Disable multi requests on json decode error during multi-request [\#1025](#1025) (@sdb9696)
- Fix changing brightness when effect is active [\#1019](#1019) (@rytilahti)
- Update light transition module to work with child devices [\#1017](#1017) (@sdb9696)
- Handle unknown error codes gracefully [\#1016](#1016) (@rytilahti)

**Project maintenance:**

- Make parent attribute on device consistent across iot and smart [\#1023](#1023) (@sdb9696)
- Cache SmartErrorCode creation [\#1022](#1022) (@bdraco)
pillarsdotnet pushed a commit to pillarsdotnet/python-kasa that referenced this pull request Oct 22, 2026
@sdb9696
Make parent attribute on device consistent across iot and smart (pyth…
ba3b20b 
…on-kasa#1023)

Both device types now have an internal `_parent` and a public property getter
pillarsdotnet pushed a commit to pillarsdotnet/python-kasa that referenced this pull request Oct 22, 2026
@sdb9696
Prepare 0.7.0.2 (python-kasa#1028)
c89adc3 
## [0.7.0.2](https://github.com/python-kasa/python-kasa/tree/0.7.0.2) (2024-07-01)

[Full Changelog](python-kasa/python-kasa@0.7.0.1...0.7.0.2)

This patch release fixes some minor issues found out during testing against all new homeassistant platforms.

**Fixed bugs:**

- Disable multi-request on unknown errors [\python-kasa#1027](python-kasa#1027) (@sdb9696)
- Disable multi requests on json decode error during multi-request [\python-kasa#1025](python-kasa#1025) (@sdb9696)
- Fix changing brightness when effect is active [\python-kasa#1019](python-kasa#1019) (@rytilahti)
- Update light transition module to work with child devices [\python-kasa#1017](python-kasa#1017) (@sdb9696)
- Handle unknown error codes gracefully [\python-kasa#1016](python-kasa#1016) (@rytilahti)

**Project maintenance:**

- Make parent attribute on device consistent across iot and smart [\python-kasa#1023](python-kasa#1023) (@sdb9696)
- Cache SmartErrorCode creation [\python-kasa#1022](python-kasa#1022) (@bdraco)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rytilahti rytilahti rytilahti approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

maintenance Project improvements and maintenance

Projects

None yet

Milestone

0.7.0.2

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@sdb9696 @rytilahti
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.