GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Disable multi requests on json decode error during multi-request by sdb9696 · Pull Request #1025 · python-kasa/python-kasa

Conversation

@sdb9696

@sdb9696 sdb9696 commented Jul 1, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Fixes an issue with the P100 being unable to process multi requests and raising JSON_DECODE_FAILURE.

It's not clear why the specific device gets this error as another exactly the same device with same hw/fw versions did not have the issues. The only difference I could tell was the device with errors was cloud connected and the device without errors did not have the time set. 🤷

Before fix:

image

After fix:

image

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
sdb9696 added 2 commits July 1, 2024 12:35
@sdb9696
Disable multi requests on JSON_DECODE_FAILURE during multi-request
2f19819
@sdb9696
Fix tests
9dc141e
@rytilahti rytilahti added the bug Something isn't working label Jul 1, 2024
rytilahti
rytilahti approved these changes Jul 1, 2024
View reviewed changes

@rytilahti rytilahti left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@codecov

codecov Bot commented Jul 1, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.44%. Comparing base (b31a2ed) to head (8f6af3f).
Report is 86 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1025      +/-   ##
==========================================
+ Coverage   91.42%   91.44%   +0.02%     
==========================================
  Files          84       84              
  Lines        5724     5739      +15     
  Branches     1392     1395       +3     
==========================================
+ Hits         5233     5248      +15     
  Misses        382      382              
  Partials      109      109              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

sdb9696 and others added 4 commits July 1, 2024 13:12
@sdb9696
Merge remote-tracking branch 'upstream/master' into fix/P100_JSON_DECODE
1cffc9a
@sdb9696
Merge branch 'master' into fix/P100_JSON_DECODE
af74540
@sdb9696
Merge branch 'fix/P100_JSON_DECODE' of https://github.com/python-kasa…
d4556cc
…/python-kasa into fix/P100_JSON_DECODE
@sdb9696
Add another test
8f6af3f
@sdb9696 sdb9696 changed the title Disable multi requests on JSON_DECODE_FAILURE during multi-request Disable multi requests on json decode error during multi-request Jul 1, 2024
@sdb9696
sdb9696 merged commit 8d1a4a4 into master Jul 1, 2024
@sdb9696
sdb9696 deleted the fix/P100_JSON_DECODE branch July 1, 2024 12:57
@sdb9696 sdb9696 added this to the 0.7.0.2 milestone Jul 1, 2024
@sdb9696 sdb9696 mentioned this pull request Jul 1, 2024
Prepare 0.7.0.2 #1028
Merged
sdb9696 added a commit that referenced this pull request Jul 1, 2024
@sdb9696
Prepare 0.7.0.2 (#1028)
38a8c96
## [0.7.0.2](https://github.com/python-kasa/python-kasa/tree/0.7.0.2) (2024-07-01)

[Full Changelog](0.7.0.1...0.7.0.2)

This patch release fixes some minor issues found out during testing against all new homeassistant platforms.

**Fixed bugs:**

- Disable multi-request on unknown errors [\#1027](#1027) (@sdb9696)
- Disable multi requests on json decode error during multi-request [\#1025](#1025) (@sdb9696)
- Fix changing brightness when effect is active [\#1019](#1019) (@rytilahti)
- Update light transition module to work with child devices [\#1017](#1017) (@sdb9696)
- Handle unknown error codes gracefully [\#1016](#1016) (@rytilahti)

**Project maintenance:**

- Make parent attribute on device consistent across iot and smart [\#1023](#1023) (@sdb9696)
- Cache SmartErrorCode creation [\#1022](#1022) (@bdraco)
@KaloyanNaumov KaloyanNaumov mentioned this pull request Sep 13, 2026
Disable multi requests on timeout during multi-request #1759
Merged
rytilahti pushed a commit that referenced this pull request Oct 4, 2026
@KaloyanNaumov @claude
Disable multi requests on timeout during multi-request (#1759)
eed64fe
_execute_multiple_query only disables batching on JSON_DECODE_FAIL_ERROR / INTERNAL_UNKNOWN_ERROR (#1025). This change applies the same pattern to a TimeoutError raised while sending a batch: set the batch size to 1 and raise _RetryableError.

---------

Co-authored-by: Claude Opus 5 (1M context) <[email protected]>
pillarsdotnet pushed a commit to pillarsdotnet/python-kasa that referenced this pull request Oct 22, 2026
@sdb9696
Disable multi requests on json decode error during multi-request (pyt…
7a271b8
…hon-kasa#1025)

Issue affecting some P100 devices
pillarsdotnet pushed a commit to pillarsdotnet/python-kasa that referenced this pull request Oct 22, 2026
@sdb9696
Prepare 0.7.0.2 (python-kasa#1028)
c89adc3
## [0.7.0.2](https://github.com/python-kasa/python-kasa/tree/0.7.0.2) (2024-07-01)

[Full Changelog](python-kasa/python-kasa@0.7.0.1...0.7.0.2)

This patch release fixes some minor issues found out during testing against all new homeassistant platforms.

**Fixed bugs:**

- Disable multi-request on unknown errors [\python-kasa#1027](python-kasa#1027) (@sdb9696)
- Disable multi requests on json decode error during multi-request [\python-kasa#1025](python-kasa#1025) (@sdb9696)
- Fix changing brightness when effect is active [\python-kasa#1019](python-kasa#1019) (@rytilahti)
- Update light transition module to work with child devices [\python-kasa#1017](python-kasa#1017) (@sdb9696)
- Handle unknown error codes gracefully [\python-kasa#1016](python-kasa#1016) (@rytilahti)

**Project maintenance:**

- Make parent attribute on device consistent across iot and smart [\python-kasa#1023](python-kasa#1023) (@sdb9696)
- Cache SmartErrorCode creation [\python-kasa#1022](python-kasa#1022) (@bdraco)
pillarsdotnet pushed a commit to pillarsdotnet/python-kasa that referenced this pull request Oct 30, 2026
@KaloyanNaumov @claude
Disable multi requests on timeout during multi-request (python-kasa#1759
b229683
)

_execute_multiple_query only disables batching on JSON_DECODE_FAIL_ERROR / INTERNAL_UNKNOWN_ERROR (python-kasa#1025). This change applies the same pattern to a TimeoutError raised while sending a batch: set the batch size to 1 and raise _RetryableError.

---------

Co-authored-by: Claude Opus 5 (1M context) <[email protected]>
@ZeliardM ZeliardM mentioned this pull request Oct 31, 2026
Split KLAP IoT updates into smaller requests and validate KLAP responses #1829
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rytilahti rytilahti rytilahti approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

bug Something isn't working

Projects

None yet

Milestone

0.7.0.2

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@sdb9696 @rytilahti
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.