GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — fix: More explicit error messages by tpvasconcelos · Pull Request #2708 · feast-dev/feast

Conversation

@tpvasconcelos

@tpvasconcelos tpvasconcelos commented May 16, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

What this PR does / why we need it:

This PR adds more explicit error messages to validation checks (for better Pydantic error messages).

Fixes #2696

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@feast-ci-bot feast-ci-bot added the size/S label May 16, 2022
@tpvasconcelos

tpvasconcelos commented May 16, 2022

Copy link
Copy Markdown
Contributor Author

@achals here's an example for the repo_config.py module. If this is fine with you, I'll work on another PR later addressing more of these cases 👍

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@tpvasconcelos tpvasconcelos changed the title More explicit error messages (repo_config.py) feat: More explicit error messages (repo_config.py) May 16, 2022
@codecov-commenter

codecov-commenter commented May 16, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Codecov Report

Merging #2708 (5f6e645) into master (5d6fa94) will decrease coverage by 22.33%.
The diff coverage is 45.45%.

@@             Coverage Diff             @@
##           master    #2708       +/-   ##
===========================================
- Coverage   80.99%   58.65%   -22.34%     
===========================================
  Files         166      166               
  Lines       13890    13899        +9     
===========================================
- Hits        11250     8153     -3097     
- Misses       2640     5746     +3106     
Flag Coverage Δ
integrationtests ?
unittests 58.65% <45.45%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdk/python/feast/repo_config.py 78.41% <37.50%> (-10.38%) ⬇️
sdk/python/feast/errors.py 67.05% <66.66%> (-4.20%) ⬇️
.../integration/online_store/test_online_retrieval.py 16.84% <0.00%> (-83.16%) ⬇️
sdk/python/tests/utils/online_read_write_test.py 19.35% <0.00%> (-80.65%) ⬇️
.../integration/online_store/test_universal_online.py 17.64% <0.00%> (-77.78%) ⬇️
...fline_store/test_universal_historical_retrieval.py 24.17% <0.00%> (-75.83%) ⬇️
...ests/integration/e2e/test_python_feature_server.py 28.35% <0.00%> (-71.65%) ⬇️
sdk/python/feast/wait.py 23.52% <0.00%> (-70.59%) ⬇️
...gration/registration/test_feature_service_apply.py 31.25% <0.00%> (-68.75%) ⬇️
...dk/python/tests/integration/e2e/test_validation.py 32.72% <0.00%> (-67.28%) ⬇️
... and 72 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d6fa94...5f6e645. Read the comment docs.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@achals

achals commented May 16, 2022

Copy link
Copy Markdown
Member

Hey @tpvasconcelos this looks great! One nit is that this should probably be a fix or a chore instead of a feat (the tooling we're using doesn't allow us to cherry pick feats onto patch releases)

tpvasconcelos reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@tpvasconcelos tpvasconcelos changed the title feat: More explicit error messages (repo_config.py) fix: More explicit error messages (repo_config.py) May 16, 2022
@tpvasconcelos

tpvasconcelos commented May 16, 2022

Copy link
Copy Markdown
Contributor Author

@achals fixed! Let's keep #2696 open for now? I'll try finding some time to take a look at other cases

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@achals

achals commented May 16, 2022

Copy link
Copy Markdown
Member

Works for me - I'll move it to a draft state so that it doesn't show up on others ppls review dashboard.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@achals
achals marked this pull request as draft May 16, 2022 20:53
@feast-ci-bot feast-ci-bot added the do-not-merge/work-in-progress label May 16, 2022
@tpvasconcelos

tpvasconcelos commented May 16, 2022

Copy link
Copy Markdown
Contributor Author

Ah right you want to include everything in a single PR. I'll update the title and description then 👍

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@tpvasconcelos tpvasconcelos changed the title fix: More explicit error messages (repo_config.py) fix: More explicit error messages May 16, 2022
@achals

achals commented May 16, 2022

Copy link
Copy Markdown
Member

Ah right you want to include everything in a single PR. I'll update the title and description then 👍

Oh oops! I misunderstood. I am okay merging this in as-is, and keeping the associated ticket open until you feel we have squashed enough of these errors. Please lemme know what you'd like to do!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@adchia
adchia marked this pull request as ready for review August 3, 2022 13:54
@feast-ci-bot feast-ci-bot removed the do-not-merge/work-in-progress label Aug 3, 2022
@tpvasconcelos @adchia
Add more explicit error messages to validation checks in repo_config.…
7b8f8e3
…py (for better pydantic error messages)

Signed-off-by: Tomas Pereira de Vasconcelos <[email protected]>
@adchia
adchia force-pushed the explicit-pydantic-errors branch from 5f6e645 to 7b8f8e3 Compare August 3, 2022 13:55
adchia
adchia approved these changes Aug 3, 2022
View reviewed changes

@adchia adchia left a comment

Copy link
Copy Markdown
Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@feast-ci-bot feast-ci-bot assigned adchia Aug 3, 2022
@feast-ci-bot

feast-ci-bot commented Aug 3, 2022

Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adchia, tpvasconcelos

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [adchia]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@feast-ci-bot feast-ci-bot added lgtm approved labels Aug 3, 2022
@feast-ci-bot
feast-ci-bot merged commit e4d7afd into feast-dev:master Aug 3, 2022
felixwang9817 pushed a commit to felixwang9817/feast that referenced this pull request Aug 5, 2022
@feast-ci-bot
chore(release): release 0.24.0
a39a211
# [0.24.0](v0.23.0...v0.24.0) (2022-08-05)

### Bug Fixes

* More explicit error messages ([feast-dev#2708](https://github.com/felixwang9817/feast/issues/2708)) ([e4d7afd](e4d7afd))

### Features

* Empty file ([e12b33c](e12b33c))
adchia pushed a commit that referenced this pull request Aug 10, 2022
@tpvasconcelos @adchia
fix: More explicit error messages (#2708)
93c1c15
Add more explicit error messages to validation checks in repo_config.py (for better pydantic error messages)

Signed-off-by: Tomas Pereira de Vasconcelos <[email protected]>
adchia pushed a commit that referenced this pull request Aug 10, 2022
@tpvasconcelos @adchia
fix: More explicit error messages (#2708)
ca48963
Add more explicit error messages to validation checks in repo_config.py (for better pydantic error messages)

Signed-off-by: Tomas Pereira de Vasconcelos <[email protected]>
adchia pushed a commit that referenced this pull request Aug 10, 2022
@feast-ci-bot
chore(release): release 0.23.1
4a92be4
## [0.23.1](v0.23.0...v0.23.1) (2022-08-10)

### Bug Fixes

* Check if on_demand_feature_views is an empty list rather than None for snowflake provider ([#3046](#3046)) ([6af401f](6af401f))
* Fix Feast Java inconsistency with int64 serialization vs python ([#3031](#3031)) ([f340aeb](f340aeb))
* Fixing Web UI, which fails for the SQL registry ([#3028](#3028)) ([d584ecd](d584ecd))
* More explicit error messages ([#2708](#2708)) ([ca48963](ca48963))
* Return an empty infra object from sql registry when it doesn't exist ([#3022](#3022)) ([9a64e77](9a64e77))
adchia pushed a commit that referenced this pull request Aug 10, 2022
@feast-ci-bot
chore(release): release 0.22.3
f06874a
## [0.22.3](v0.22.2...v0.22.3) (2022-08-10)

### Bug Fixes

* Check if on_demand_feature_views is an empty list rather than None for snowflake provider ([#3046](#3046)) ([67af727](67af727))
* Fixing Web UI, which fails for the SQL registry ([#3028](#3028)) ([56d645c](56d645c))
* More explicit error messages ([#2708](#2708)) ([93c1c15](93c1c15))
* Move gcp back to 1.47.0 since grpcio-tools 1.48.0 got yanked from pypi ([#2990](#2990)) ([f7e44da](f7e44da))
* Return an empty infra object from sql registry when it doesn't exist ([#3022](#3022)) ([329bc47](329bc47))
kevjumba pushed a commit that referenced this pull request Aug 25, 2022
@feast-ci-bot
chore(release): release 0.24.0
c1c71da
# [0.24.0](v0.23.0...v0.24.0) (2022-08-25)

### Bug Fixes

* Check if on_demand_feature_views is an empty list rather than None for snowflake provider ([#3046](#3046)) ([9b05e65](9b05e65))
* FeatureStore.apply applies BatchFeatureView correctly ([#3098](#3098)) ([41be511](41be511))
* Fix Feast Java inconsistency with int64 serialization vs python ([#3031](#3031)) ([4bba787](4bba787))
* Fix feature service inference logic ([#3089](#3089)) ([4310ed7](4310ed7))
* Fix field mapping logic during feature inference ([#3067](#3067)) ([cdfa761](cdfa761))
* Fix incorrect on demand feature view diffing and improve Java tests ([#3074](#3074)) ([0702310](0702310))
* Fix Java helm charts to work with refactored logic. Fix FTS image ([#3105](#3105)) ([2b493e0](2b493e0))
* Fix on demand feature view output in feast plan + Web UI crash ([#3057](#3057)) ([bfae6ac](bfae6ac))
* Fix release workflow to release 0.24.0 ([#3138](#3138)) ([a69aaae](a69aaae))
* Fix Spark offline store type conversion to arrow ([#3071](#3071)) ([b26566d](b26566d))
* Fixing Web UI, which fails for the SQL registry ([#3028](#3028)) ([64603b6](64603b6))
* Force Snowflake Session to Timezone UTC ([#3083](#3083)) ([9f221e6](9f221e6))
* Make infer dummy entity join key idempotent ([#3115](#3115)) ([1f5b1e0](1f5b1e0))
* More explicit error messages ([#2708](#2708)) ([e4d7afd](e4d7afd))
* Parse inline data sources ([#3036](#3036)) ([c7ba370](c7ba370))
* Prevent overwriting existing file during `persist` ([#3088](#3088)) ([69af21f](69af21f))
* Register BatchFeatureView in feature repos correctly ([#3092](#3092)) ([b8e39ea](b8e39ea))
* Return an empty infra object from sql registry when it doesn't exist ([#3022](#3022)) ([8ba87d1](8ba87d1))
* Teardown tables for Snowflake Materialization testing ([#3106](#3106)) ([0a0c974](0a0c974))
* UI error when saved dataset is present in registry. ([#3124](#3124)) ([83cf753](83cf753))
* Update sql.py ([#3096](#3096)) ([2646a86](2646a86))
* Updated snowflake template ([#3130](#3130)) ([f0594e1](f0594e1))

### Features

* Add authentication option for snowflake connector ([#3039](#3039)) ([74c75f1](74c75f1))
* Add Cassandra/AstraDB online store contribution ([#2873](#2873)) ([feb6cb8](feb6cb8))
* Add Snowflake materialization engine ([#2948](#2948)) ([f3b522b](f3b522b))
* Adding saved dataset capabilities for Postgres  ([#3070](#3070)) ([d3253c3](d3253c3))
* Allow passing repo config path via flag ([#3077](#3077)) ([0d2d951](0d2d951))
* Contrib azure provider with synapse/mssql offline store and Azure registry store ([#3072](#3072)) ([9f7e557](9f7e557))
* Custom Docker image for Bytewax batch materialization ([#3099](#3099)) ([cdd1b07](cdd1b07))
* Feast AWS Athena offline store (again) ([#3044](#3044)) ([989ce08](989ce08))
* Implement spark offline store `offline_write_batch` method ([#3076](#3076)) ([5b0cc87](5b0cc87))
* Initial Bytewax materialization engine ([#2974](#2974)) ([55c61f9](55c61f9))
* Refactor feature server helm charts to allow passing feature_store.yaml in environment variables ([#3113](#3113)) ([85ee789](85ee789))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adchia adchia adchia approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@adchia adchia

Labels

approved lgtm size/S

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Better and more explicit Pydantic error messages

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@tpvasconcelos @codecov-commenter @achals @feast-ci-bot @adchia
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.