GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — fix: Return an empty infra object from sql registry when it doesn't exist by achals · Pull Request #3022 · feast-dev/feast

Conversation

achals commented Aug 5, 2022

Copy link

Copy Markdown

Member

Signed-off-by: Achal Shah [email protected]

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #3000

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          fix: Return an empty infra object from sql registry when it doesn't e…

b74e6d0

…xist

Signed-off-by: Achal Shah <[email protected]>

feast-ci-bot added approved size/S labels

Aug 5, 2022

kevjumba approved these changes

Aug 5, 2022

View reviewed changes

kevjumba left a comment

Copy link

Copy Markdown

Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

feast-ci-bot assigned kevjumba

Aug 5, 2022

feast-ci-bot added the lgtm label

Aug 5, 2022

kevjumba added the ok-to-test label

Aug 5, 2022


          better

1d77749

Signed-off-by: Achal Shah <[email protected]>

feast-ci-bot removed the lgtm label

Aug 5, 2022

codecov-commenter commented Aug 5, 2022 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Codecov Report

Merging #3022 (d9111ef) into master (826da67) will decrease coverage by 18.19%.
The diff coverage is 40.00%.

@@             Coverage Diff             @@
##           master    #3022       +/-   ##
===========================================
- Coverage   77.59%   59.40%   -18.20%     
===========================================
  Files         194      194               
  Lines       16267    16272        +5     
===========================================
- Hits        12622     9666     -2956     
- Misses       3645     6606     +2961

Flag	Coverage Δ
integrationtests	`?`
unittests	`59.40% <40.00%> (-0.02%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
sdk/python/feast/infra/registry_stores/sql.py	`72.48% <40.00%> (-0.90%)`	⬇️
...sts/integration/registration/test_universal_cli.py	`20.20% <0.00%> (-79.80%)`	⬇️
...ts/integration/offline_store/test_offline_write.py	`26.08% <0.00%> (-73.92%)`	⬇️
...fline_store/test_universal_historical_retrieval.py	`28.94% <0.00%> (-71.06%)`	⬇️
...ests/integration/e2e/test_python_feature_server.py	`29.50% <0.00%> (-70.50%)`	⬇️
...dk/python/tests/integration/e2e/test_validation.py	`27.77% <0.00%> (-69.05%)`	⬇️
...s/integration/registration/test_universal_types.py	`32.25% <0.00%> (-67.75%)`	⬇️
sdk/python/feast/infra/online_stores/redis.py	`28.39% <0.00%> (-66.67%)`	⬇️
sdk/python/tests/integration/e2e/test_usage_e2e.py	`33.87% <0.00%> (-66.13%)`	⬇️
sdk/python/tests/data/data_creator.py	`34.78% <0.00%> (-65.22%)`	⬇️
... and 67 more

Help us with your feedback. Take ten seconds to tell us how you rate us.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

achals added 2 commits

August 5, 2022 14:25


          types

7e85fba

Signed-off-by: Achal Shah <[email protected]>


          fix hasattr

d9111ef

Signed-off-by: Achal Shah <[email protected]>

feast-ci-bot added size/M and removed size/S labels

Aug 5, 2022

adchia approved these changes

Aug 5, 2022

View reviewed changes

adchia left a comment

Copy link

Copy Markdown

Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

feast-ci-bot assigned adchia

Aug 5, 2022

feast-ci-bot commented Aug 5, 2022

Copy link

Copy Markdown

Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: achals, adchia, kevjumba

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [achals,adchia,kevjumba]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

feast-ci-bot added the lgtm label

Aug 5, 2022

feast-ci-bot merged commit 8ba87d1 into feast-dev:master

Aug 5, 2022

achals deleted the achal/infra-bug branch

August 8, 2022 15:52

adchia pushed a commit that referenced this pull request

Aug 10, 2022


          fix: Return an empty infra object from sql registry when it doesn't e…

329bc47

…xist (#3022)

* fix: Return an empty infra object from sql registry when it doesn't exist

Signed-off-by: Achal Shah <[email protected]>

* better

Signed-off-by: Achal Shah <[email protected]>

* types

Signed-off-by: Achal Shah <[email protected]>

* fix hasattr

Signed-off-by: Achal Shah <[email protected]>

adchia pushed a commit that referenced this pull request

Aug 10, 2022


          fix: Return an empty infra object from sql registry when it doesn't e…

9a64e77

…xist (#3022)

* fix: Return an empty infra object from sql registry when it doesn't exist

Signed-off-by: Achal Shah <[email protected]>

* better

Signed-off-by: Achal Shah <[email protected]>

* types

Signed-off-by: Achal Shah <[email protected]>

* fix hasattr

Signed-off-by: Achal Shah <[email protected]>

adchia pushed a commit that referenced this pull request

Aug 10, 2022


          chore(release): release 0.23.1

4a92be4

## [0.23.1](v0.23.0...v0.23.1) (2022-08-10)

### Bug Fixes

* Check if on_demand_feature_views is an empty list rather than None for snowflake provider ([#3046](#3046)) ([6af401f](6af401f))
* Fix Feast Java inconsistency with int64 serialization vs python ([#3031](#3031)) ([f340aeb](f340aeb))
* Fixing Web UI, which fails for the SQL registry ([#3028](#3028)) ([d584ecd](d584ecd))
* More explicit error messages ([#2708](#2708)) ([ca48963](ca48963))
* Return an empty infra object from sql registry when it doesn't exist ([#3022](#3022)) ([9a64e77](9a64e77))

adchia pushed a commit that referenced this pull request

Aug 10, 2022


          chore(release): release 0.22.3

f06874a

## [0.22.3](v0.22.2...v0.22.3) (2022-08-10)

### Bug Fixes

* Check if on_demand_feature_views is an empty list rather than None for snowflake provider ([#3046](#3046)) ([67af727](67af727))
* Fixing Web UI, which fails for the SQL registry ([#3028](#3028)) ([56d645c](56d645c))
* More explicit error messages ([#2708](#2708)) ([93c1c15](93c1c15))
* Move gcp back to 1.47.0 since grpcio-tools 1.48.0 got yanked from pypi ([#2990](#2990)) ([f7e44da](f7e44da))
* Return an empty infra object from sql registry when it doesn't exist ([#3022](#3022)) ([329bc47](329bc47))

kevjumba pushed a commit that referenced this pull request

Aug 25, 2022


          chore(release): release 0.24.0

c1c71da

# [0.24.0](v0.23.0...v0.24.0) (2022-08-25)

### Bug Fixes

* Check if on_demand_feature_views is an empty list rather than None for snowflake provider ([#3046](#3046)) ([9b05e65](9b05e65))
* FeatureStore.apply applies BatchFeatureView correctly ([#3098](#3098)) ([41be511](41be511))
* Fix Feast Java inconsistency with int64 serialization vs python ([#3031](#3031)) ([4bba787](4bba787))
* Fix feature service inference logic ([#3089](#3089)) ([4310ed7](4310ed7))
* Fix field mapping logic during feature inference ([#3067](#3067)) ([cdfa761](cdfa761))
* Fix incorrect on demand feature view diffing and improve Java tests ([#3074](#3074)) ([0702310](0702310))
* Fix Java helm charts to work with refactored logic. Fix FTS image ([#3105](#3105)) ([2b493e0](2b493e0))
* Fix on demand feature view output in feast plan + Web UI crash ([#3057](#3057)) ([bfae6ac](bfae6ac))
* Fix release workflow to release 0.24.0 ([#3138](#3138)) ([a69aaae](a69aaae))
* Fix Spark offline store type conversion to arrow ([#3071](#3071)) ([b26566d](b26566d))
* Fixing Web UI, which fails for the SQL registry ([#3028](#3028)) ([64603b6](64603b6))
* Force Snowflake Session to Timezone UTC ([#3083](#3083)) ([9f221e6](9f221e6))
* Make infer dummy entity join key idempotent ([#3115](#3115)) ([1f5b1e0](1f5b1e0))
* More explicit error messages ([#2708](#2708)) ([e4d7afd](e4d7afd))
* Parse inline data sources ([#3036](#3036)) ([c7ba370](c7ba370))
* Prevent overwriting existing file during `persist` ([#3088](#3088)) ([69af21f](69af21f))
* Register BatchFeatureView in feature repos correctly ([#3092](#3092)) ([b8e39ea](b8e39ea))
* Return an empty infra object from sql registry when it doesn't exist ([#3022](#3022)) ([8ba87d1](8ba87d1))
* Teardown tables for Snowflake Materialization testing ([#3106](#3106)) ([0a0c974](0a0c974))
* UI error when saved dataset is present in registry. ([#3124](#3124)) ([83cf753](83cf753))
* Update sql.py ([#3096](#3096)) ([2646a86](2646a86))
* Updated snowflake template ([#3130](#3130)) ([f0594e1](f0594e1))

### Features

* Add authentication option for snowflake connector ([#3039](#3039)) ([74c75f1](74c75f1))
* Add Cassandra/AstraDB online store contribution ([#2873](#2873)) ([feb6cb8](feb6cb8))
* Add Snowflake materialization engine ([#2948](#2948)) ([f3b522b](f3b522b))
* Adding saved dataset capabilities for Postgres  ([#3070](#3070)) ([d3253c3](d3253c3))
* Allow passing repo config path via flag ([#3077](#3077)) ([0d2d951](0d2d951))
* Contrib azure provider with synapse/mssql offline store and Azure registry store ([#3072](#3072)) ([9f7e557](9f7e557))
* Custom Docker image for Bytewax batch materialization ([#3099](#3099)) ([cdd1b07](cdd1b07))
* Feast AWS Athena offline store (again) ([#3044](#3044)) ([989ce08](989ce08))
* Implement spark offline store `offline_write_batch` method ([#3076](#3076)) ([5b0cc87](5b0cc87))
* Initial Bytewax materialization engine ([#2974](#2974)) ([55c61f9](55c61f9))
* Refactor feature server helm charts to allow passing feature_store.yaml in environment variables ([#3113](#3113)) ([85ee789](85ee789))

Reviewers

adchia

adchia approved these changes

kevjumba

kevjumba approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

adchia

kevjumba

Labels

approved lgtm ok-to-test size/M

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Unable to feast apply when using SQL Registry

Uh oh!

There was an error while loading. Please reload this page.

5 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

achals commented Aug 5, 2022

Uh oh!

kevjumba left a comment

Choose a reason for hiding this comment

Uh oh!

codecov-commenter commented Aug 5, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

adchia left a comment

Choose a reason for hiding this comment

Uh oh!

feast-ci-bot commented Aug 5, 2022

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

codecov-commenter commented Aug 5, 2022 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.