GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — feat: Contrib azure provider with synapse/mssql offline store and Azure registry store by kevjumba · Pull Request #3072 · feast-dev/feast

Conversation

@kevjumba

@kevjumba kevjumba commented Aug 11, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Collaborator

What this PR does / why we need it:
Moving https://github.com/Azure/feast-azure feast_azure_provider package into feast as contrib. Does not move the kubernetes cluster configuration.

Which issue(s) this PR fixes:

Fixes #

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@feast-ci-bot feast-ci-bot added approved size/XXL labels Aug 11, 2022
@kevjumba kevjumba changed the title Azure provider feat: Contrib azure provider with synapse/mssql offline store and Azure registry store Aug 11, 2022
@codecov-commenter

codecov-commenter commented Aug 11, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Codecov Report

Merging #3072 (516ff76) into master (29f2895) will increase coverage by 8.16%.
The diff coverage is 44.50%.

@@            Coverage Diff             @@
##           master    #3072      +/-   ##
==========================================
+ Coverage   67.86%   76.03%   +8.16%     
==========================================
  Files         176      214      +38     
  Lines       15507    17897    +2390     
==========================================
+ Hits        10524    13608    +3084     
+ Misses       4983     4289     -694
Flag Coverage Δ
integrationtests 66.96% <42.94%> (-0.91%) ⬇️
unittests 57.87% <40.31%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdk/python/feast/data_source.py 81.68% <ø> (+23.44%) ⬆️
sdk/python/feast/feature_store.py 85.60% <ø> (+3.66%) ⬆️
sdk/python/feast/infra/provider.py 77.94% <ø> (ø)
sdk/python/feast/infra/registry/registry.py 80.83% <ø> (+5.20%) ⬆️
...sts/integration/registration/test_universal_cli.py 100.00% <ø> (ø)
setup.py 0.00% <0.00%> (ø)
sdk/python/feast/type_map.py 57.62% <10.52%> (-2.75%) ⬇️
sdk/python/feast/repo_config.py 87.54% <25.00%> (+4.40%) ⬆️
sdk/python/feast/inference.py 85.39% <33.33%> (-0.66%) ⬇️
...ffline_stores/contrib/mssql_offline_store/mssql.py 38.42% <38.42%> (ø)
... and 119 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@kevjumba
kevjumba force-pushed the azure_provider branch 2 times, most recently from dba6b1f to 7fdc2ae Compare August 12, 2022 19:42
@kevjumba kevjumba added the ok-to-test label Aug 12, 2022
adchia
adchia reviewed Aug 12, 2022
View reviewed changes

@adchia adchia left a comment

Copy link
Copy Markdown
Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not needed, but we could theoretically setup CI by using https://docs.microsoft.com/en-us/azure/azure-sql-edge/disconnected-deployment and using test-containers.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread docs/reference/offline-stores/mssql.md
## Functionality Matrix

The set of functionality supported by offline stores is described in detail [here](overview.md#functionality).
Below is a matrix indicating which functionality is supported by the Spark offline store.

@adchia adchia Aug 12, 2022

Copy link
Copy Markdown
Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not spark?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@kevjumba kevjumba Aug 17, 2022

Copy link
Copy Markdown
Collaborator Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread docs/roadmap.md Outdated
* [x] [BigQuery source](https://docs.feast.dev/reference/data-sources/bigquery)
* [x] [Parquet file source](https://docs.feast.dev/reference/data-sources/file)
* [x] [Synapse source (community plugin)](https://github.com/Azure/feast-azure)
* [x] [Synapse source (contrib plugin)](https://docs.feast.dev/reference/data-sources/mssql)

@adchia adchia Aug 12, 2022

Copy link
Copy Markdown
Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this be Azure Synapse + Azure SQL?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@kevjumba kevjumba Aug 17, 2022

Copy link
Copy Markdown
Collaborator Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
adchia
adchia reviewed Aug 12, 2022
View reviewed changes
Comment thread sdk/python/feast/infra/contrib/azure_provider.py Outdated
make_tzaware,
)

# Make sure spark warning doesn't raise more than once.

@adchia adchia Aug 12, 2022

Copy link
Copy Markdown
Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not spark

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@adchia adchia Aug 12, 2022

Copy link
Copy Markdown
Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as discussed, we can kill this provider probably or use passthroughprovider

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@kevjumba kevjumba Aug 17, 2022

Copy link
Copy Markdown
Collaborator Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Lejboelle
Lejboelle reviewed Aug 15, 2022
View reviewed changes
Comment thread sdk/python/feast/data_source.py

if data_source_type == DataSourceProto.SourceType.CUSTOM_SOURCE:
data_source.data_source_class_type = "feast.infra.offline_stores.contrib.mssql_offline_store.mssqlserver_source.MsSqlServerSource"
cls = get_data_source_class_from_type(data_source.data_source_class_type)

@Lejboelle Lejboelle Aug 15, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of hard coding the class type here, I believe it should be declared in the to_proto() function of the MsSqlServerSource class. This is done in case of the other offline contrib stores and also ensures that there are no conflicts with any other future custom sources.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@kevjumba kevjumba Aug 17, 2022

Copy link
Copy Markdown
Collaborator Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@kevjumba
kevjumba force-pushed the azure_provider branch 2 times, most recently from 2eaebdd to 8d92603 Compare August 17, 2022 18:57
adchia
adchia reviewed Aug 17, 2022
View reviewed changes
Comment thread sdk/python/feast/infra/offline_stores/contrib/mssql_offline_store/tests/data_source.py Outdated
super().__init__(project_name)
self.tables_created: List[str] = []
self.container = SqlServerContainer(user=MSSQL_USER, password=MSSQL_PASSWORD)
# self.container = fixture_request.getfixturevalue("mssql_container")

@adchia adchia Aug 17, 2022

Copy link
Copy Markdown
Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove all the commented line here?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@kevjumba kevjumba Aug 17, 2022

Copy link
Copy Markdown
Collaborator Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread sdk/python/feast/infra/offline_stores/contrib/mssql_offline_store/tests/data_source.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread sdk/python/feast/type_map.py Outdated
pa_type_as_str = str(pa_type).lower()
if pa_type_as_str.startswith("timestamp"):
if "tz=" in pa_type_as_str:
return "DATETIME2"

@adchia adchia Aug 17, 2022

Copy link
Copy Markdown
Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any reason why this is upper case and not lower case like everything else?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread docs/reference/data-sources/mssql.md Outdated

@adchia adchia Aug 17, 2022

Copy link
Copy Markdown
Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: SQL

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@kevjumba kevjumba Aug 17, 2022

Copy link
Copy Markdown
Collaborator Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@adchia adchia Aug 18, 2022

Copy link
Copy Markdown
Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doesn't look fixed to me? (Microsoft sql table sources)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@kevjumba kevjumba Aug 18, 2022

Copy link
Copy Markdown
Collaborator Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh sorry, I realized I hadn't pushed my changes last night.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread sdk/python/feast/infra/contrib/azure_provider.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread sdk/python/feast/infra/offline_stores/contrib/mssql_offline_store/tests/data_source.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread sdk/python/feast/infra/offline_stores/contrib/mssql_offline_store/mssqlserver_source.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread docs/reference/offline-stores/mssql.md Outdated

@adchia adchia Aug 17, 2022

Copy link
Copy Markdown
Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

call out synapse or sql server?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@kevjumba kevjumba Aug 17, 2022

Copy link
Copy Markdown
Collaborator Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread docs/tutorials/azure/README.md Outdated

@adchia adchia Aug 17, 2022

Copy link
Copy Markdown
Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these numbers seem wrong

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@kevjumba kevjumba Aug 17, 2022

Copy link
Copy Markdown
Collaborator Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread sdk/python/feast/infra/offline_stores/contrib/mssql_offline_store/mssql.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@adchia adchia self-assigned this Aug 17, 2022
adchia
adchia reviewed Aug 18, 2022
View reviewed changes
Comment thread sdk/python/feast/infra/offline_stores/contrib/mssql_offline_store/tests/data_source.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
adchia
adchia reviewed Aug 18, 2022
View reviewed changes
Comment thread sdk/python/feast/infra/offline_stores/contrib/mssql_offline_store/tests/data_source.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread sdk/python/feast/infra/offline_stores/contrib/mssql_offline_store/tests/data_source.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread sdk/python/feast/infra/offline_stores/contrib/mssql_offline_store/tests/data_source.py Outdated

@adchia adchia Aug 18, 2022

Copy link
Copy Markdown
Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if you always use the fixture as I suggest above, then this shouldn't be needed

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@kevjumba kevjumba Aug 18, 2022

Copy link
Copy Markdown
Collaborator Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread sdk/python/feast/infra/offline_stores/contrib/mssql_offline_store/tests/data_source.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread sdk/python/feast/infra/offline_stores/contrib/mssql_offline_store/mssql.py Outdated

@adchia adchia Aug 18, 2022

Copy link
Copy Markdown
Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you throw an exception here? e.g. some not implemented error so users know they can't pass a SQL string for MsSQL to generate the entity dataframe?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@kevjumba kevjumba Aug 18, 2022

Copy link
Copy Markdown
Collaborator Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread docs/reference/data-sources/mssql.md Outdated

@adchia adchia Aug 18, 2022

Copy link
Copy Markdown
Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doesn't look fixed to me? (Microsoft sql table sources)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread docs/tutorials/azure/README.md Outdated
## 6. Running Feast Azure Tutorials locally without Azure workspace

* If you are on a free tier instance, you will not be able to deploy the azure deployment because the azure workspace requires VCPUs and the free trial subscription does not have a quota.
* The workaround is to remove the `Microsoft.MachineLearningServices/workspaces/computes` resource from `fs_snapse_azure_deploy.json` and setting up the environment locally.

@adchia adchia Aug 18, 2022

Copy link
Copy Markdown
Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo? assuming should be synapse

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@kevjumba kevjumba Aug 18, 2022

Copy link
Copy Markdown
Collaborator Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the catch! fixed

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@kevjumba
kevjumba force-pushed the azure_provider branch 2 times, most recently from 35b123d to 452379f Compare August 18, 2022 17:24
@kevjumba
kevjumba requested a review from adchia August 18, 2022 17:26
adchia
adchia reviewed Aug 18, 2022
View reviewed changes
Comment thread sdk/python/feast/infra/offline_stores/contrib/mssql_offline_store/tests/data_source.py Outdated

@adchia adchia Aug 18, 2022

Copy link
Copy Markdown
Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pass in the azure-sql-edge image as mentioned above?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@kevjumba kevjumba Aug 18, 2022

Copy link
Copy Markdown
Collaborator Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I didn't realize you actually wanted to use this image. Updated.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread sdk/python/tests/integration/registration/test_universal_cli.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread sdk/python/tests/utils/e2e_test_validation.py Outdated

@adchia adchia Aug 18, 2022

Copy link
Copy Markdown
Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you shouldn't need to pass a fixture_request actually. the test environment already has a datasourcecreator

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@kevjumba kevjumba Aug 18, 2022

Copy link
Copy Markdown
Collaborator Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@kevjumba
kevjumba force-pushed the azure_provider branch 2 times, most recently from de40738 to f998d8b Compare August 19, 2022 02:57
kevjumba added 8 commits August 19, 2022 10:02
@kevjumba
Broken state
e1e210d 
Signed-off-by: Kevin Zhang <[email protected]>
@kevjumba
working state
011d1e0 
Signed-off-by: Kevin Zhang <[email protected]>
@kevjumba
Fix the lint issues
a6a2fce 
Signed-off-by: Kevin Zhang <[email protected]>
@kevjumba
Semi working state
57b63bb 
Signed-off-by: Kevin Zhang <[email protected]>
@kevjumba
Fix
ae7ed8a 
Signed-off-by: Kevin Zhang <[email protected]>
@kevjumba
Fremove print
421645b 
Signed-off-by: Kevin Zhang <[email protected]>
@kevjumba
Fix lint
07fece5 
Signed-off-by: Kevin Zhang <[email protected]>
@kevjumba
Run build-sphinx
4062031 
Signed-off-by: Kevin Zhang <[email protected]>
kevjumba added 11 commits August 19, 2022 10:02
@kevjumba
Fix
ee30e73 
Signed-off-by: Kevin Zhang <[email protected]>
@kevjumba
Fix
ab17db9 
Signed-off-by: Kevin Zhang <[email protected]>
@kevjumba
Revert
be162f5 
Signed-off-by: Kevin Zhang <[email protected]>
@kevjumba
Fix
f5aa476 
Signed-off-by: Kevin Zhang <[email protected]>
@kevjumba
Fix
4423dfa 
Signed-off-by: Kevin Zhang <[email protected]>
@kevjumba
Fix
5806507 
Signed-off-by: Kevin Zhang <[email protected]>
@kevjumba
Fix lint
7a4d055 
Signed-off-by: Kevin Zhang <[email protected]>
@kevjumba
Fix
78b74b1 
Signed-off-by: Kevin Zhang <[email protected]>
@kevjumba
Fix lint
a9e8119 
Signed-off-by: Kevin Zhang <[email protected]>
@kevjumba
Fix pyarrow
1341e3e 
Signed-off-by: Kevin Zhang <[email protected]>
@kevjumba
Fix lint
3d42093 
Signed-off-by: Kevin Zhang <[email protected]>
@kevjumba
kevjumba force-pushed the azure_provider branch from f998d8b to 3d42093 Compare August 19, 2022 17:11
@adchia
add requirements files
1c591f0 
Signed-off-by: Danny Chiao <[email protected]>
adchia
adchia approved these changes Aug 19, 2022
View reviewed changes

@adchia adchia left a comment

Copy link
Copy Markdown
Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@feast-ci-bot feast-ci-bot added the lgtm label Aug 19, 2022
@feast-ci-bot

feast-ci-bot commented Aug 19, 2022

Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adchia, kevjumba

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [adchia,kevjumba]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@adchia
fix name of docs
b4da607 
Signed-off-by: Danny Chiao <[email protected]>
@feast-ci-bot feast-ci-bot removed the lgtm label Aug 19, 2022
adchia added 4 commits August 19, 2022 15:58
@adchia
fix offline store readme
c3a0423 
Signed-off-by: Danny Chiao <[email protected]>
@adchia
fix offline store readme
576b57e 
Signed-off-by: Danny Chiao <[email protected]>
@adchia
fix
69940ac 
Signed-off-by: Danny Chiao <[email protected]>
@adchia
fix
516ff76 
Signed-off-by: Danny Chiao <[email protected]>
@adchia

adchia commented Aug 19, 2022

Copy link
Copy Markdown
Collaborator

/lgtm
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@feast-ci-bot feast-ci-bot added the lgtm label Aug 19, 2022
@kevjumba kevjumba added ok-to-test and removed ok-to-test labels Aug 19, 2022
@feast-ci-bot
feast-ci-bot merged commit 9f7e557 into feast-dev:master Aug 19, 2022
kevjumba pushed a commit that referenced this pull request Aug 25, 2022
@feast-ci-bot
chore(release): release 0.24.0
c1c71da 
# [0.24.0](v0.23.0...v0.24.0) (2022-08-25)

### Bug Fixes

* Check if on_demand_feature_views is an empty list rather than None for snowflake provider ([#3046](#3046)) ([9b05e65](9b05e65))
* FeatureStore.apply applies BatchFeatureView correctly ([#3098](#3098)) ([41be511](41be511))
* Fix Feast Java inconsistency with int64 serialization vs python ([#3031](#3031)) ([4bba787](4bba787))
* Fix feature service inference logic ([#3089](#3089)) ([4310ed7](4310ed7))
* Fix field mapping logic during feature inference ([#3067](#3067)) ([cdfa761](cdfa761))
* Fix incorrect on demand feature view diffing and improve Java tests ([#3074](#3074)) ([0702310](0702310))
* Fix Java helm charts to work with refactored logic. Fix FTS image ([#3105](#3105)) ([2b493e0](2b493e0))
* Fix on demand feature view output in feast plan + Web UI crash ([#3057](#3057)) ([bfae6ac](bfae6ac))
* Fix release workflow to release 0.24.0 ([#3138](#3138)) ([a69aaae](a69aaae))
* Fix Spark offline store type conversion to arrow ([#3071](#3071)) ([b26566d](b26566d))
* Fixing Web UI, which fails for the SQL registry ([#3028](#3028)) ([64603b6](64603b6))
* Force Snowflake Session to Timezone UTC ([#3083](#3083)) ([9f221e6](9f221e6))
* Make infer dummy entity join key idempotent ([#3115](#3115)) ([1f5b1e0](1f5b1e0))
* More explicit error messages ([#2708](#2708)) ([e4d7afd](e4d7afd))
* Parse inline data sources ([#3036](#3036)) ([c7ba370](c7ba370))
* Prevent overwriting existing file during `persist` ([#3088](#3088)) ([69af21f](69af21f))
* Register BatchFeatureView in feature repos correctly ([#3092](#3092)) ([b8e39ea](b8e39ea))
* Return an empty infra object from sql registry when it doesn't exist ([#3022](#3022)) ([8ba87d1](8ba87d1))
* Teardown tables for Snowflake Materialization testing ([#3106](#3106)) ([0a0c974](0a0c974))
* UI error when saved dataset is present in registry. ([#3124](#3124)) ([83cf753](83cf753))
* Update sql.py ([#3096](#3096)) ([2646a86](2646a86))
* Updated snowflake template ([#3130](#3130)) ([f0594e1](f0594e1))

### Features

* Add authentication option for snowflake connector ([#3039](#3039)) ([74c75f1](74c75f1))
* Add Cassandra/AstraDB online store contribution ([#2873](#2873)) ([feb6cb8](feb6cb8))
* Add Snowflake materialization engine ([#2948](#2948)) ([f3b522b](f3b522b))
* Adding saved dataset capabilities for Postgres  ([#3070](#3070)) ([d3253c3](d3253c3))
* Allow passing repo config path via flag ([#3077](#3077)) ([0d2d951](0d2d951))
* Contrib azure provider with synapse/mssql offline store and Azure registry store ([#3072](#3072)) ([9f7e557](9f7e557))
* Custom Docker image for Bytewax batch materialization ([#3099](#3099)) ([cdd1b07](cdd1b07))
* Feast AWS Athena offline store (again) ([#3044](#3044)) ([989ce08](989ce08))
* Implement spark offline store `offline_write_batch` method ([#3076](#3076)) ([5b0cc87](5b0cc87))
* Initial Bytewax materialization engine ([#2974](#2974)) ([55c61f9](55c61f9))
* Refactor feature server helm charts to allow passing feature_store.yaml in environment variables ([#3113](#3113)) ([85ee789](85ee789))
@bgalvao

bgalvao commented Sep 8, 2022

Copy link
Copy Markdown

Hi, I am wondering if it is possible to use this for a self-hosted MSSQL Server database as an Offline Store?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@amommendes amommendes mentioned this pull request Jan 6, 2023
Fetching historical feature values by passing sql as entity_df #3234
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adchia adchia adchia approved these changes
+1 more reviewer
@Lejboelle Lejboelle Lejboelle left review comments
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@adchia adchia

Labels

approved lgtm ok-to-test size/XXL

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@kevjumba @codecov-commenter @feast-ci-bot @adchia @bgalvao @Lejboelle
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.