GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — fix: FeatureStore.apply applies BatchFeatureView correctly by achals · Pull Request #3098 · feast-dev/feast

Conversation

achals commented Aug 17, 2022

Copy link

Copy Markdown

Member

Signed-off-by: Achal Shah [email protected]

What this PR does / why we need it:

Missed this in #3092 .

Which issue(s) this PR fixes:

Fixes #3082 for realsies

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          fix: FeatureStore.apply applies BatchFeatureView correctly

cea3b32

Signed-off-by: Achal Shah <[email protected]>

achals requested a review from sfc-gh-madkins

August 17, 2022 17:24

feast-ci-bot added approved size/M labels

Aug 17, 2022

felixwang9817 approved these changes

Aug 17, 2022

View reviewed changes

felixwang9817 left a comment

Copy link

Copy Markdown

Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

feast-ci-bot assigned felixwang9817

Aug 17, 2022

feast-ci-bot added the lgtm label

Aug 17, 2022

sfc-gh-madkins approved these changes

Aug 17, 2022

View reviewed changes

sfc-gh-madkins left a comment

Copy link

Copy Markdown

Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on snowflake template.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

feast-ci-bot commented Aug 17, 2022

Copy link

Copy Markdown

Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: achals, felixwang9817, sfc-gh-madkins

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [achals,felixwang9817]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

codecov-commenter commented Aug 17, 2022

Copy link

Copy Markdown

Codecov Report

Merging #3098 (cea3b32) into master (b8e39ea) will increase coverage by 8.78%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #3098      +/-   ##
==========================================
+ Coverage   67.08%   75.86%   +8.78%     
==========================================
  Files         173      207      +34     
  Lines       15117    17037    +1920     
==========================================
+ Hits        10141    12925    +2784     
+ Misses       4976     4112     -864

Flag	Coverage Δ
integrationtests	`66.93% <80.00%> (-0.15%)`	⬇️
unittests	`58.27% <100.00%> (?)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
sdk/python/feast/feast_object.py	`100.00% <100.00%> (ø)`
sdk/python/feast/feature_store.py	`85.39% <100.00%> (+3.64%)`	⬆️
...unit/local_feast_tests/test_local_feature_store.py	`97.90% <100.00%> (+74.09%)`	⬆️
...s/contrib/trino_offline_store/tests/data_source.py	`17.64% <0.00%> (ø)`
...tores/contrib/trino_offline_store/trino_queries.py	`15.05% <0.00%> (ø)`
...b/cassandra_online_store/cassandra_online_store.py	`2.63% <0.00%> (ø)`
...k/python/feast/infra/materialization/lambda/app.py	`26.66% <0.00%> (ø)`
...ine_stores/contrib/cassandra_repo_configuration.py	`100.00% <0.00%> (ø)`
...ffline_stores/contrib/athena_repo_configuration.py	`50.00% <0.00%> (ø)`
sdk/python/feast/transformation_server.py	`40.47% <0.00%> (ø)`
... and 101 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

feast-ci-bot merged commit 41be511 into feast-dev:master

Aug 17, 2022

achals deleted the achal/bfv-registry branch

August 17, 2022 18:52

kevjumba pushed a commit that referenced this pull request

Aug 25, 2022


          chore(release): release 0.24.0

c1c71da

# [0.24.0](v0.23.0...v0.24.0) (2022-08-25)

### Bug Fixes

* Check if on_demand_feature_views is an empty list rather than None for snowflake provider ([#3046](#3046)) ([9b05e65](9b05e65))
* FeatureStore.apply applies BatchFeatureView correctly ([#3098](#3098)) ([41be511](41be511))
* Fix Feast Java inconsistency with int64 serialization vs python ([#3031](#3031)) ([4bba787](4bba787))
* Fix feature service inference logic ([#3089](#3089)) ([4310ed7](4310ed7))
* Fix field mapping logic during feature inference ([#3067](#3067)) ([cdfa761](cdfa761))
* Fix incorrect on demand feature view diffing and improve Java tests ([#3074](#3074)) ([0702310](0702310))
* Fix Java helm charts to work with refactored logic. Fix FTS image ([#3105](#3105)) ([2b493e0](2b493e0))
* Fix on demand feature view output in feast plan + Web UI crash ([#3057](#3057)) ([bfae6ac](bfae6ac))
* Fix release workflow to release 0.24.0 ([#3138](#3138)) ([a69aaae](a69aaae))
* Fix Spark offline store type conversion to arrow ([#3071](#3071)) ([b26566d](b26566d))
* Fixing Web UI, which fails for the SQL registry ([#3028](#3028)) ([64603b6](64603b6))
* Force Snowflake Session to Timezone UTC ([#3083](#3083)) ([9f221e6](9f221e6))
* Make infer dummy entity join key idempotent ([#3115](#3115)) ([1f5b1e0](1f5b1e0))
* More explicit error messages ([#2708](#2708)) ([e4d7afd](e4d7afd))
* Parse inline data sources ([#3036](#3036)) ([c7ba370](c7ba370))
* Prevent overwriting existing file during `persist` ([#3088](#3088)) ([69af21f](69af21f))
* Register BatchFeatureView in feature repos correctly ([#3092](#3092)) ([b8e39ea](b8e39ea))
* Return an empty infra object from sql registry when it doesn't exist ([#3022](#3022)) ([8ba87d1](8ba87d1))
* Teardown tables for Snowflake Materialization testing ([#3106](#3106)) ([0a0c974](0a0c974))
* UI error when saved dataset is present in registry. ([#3124](#3124)) ([83cf753](83cf753))
* Update sql.py ([#3096](#3096)) ([2646a86](2646a86))
* Updated snowflake template ([#3130](#3130)) ([f0594e1](f0594e1))

### Features

* Add authentication option for snowflake connector ([#3039](#3039)) ([74c75f1](74c75f1))
* Add Cassandra/AstraDB online store contribution ([#2873](#2873)) ([feb6cb8](feb6cb8))
* Add Snowflake materialization engine ([#2948](#2948)) ([f3b522b](f3b522b))
* Adding saved dataset capabilities for Postgres  ([#3070](#3070)) ([d3253c3](d3253c3))
* Allow passing repo config path via flag ([#3077](#3077)) ([0d2d951](0d2d951))
* Contrib azure provider with synapse/mssql offline store and Azure registry store ([#3072](#3072)) ([9f7e557](9f7e557))
* Custom Docker image for Bytewax batch materialization ([#3099](#3099)) ([cdd1b07](cdd1b07))
* Feast AWS Athena offline store (again) ([#3044](#3044)) ([989ce08](989ce08))
* Implement spark offline store `offline_write_batch` method ([#3076](#3076)) ([5b0cc87](5b0cc87))
* Initial Bytewax materialization engine ([#2974](#2974)) ([55c61f9](55c61f9))
* Refactor feature server helm charts to allow passing feature_store.yaml in environment variables ([#3113](#3113)) ([85ee789](85ee789))

Reviewers

felixwang9817

felixwang9817 approved these changes

sfc-gh-madkins

sfc-gh-madkins approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

felixwang9817

Labels

approved lgtm size/M

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

"feast apply" does not register a new BatchFeatureView

Uh oh!

There was an error while loading. Please reload this page.

5 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.