GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — feat: Refactor feature server helm charts to allow passing feature_store.yaml in environment variables by adchia · Pull Request #3113 · feast-dev/feast

Conversation

@adchia

@adchia adchia commented Aug 19, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Collaborator

What this PR does / why we need it:
The old python feature server helm chart relied on users to build their own Docker image to bundle in a feature_store.yaml file. This change makes it so users instead pass a base64 encoded version of this as an environment variable (similar to the AWS lambda feature server approach) to hopefully reduce time to production

  • This adds a tutorial on how to run a Python feature server on K8s, hitting Redis
  • This also adds documentation for how to query the feature server in the concepts page for feature retrieval

Which issue(s) this PR fixes:

Fixes #

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
adchia added 4 commits August 19, 2022 14:45
@adchia
feat: Refactor feature server helm charts to allow passing feature_st…
8550c00
…ore.yaml in environment variables

Signed-off-by: Danny Chiao <[email protected]>
@adchia
lint
cc4b168
Signed-off-by: Danny Chiao <[email protected]>
@adchia
lint
9f92541
Signed-off-by: Danny Chiao <[email protected]>
@adchia
add docs
33e7be3
Signed-off-by: Danny Chiao <[email protected]>
@feast-ci-bot feast-ci-bot added approved size/L labels Aug 19, 2022
adchia added 5 commits August 19, 2022 15:03
@adchia
lint
9e3c4f0
Signed-off-by: Danny Chiao <[email protected]>
@adchia
revert bad helm docs
6b04c31
Signed-off-by: Danny Chiao <[email protected]>
@adchia
add to bump files
06b74ba
Signed-off-by: Danny Chiao <[email protected]>
@adchia
add to bump files
95e45f3
Signed-off-by: Danny Chiao <[email protected]>
@adchia
add to release
c3c5104
Signed-off-by: Danny Chiao <[email protected]>
@codecov-commenter

codecov-commenter commented Aug 19, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Codecov Report

Merging #3113 (8d3b548) into master (29f2895) will increase coverage by 8.77%.
The diff coverage is 26.66%.

@@            Coverage Diff             @@
##           master    #3113      +/-   ##
==========================================
+ Coverage   67.86%   76.63%   +8.77%     
==========================================
  Files         176      210      +34     
  Lines       15507    17468    +1961     
==========================================
+ Hits        10524    13387    +2863     
+ Misses       4983     4081     -902     
Flag Coverage Δ
integrationtests 67.67% <26.66%> (-0.20%) ⬇️
unittests 58.19% <26.66%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdk/python/feast/cli.py 38.77% <26.66%> (-0.35%) ⬇️
...on/feast/infra/materialization/snowflake_engine.py 92.70% <0.00%> (-0.53%) ⬇️
...thon/feast/infra/utils/postgres/postgres_config.py 100.00% <0.00%> (ø)
...ffline_stores/contrib/spark_offline_store/spark.py 33.15% <0.00%> (ø)
...ffline_stores/contrib/trino_offline_store/trino.py 8.78% <0.00%> (ø)
...ine_stores/contrib/cassandra_repo_configuration.py 100.00% <0.00%> (ø)
...offline_stores/contrib/spark_repo_configuration.py 100.00% <0.00%> (ø)
...line_stores/contrib/postgres_repo_configuration.py 100.00% <0.00%> (ø)
...s/contrib/trino_offline_store/connectors/upload.py 8.97% <0.00%> (ø)
...stores/contrib/trino_offline_store/trino_source.py 5.37% <0.00%> (ø)
... and 99 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@adchia
fix readme for feast-feature-server
8d3b548
Signed-off-by: Danny Chiao <[email protected]>
kevjumba
kevjumba approved these changes Aug 23, 2022
View reviewed changes

@kevjumba kevjumba left a comment

Copy link
Copy Markdown
Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@feast-ci-bot feast-ci-bot assigned kevjumba Aug 23, 2022
@feast-ci-bot

feast-ci-bot commented Aug 23, 2022

Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adchia, kevjumba

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [adchia,kevjumba]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@feast-ci-bot feast-ci-bot added the lgtm label Aug 23, 2022
@kevjumba

kevjumba commented Aug 23, 2022

Copy link
Copy Markdown
Collaborator

verified that the tutorial works on mac m1!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@feast-ci-bot
feast-ci-bot merged commit 85ee789 into feast-dev:master Aug 23, 2022
kevjumba pushed a commit that referenced this pull request Aug 25, 2022
@feast-ci-bot
chore(release): release 0.24.0
c1c71da
# [0.24.0](v0.23.0...v0.24.0) (2022-08-25)

### Bug Fixes

* Check if on_demand_feature_views is an empty list rather than None for snowflake provider ([#3046](#3046)) ([9b05e65](9b05e65))
* FeatureStore.apply applies BatchFeatureView correctly ([#3098](#3098)) ([41be511](41be511))
* Fix Feast Java inconsistency with int64 serialization vs python ([#3031](#3031)) ([4bba787](4bba787))
* Fix feature service inference logic ([#3089](#3089)) ([4310ed7](4310ed7))
* Fix field mapping logic during feature inference ([#3067](#3067)) ([cdfa761](cdfa761))
* Fix incorrect on demand feature view diffing and improve Java tests ([#3074](#3074)) ([0702310](0702310))
* Fix Java helm charts to work with refactored logic. Fix FTS image ([#3105](#3105)) ([2b493e0](2b493e0))
* Fix on demand feature view output in feast plan + Web UI crash ([#3057](#3057)) ([bfae6ac](bfae6ac))
* Fix release workflow to release 0.24.0 ([#3138](#3138)) ([a69aaae](a69aaae))
* Fix Spark offline store type conversion to arrow ([#3071](#3071)) ([b26566d](b26566d))
* Fixing Web UI, which fails for the SQL registry ([#3028](#3028)) ([64603b6](64603b6))
* Force Snowflake Session to Timezone UTC ([#3083](#3083)) ([9f221e6](9f221e6))
* Make infer dummy entity join key idempotent ([#3115](#3115)) ([1f5b1e0](1f5b1e0))
* More explicit error messages ([#2708](#2708)) ([e4d7afd](e4d7afd))
* Parse inline data sources ([#3036](#3036)) ([c7ba370](c7ba370))
* Prevent overwriting existing file during `persist` ([#3088](#3088)) ([69af21f](69af21f))
* Register BatchFeatureView in feature repos correctly ([#3092](#3092)) ([b8e39ea](b8e39ea))
* Return an empty infra object from sql registry when it doesn't exist ([#3022](#3022)) ([8ba87d1](8ba87d1))
* Teardown tables for Snowflake Materialization testing ([#3106](#3106)) ([0a0c974](0a0c974))
* UI error when saved dataset is present in registry. ([#3124](#3124)) ([83cf753](83cf753))
* Update sql.py ([#3096](#3096)) ([2646a86](2646a86))
* Updated snowflake template ([#3130](#3130)) ([f0594e1](f0594e1))

### Features

* Add authentication option for snowflake connector ([#3039](#3039)) ([74c75f1](74c75f1))
* Add Cassandra/AstraDB online store contribution ([#2873](#2873)) ([feb6cb8](feb6cb8))
* Add Snowflake materialization engine ([#2948](#2948)) ([f3b522b](f3b522b))
* Adding saved dataset capabilities for Postgres  ([#3070](#3070)) ([d3253c3](d3253c3))
* Allow passing repo config path via flag ([#3077](#3077)) ([0d2d951](0d2d951))
* Contrib azure provider with synapse/mssql offline store and Azure registry store ([#3072](#3072)) ([9f7e557](9f7e557))
* Custom Docker image for Bytewax batch materialization ([#3099](#3099)) ([cdd1b07](cdd1b07))
* Feast AWS Athena offline store (again) ([#3044](#3044)) ([989ce08](989ce08))
* Implement spark offline store `offline_write_batch` method ([#3076](#3076)) ([5b0cc87](5b0cc87))
* Initial Bytewax materialization engine ([#2974](#2974)) ([55c61f9](55c61f9))
* Refactor feature server helm charts to allow passing feature_store.yaml in environment variables ([#3113](#3113)) ([85ee789](85ee789))
@adchia
adchia deleted the refactorPythonHelm branch May 9, 2023 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kevjumba kevjumba kevjumba approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@kevjumba kevjumba

Labels

approved lgtm size/L

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@adchia @codecov-commenter @feast-ci-bot @kevjumba
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.