GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — fix: Broken Feature Service Link by nsonntag · Pull Request #3227 · feast-dev/feast

Conversation

nsonntag commented Sep 16, 2022

Copy link

Copy Markdown

Contributor

No description provided.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

nsonntag requested a review from adchia as a code owner

September 16, 2022 16:45

feast-ci-bot added the size/XS label

Sep 16, 2022

adchia approved these changes

Sep 16, 2022

View reviewed changes

adchia left a comment

Copy link

Copy Markdown

Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

feast-ci-bot assigned adchia

Sep 16, 2022

feast-ci-bot commented Sep 16, 2022

Copy link

Copy Markdown

Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adchia, nsonntag

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [adchia]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

feast-ci-bot added lgtm approved labels

Sep 16, 2022

codecov-commenter commented Sep 16, 2022 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Codecov Report

Base: 67.48% // Head: 58.26% // Decreases project coverage by -9.22% ⚠️

Coverage data is based on head (ceb2dd4) compared to base (ae37b20).
Patch has no changes to coverable lines.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #3227      +/-   ##
==========================================
- Coverage   67.48%   58.26%   -9.23%     
==========================================
  Files         179      210      +31     
  Lines       16370    17701    +1331     
==========================================
- Hits        11048    10314     -734     
- Misses       5322     7387    +2065

Flag	Coverage Δ
integrationtests	`?`
unittests	`58.26% <ø> (?)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...sts/integration/registration/test_universal_cli.py	`20.20% <0.00%> (-79.80%)`	⬇️
...ts/integration/offline_store/test_offline_write.py	`26.08% <0.00%> (-73.92%)`	⬇️
...fline_store/test_universal_historical_retrieval.py	`28.75% <0.00%> (-71.25%)`	⬇️
...ests/integration/e2e/test_python_feature_server.py	`29.50% <0.00%> (-70.50%)`	⬇️
...dk/python/tests/integration/e2e/test_validation.py	`27.55% <0.00%> (-69.30%)`	⬇️
...s/integration/registration/test_universal_types.py	`32.25% <0.00%> (-67.75%)`	⬇️
sdk/python/feast/infra/online_stores/redis.py	`28.39% <0.00%> (-66.67%)`	⬇️
sdk/python/tests/integration/e2e/test_usage_e2e.py	`33.87% <0.00%> (-66.13%)`	⬇️
sdk/python/tests/data/data_creator.py	`34.78% <0.00%> (-65.22%)`	⬇️
...n/tests/integration/registration/test_inference.py	`35.71% <0.00%> (-64.29%)`	⬇️
... and 163 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

nsonntag commented Sep 16, 2022

Copy link

Copy Markdown

Contributor Author

@adchia I followed the instructions here to fix sign off. But getting a "ERROR: Permission to feast-dev/feast.git denied" when pushing changes to overwrite the branch. Any ideas?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

achals commented Sep 16, 2022

Copy link

Copy Markdown

Member

@adchia I followed the instructions here to fix sign off. But getting a "ERROR: Permission to feast-dev/feast.git denied" when pushing changes to overwrite the branch. Any ideas?

@nsonntag it sounds you were trying to push to a branch in the feast repo instead of the patch-1 branch in your fork (https://github.com/nsonntag/feast/tree/patch-1)

nsonntag reacted with thumbs up emoji

All reactions

👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

feast-ci-bot removed the lgtm label

Sep 16, 2022

nsonntag closed this

Sep 16, 2022

nsonntag reopened this

Sep 16, 2022

nsonntag commented Sep 16, 2022

Copy link

Copy Markdown

Contributor Author

@adchia @achals thanks I got the sign off issue fixed. Looks like the 'lgtm' label was removed. Would one of you be able to add it back?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

achals commented Sep 16, 2022

Copy link

Copy Markdown

Member

/lgtm

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

feast-ci-bot assigned achals

Sep 16, 2022

feast-ci-bot added lgtm and removed lgtm labels

Sep 16, 2022


          Fixing Broken Link

fb58e8d

Signed-off-by: nsonntag <[email protected]>

nsonntag commented Sep 17, 2022

Copy link

Copy Markdown

Contributor Author

@adchia @achals thanks for the patience on this. I was having a few different issues with sign off and signing the commits. Looks like I have 2 workflows waiting for approval. Only the last one needs to run. I should finally have this all fixed. Also looks like the 'lgtm' label was dropped again.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

adchia commented Sep 17, 2022

Copy link

Copy Markdown

Collaborator

/lgtm

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

feast-ci-bot added the lgtm label

Sep 17, 2022

feast-ci-bot merged commit e117082 into feast-dev:master

Sep 17, 2022

nsonntag deleted the patch-1 branch

September 17, 2022 01:57

felixwang9817 pushed a commit that referenced this pull request

Sep 20, 2022


          chore(release): release 0.25.0

769c318

# [0.25.0](v0.24.0...v0.25.0) (2022-09-20)

### Bug Fixes

* Broken Feature Service Link ([#3227](#3227)) ([e117082](e117082))
* Feature-server image is missing mysql dependency for mysql registry ([#3223](#3223)) ([ae37b20](ae37b20))
* Fix handling of TTL in Go server ([#3232](#3232)) ([f020630](f020630))
* Fix materialization when running on Spark cluster. ([#3166](#3166)) ([175fd25](175fd25))
* Fix push API to respect feature view's already inferred entity types ([#3172](#3172)) ([7c50ab5](7c50ab5))
* Fix release workflow ([#3144](#3144)) ([20a9dd9](20a9dd9))
* Fix Shopify timestamp bug and add warnings to help with debugging entity registration ([#3191](#3191)) ([de75971](de75971))
* Handle complex Spark data types in SparkSource ([#3154](#3154)) ([5ddb83b](5ddb83b))
* Local staging location provision ([#3195](#3195)) ([cdf0faf](cdf0faf))
* Remove bad snowflake offline store method ([#3204](#3204)) ([dfdd0ca](dfdd0ca))
* Remove opening file object when validating S3 parquet source ([#3217](#3217)) ([a906018](a906018))
* Snowflake config file search error ([#3193](#3193)) ([189afb9](189afb9))
* Update Snowflake Online docs ([#3206](#3206)) ([7bc1dff](7bc1dff))

### Features

* Add `to_remote_storage` functionality to `SparkOfflineStore` ([#3175](#3175)) ([2107ce2](2107ce2))
* Add ability to give boto extra args for registry config ([#3219](#3219)) ([fbc6a2c](fbc6a2c))
* Add health endpoint to py server ([#3202](#3202)) ([43222f2](43222f2))
* Add snowflake support for date & number with scale ([#3148](#3148)) ([50e8755](50e8755))
* Add tag kwarg to set Snowflake online store table path ([#3176](#3176)) ([39aeea3](39aeea3))
* Add workgroup to athena offline store config ([#3139](#3139)) ([a752211](a752211))
* Implement spark materialization engine ([#3184](#3184)) ([a59c33a](a59c33a))

Reviewers

adchia

adchia approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

achals

adchia

Labels

approved lgtm size/XS

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

nsonntag commented Sep 16, 2022

Uh oh!

adchia left a comment

Choose a reason for hiding this comment

Uh oh!

feast-ci-bot commented Sep 16, 2022

Uh oh!

codecov-commenter commented Sep 16, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

nsonntag commented Sep 16, 2022

Uh oh!

achals commented Sep 16, 2022

Uh oh!

nsonntag commented Sep 16, 2022

Uh oh!

achals commented Sep 16, 2022

Uh oh!

nsonntag commented Sep 17, 2022

Uh oh!

adchia commented Sep 17, 2022

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

codecov-commenter commented Sep 16, 2022 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.