GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-101317: Add ssl_shutdown_timeout parameter for StreamWriter.start_tls() by beavailable · Pull Request #101335 · python/cpython

Conversation

@beavailable

@beavailable beavailable commented Jan 26, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor
  • Issue: Please add the ssl_shutdown_timeout parameter for StreamWriter.start_tls() in asyncio #101317

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@beavailable
gh-101317: Add ssl_shutdown_timeout parameter for StreamWriter.start_…
ad0dbba 
…tls()
@beavailable
beavailable requested review from 1st1, asvetlov, gvanrossum and kumaraditya303 as code owners January 26, 2023 00:58
@bedevere-bot bedevere-bot added the awaiting review label Jan 26, 2023
@bedevere-bot bedevere-bot mentioned this pull request Jan 26, 2023
Please add the ssl_shutdown_timeout parameter for StreamWriter.start_tls() in asyncio #101317
Closed
@bedevere-bot

bedevere-bot commented Jan 26, 2023

Copy link
Copy Markdown

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ghost

ghost commented Jan 26, 2023 •
edited by ghost
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.
CLA signed
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@blurb-it
📜🤖 Added by blurb_it.
44dcb5a
kumaraditya303
kumaraditya303 requested changes Jan 31, 2023
View reviewed changes

@kumaraditya303 kumaraditya303 left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to add this param to docs with a version changed directive.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot added awaiting changes and removed awaiting review labels Jan 31, 2023
@bedevere-bot

bedevere-bot commented Jan 31, 2023

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@beavailable
Add Docs
19b6e9a
@beavailable

beavailable commented Feb 1, 2023

Copy link
Copy Markdown
Contributor Author

I have made the requested changes; please review again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot added awaiting change review and removed awaiting changes labels Feb 1, 2023
@bedevere-bot

bedevere-bot commented Feb 1, 2023

Copy link
Copy Markdown

Thanks for making the requested changes!

@kumaraditya303: please review the changes made to this pull request.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot
bedevere-bot requested a review from kumaraditya303 February 1, 2023 01:38
kumaraditya303
kumaraditya303 reviewed Feb 1, 2023
View reviewed changes
Comment thread Misc/NEWS.d/next/Library/2023-01-26-01-25-56.gh-issue-101317.vWaS1x.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
kumaraditya303 added 2 commits February 1, 2023 15:58
@kumaraditya303
Update Misc/NEWS.d/next/Library/2023-01-26-01-25-56.gh-issue-101317.v…
a892d51 
…WaS1x.rst
@kumaraditya303
Merge branch 'main' into fix-issue-101317
218a421
kumaraditya303
kumaraditya303 reviewed Feb 1, 2023
View reviewed changes
Comment thread Misc/NEWS.d/next/Library/2023-01-26-01-25-56.gh-issue-101317.vWaS1x.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
@kumaraditya303
Update Misc/NEWS.d/next/Library/2023-01-26-01-25-56.gh-issue-101317.v…
e5da8f0 
…WaS1x.rst
@kumaraditya303 kumaraditya303 linked an issue Feb 1, 2023 that may be closed by this pull request
Please add the ssl_shutdown_timeout parameter for StreamWriter.start_tls() in asyncio #101317
Closed
kumaraditya303
kumaraditya303 approved these changes Feb 1, 2023
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting change review labels Feb 1, 2023
@kumaraditya303 kumaraditya303 self-assigned this Feb 1, 2023
@kumaraditya303
kumaraditya303 merged commit cc407b9 into python:main Feb 1, 2023
@bedevere-bot bedevere-bot removed the awaiting merge label Feb 1, 2023
@kumaraditya303

kumaraditya303 commented Feb 1, 2023

Copy link
Copy Markdown
Contributor

Thanks.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@beavailable
beavailable deleted the fix-issue-101317 branch February 1, 2023 11:05
carljm added a commit to carljm/cpython that referenced this pull request Feb 1, 2023
@carljm
Merge branch 'main' into inlinecomp2
8b76051 
* main:
  pythongh-98831: rewrite PUSH_EXC_INFO and conditional jumps in the instruction definition DSL (python#101481)
  pythongh-98831: Modernize the LOAD_ATTR family (python#101488)
  pythongh-101498 : Fix asyncio.Timeout example in docs (python#101499)
  pythongh-101454: fix documentation for END_ASYNC_FOR (python#101455)
  pythongh-101277: Isolate itertools, add group and _grouper types to module state (python#101302)
  pythongh-101317: Add `ssl_shutdown_timeout` parameter for `asyncio.StreamWriter.start_tls` (python#101335)
  datetime.rst: fix combine() signature (python#101490)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kumaraditya303 kumaraditya303 kumaraditya303 approved these changes
@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner
@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner
@gvanrossum gvanrossum Awaiting requested review from gvanrossum

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@kumaraditya303 kumaraditya303

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Please add the ssl_shutdown_timeout parameter for StreamWriter.start_tls() in asyncio

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@beavailable @bedevere-bot @kumaraditya303
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.