GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — gh-101454: fix documentation for END_ASYNC_FOR by iritkatriel · Pull Request #101455 · python/cpython

Conversation

iritkatriel commented Jan 31, 2023 •

edited by bedevere-bot

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Member

Fixes #101454.

It currently mentions 3-args for the exception, which is out of date, and says it re-raises StopIteration (which is what it does not reraise).

Issue: Documentation of END_ASYNC_FOR is out of date and incorrect #101454

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          pythongh-101454: fix documentation for END_ASYNC_FOR

d84ced2

iritkatriel requested a review from markshannon

January 31, 2023 11:23

bedevere-bot added the awaiting core review label

Jan 31, 2023

bedevere-bot mentioned this pull request

Jan 31, 2023

Documentation of END_ASYNC_FOR is out of date and incorrect #101454

Closed

bedevere-bot added docs

Documentation in the Doc dir

skip news labels

Jan 31, 2023

iritkatriel added needs backport to 3.11

only security fixes

topic-asyncio skip news and removed skip news labels

Jan 31, 2023

markshannon approved these changes

Feb 1, 2023

View reviewed changes

bedevere-bot added awaiting merge and removed awaiting core review labels

Feb 1, 2023

iritkatriel merged commit 62251c3 into python:main

Feb 1, 2023

bedevere-bot removed the awaiting merge label

Feb 1, 2023

miss-islington commented Feb 1, 2023

Copy link

Copy Markdown

Contributor

Thanks @iritkatriel for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

miss-islington commented Feb 1, 2023

Copy link

Copy Markdown

Contributor

Sorry, @iritkatriel, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 62251c3da06eb4662502295697f39730565b1717 3.11

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

miss-islington assigned iritkatriel

Feb 1, 2023

iritkatriel mentioned this pull request

Feb 1, 2023

[3.11] gh-101454: fix documentation for END_ASYNC_FOR (#101455) #101493

Merged

bedevere-bot commented Feb 1, 2023

Copy link

Copy Markdown

GH-101493 is a backport of this pull request to the 3.11 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-bot removed the needs backport to 3.11 only security fixes label

Feb 1, 2023

iritkatriel added a commit to iritkatriel/cpython that referenced this pull request

Feb 1, 2023


          pythongh-101454: fix documentation for END_ASYNC_FOR (python#101455)

21d2735

(cherry picked from commit 62251c3)

iritkatriel added a commit that referenced this pull request

Feb 1, 2023


          [3.11] gh-101454: fix documentation for END_ASYNC_FOR (#101455) (#101493

c796d34

)

gh-101454: fix documentation for END_ASYNC_FOR (#101455)

(cherry picked from commit 62251c3)

carljm added a commit to carljm/cpython that referenced this pull request

Feb 1, 2023


          Merge branch 'main' into inlinecomp2

8b76051

* main:
  pythongh-98831: rewrite PUSH_EXC_INFO and conditional jumps in the instruction definition DSL (python#101481)
  pythongh-98831: Modernize the LOAD_ATTR family (python#101488)
  pythongh-101498 : Fix asyncio.Timeout example in docs (python#101499)
  pythongh-101454: fix documentation for END_ASYNC_FOR (python#101455)
  pythongh-101277: Isolate itertools, add group and _grouper types to module state (python#101302)
  pythongh-101317: Add `ssl_shutdown_timeout` parameter for `asyncio.StreamWriter.start_tls` (python#101335)
  datetime.rst: fix combine() signature (python#101490)

iritkatriel deleted the async-for branch

April 3, 2023 17:47

Reviewers

markshannon

markshannon approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

iritkatriel

Labels

docs

Documentation in the Doc dir

skip news topic-asyncio

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Documentation of END_ASYNC_FOR is out of date and incorrect

Uh oh!

There was an error while loading. Please reload this page.

4 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

iritkatriel commented Jan 31, 2023 • edited by bedevere-bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

miss-islington commented Feb 1, 2023

Uh oh!

miss-islington commented Feb 1, 2023

Uh oh!

bedevere-bot commented Feb 1, 2023

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

iritkatriel commented Jan 31, 2023 •

edited by bedevere-bot

Loading

Uh oh!

There was an error while loading. Please reload this page.