GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-98831: rewrite PUSH_EXC_INFO and conditional jumps in the instruction definition DSL by iritkatriel · Pull Request #101481 · python/cpython

Conversation

@iritkatriel

@iritkatriel iritkatriel commented Feb 1, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: Generate the interpreter #98831

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
iritkatriel added 3 commits January 31, 2023 23:58
@iritkatriel
POP_JUMP_IF_NOT_NONE, POP_JUMP_IF_NONE
cdfbacb
@iritkatriel
POP_JUMP_IF_FALSE, POP_JUMP_IF_TRUE
121bc55
@iritkatriel
PUSH_EXC_INFO
a052d10
@bedevere-bot bedevere-bot added the awaiting core review label Feb 1, 2023
@bedevere-bot bedevere-bot mentioned this pull request Feb 1, 2023
Generate the interpreter #98831
Closed
@iritkatriel iritkatriel added skip news interpreter-core (Objects, Python, Grammar, and Parser dirs) labels Feb 1, 2023
@iritkatriel
iritkatriel requested a review from gvanrossum February 1, 2023 00:36
@iritkatriel iritkatriel added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Feb 1, 2023
@bedevere-bot

bedevere-bot commented Feb 1, 2023

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @iritkatriel for commit a052d10 🤖

If you want to schedule another build, you need to add the :hammer: test-with-buildbots label again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Feb 1, 2023
iritkatriel added 3 commits February 1, 2023 12:15
@iritkatriel
Merge remote-tracking branch 'upstream/main' into jumps
9e5b991
@iritkatriel
JUMP_IF_FALSE_OR_POP
253ec9b
@iritkatriel
JUMP_IF_TRUE_OR_POP
78e20c4
@iritkatriel
iritkatriel requested a review from markshannon as a code owner February 1, 2023 15:52
@iritkatriel iritkatriel changed the title gh-98831: rewrite PUSH_EXC_INFO and POP_JUMP_IF_* in the instruction definition DSL gh-98831: rewrite PUSH_EXC_INFO and conditional jumps in the instruction definition DSL Feb 1, 2023
@iritkatriel iritkatriel added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Feb 1, 2023
@bedevere-bot

bedevere-bot commented Feb 1, 2023

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @iritkatriel for commit 78e20c4 🤖

If you want to schedule another build, you need to add the :hammer: test-with-buildbots label again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Feb 1, 2023
gvanrossum
gvanrossum approved these changes Feb 1, 2023
View reviewed changes
Comment thread Python/bytecodes.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Feb 1, 2023
iritkatriel and others added 4 commits February 1, 2023 18:58
@iritkatriel @gvanrossum
use Py_NewRef for new_exc.
9b2fb90 
Co-authored-by: Guido van Rossum <[email protected]>
@iritkatriel
remove obsolete comment
09b39b0
@iritkatriel
Merge branch 'main' into jumps
ff8521d
@iritkatriel
make regen
7a932bc
gvanrossum
gvanrossum approved these changes Feb 1, 2023
View reviewed changes
@iritkatriel
iritkatriel merged commit b91b42d into python:main Feb 1, 2023
@bedevere-bot bedevere-bot removed the awaiting merge label Feb 1, 2023
carljm added a commit to carljm/cpython that referenced this pull request Feb 1, 2023
@carljm
Merge branch 'main' into inlinecomp2
8b76051 
* main:
  pythongh-98831: rewrite PUSH_EXC_INFO and conditional jumps in the instruction definition DSL (python#101481)
  pythongh-98831: Modernize the LOAD_ATTR family (python#101488)
  pythongh-101498 : Fix asyncio.Timeout example in docs (python#101499)
  pythongh-101454: fix documentation for END_ASYNC_FOR (python#101455)
  pythongh-101277: Isolate itertools, add group and _grouper types to module state (python#101302)
  pythongh-101317: Add `ssl_shutdown_timeout` parameter for `asyncio.StreamWriter.start_tls` (python#101335)
  datetime.rst: fix combine() signature (python#101490)
@iritkatriel
iritkatriel deleted the jumps branch April 3, 2023 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gvanrossum gvanrossum gvanrossum approved these changes
@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

interpreter-core (Objects, Python, Grammar, and Parser dirs) skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@iritkatriel @bedevere-bot @gvanrossum
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.