GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-98831: Modernize the LOAD_ATTR family by gvanrossum · Pull Request #101488 · python/cpython

Conversation

@gvanrossum

@gvanrossum gvanrossum commented Feb 1, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: Generate the interpreter #98831

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot added the awaiting core review label Feb 1, 2023
@bedevere-bot bedevere-bot mentioned this pull request Feb 1, 2023
Generate the interpreter #98831
Closed
@gvanrossum gvanrossum added skip news 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section labels Feb 1, 2023
@bedevere-bot

bedevere-bot commented Feb 1, 2023

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @gvanrossum for commit e99ba6d 🤖

If you want to schedule another build, you need to add the :hammer: test-with-refleak-buildbots label again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section label Feb 1, 2023
@gvanrossum gvanrossum added the 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section label Feb 1, 2023
@bedevere-bot

bedevere-bot commented Feb 1, 2023

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @gvanrossum for commit 02b8183 🤖

If you want to schedule another build, you need to add the :hammer: test-with-refleak-buildbots label again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section label Feb 1, 2023
gvanrossum added 12 commits February 1, 2023 10:15
@gvanrossum
Modernize LOAD_ATTR_INSTANCE_VALUE
2c79dbb
@gvanrossum
Modernize LOAD_ATTR_MODULE
0915f2d
@gvanrossum
Modernize LOAD_ATTR_WITH_HINT
f24eb1d
@gvanrossum
Modernize LOAD_ATTR_SLOT
2a417e9
@gvanrossum
Reorder family to correspond to definition order
fb0a638
@gvanrossum
Add cache size symbols for most families
26acc63
@gvanrossum
Modernize LOAD_ATTR_CLASS
f0bd9ef
@gvanrossum
Modernize LOAD_ATTR_PROPERTY
41a86d6
@gvanrossum
Modernize LOAD_ATTR_GETATTRIBUTE_OVERRIDDEN
d443753
@gvanrossum
Modernize LOAD_ATTR_METHOD_WITH_VALUES
f675fcc
@gvanrossum
Modernize LOAD_ATTR_METHOD_NO_DICT
ba7ec51
@gvanrossum
Modernize LOAD_ATTR_METHOD_LAZY_DICT
ab74331 
This concludes the LOAD_ATTR family.
@gvanrossum
gvanrossum marked this pull request as ready for review February 1, 2023 18:15
@gvanrossum
gvanrossum force-pushed the load-attr-family branch from 02b8183 to ab74331 Compare February 1, 2023 18:15
@gvanrossum
gvanrossum requested a review from iritkatriel February 1, 2023 18:15
@gvanrossum

gvanrossum commented Feb 1, 2023

Copy link
Copy Markdown
Member Author

(I ran the leak tests before rebasing on the latest main, and they passed, I see no need to re-run them.)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
iritkatriel
iritkatriel approved these changes Feb 1, 2023
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Feb 1, 2023
@gvanrossum
gvanrossum merged commit 7840ff3 into python:main Feb 1, 2023
@bedevere-bot bedevere-bot removed the awaiting merge label Feb 1, 2023
@gvanrossum
gvanrossum deleted the load-attr-family branch February 1, 2023 18:56
carljm added a commit to carljm/cpython that referenced this pull request Feb 1, 2023
@carljm
Merge branch 'main' into inlinecomp2
8b76051 
* main:
  pythongh-98831: rewrite PUSH_EXC_INFO and conditional jumps in the instruction definition DSL (python#101481)
  pythongh-98831: Modernize the LOAD_ATTR family (python#101488)
  pythongh-101498 : Fix asyncio.Timeout example in docs (python#101499)
  pythongh-101454: fix documentation for END_ASYNC_FOR (python#101455)
  pythongh-101277: Isolate itertools, add group and _grouper types to module state (python#101302)
  pythongh-101317: Add `ssl_shutdown_timeout` parameter for `asyncio.StreamWriter.start_tls` (python#101335)
  datetime.rst: fix combine() signature (python#101490)
@gvanrossum gvanrossum mentioned this pull request Feb 5, 2023
GH-100288: Specialize class attribute loads #101379
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iritkatriel iritkatriel iritkatriel approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@gvanrossum @bedevere-bot @iritkatriel
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.