GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-101498 : Updated Doc/library/asyncio-task.rst#timeout by workingpayload · Pull Request #101499 · python/cpython

Conversation

@workingpayload

@workingpayload workingpayload commented Feb 1, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor
  • Issue: Improper call to asyncio.Timeout.expired #101498

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@workingpayload
gh-101498 : Updated Doc/library/asyncio-task.rst#timeout
9693998
@workingpayload
workingpayload requested review from 1st1, asvetlov, gvanrossum and kumaraditya303 as code owners February 1, 2023 17:16
@bedevere-bot bedevere-bot added the awaiting review label Feb 1, 2023
@bedevere-bot bedevere-bot mentioned this pull request Feb 1, 2023
Improper call to asyncio.Timeout.expired #101498
Closed
@bedevere-bot bedevere-bot added docs Documentation in the Doc dir skip news labels Feb 1, 2023
gvanrossum
gvanrossum approved these changes Feb 1, 2023
View reviewed changes

@gvanrossum gvanrossum left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, good catch!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
workingpayload reacted with heart emoji
All reactions
  • ❤️ 1 reaction
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Feb 1, 2023
@gvanrossum gvanrossum added the needs backport to 3.11 only security fixes label Feb 1, 2023
@gvanrossum
gvanrossum merged commit 95fb0e0 into python:main Feb 1, 2023
@miss-islington

miss-islington commented Feb 1, 2023

Copy link
Copy Markdown
Contributor

Thanks @workingpayload for the PR, and @gvanrossum for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting merge label Feb 1, 2023
@miss-islington

miss-islington commented Feb 1, 2023

Copy link
Copy Markdown
Contributor

Sorry @workingpayload and @gvanrossum, I had trouble checking out the 3.11 backport branch.
Please retry by removing and re-adding the "needs backport to 3.11" label.
Alternatively, you can backport using cherry_picker on the command line.
cherry_picker 95fb0e02582b5673eff49694eb0dce1d7df52301 3.11
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington miss-islington assigned gvanrossum Feb 1, 2023
@gvanrossum gvanrossum added needs backport to 3.11 only security fixes and removed needs backport to 3.11 only security fixes labels Feb 1, 2023
@miss-islington

miss-islington commented Feb 1, 2023

Copy link
Copy Markdown
Contributor

Thanks @workingpayload for the PR, and @gvanrossum for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot

bedevere-bot commented Feb 1, 2023

Copy link
Copy Markdown

GH-101501 is a backport of this pull request to the 3.11 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Feb 1, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 1, 2023
@workingpayload @miss-islington
pythongh-101498 : Fix asyncio.Timeout example in docs (pythonGH-101499)
1dd037e 
Doc/library/asyncio-task.rstGH-timeout
(cherry picked from commit 95fb0e0)

Co-authored-by: Raj <[email protected]>
miss-islington added a commit that referenced this pull request Feb 1, 2023
@miss-islington @workingpayload
gh-101498 : Fix asyncio.Timeout example in docs (GH-101499)
89442e1 
Doc/library/asyncio-task.rstGH-timeout
(cherry picked from commit 95fb0e0)

Co-authored-by: Raj <[email protected]>
carljm added a commit to carljm/cpython that referenced this pull request Feb 1, 2023
@carljm
Merge branch 'main' into inlinecomp2
8b76051 
* main:
  pythongh-98831: rewrite PUSH_EXC_INFO and conditional jumps in the instruction definition DSL (python#101481)
  pythongh-98831: Modernize the LOAD_ATTR family (python#101488)
  pythongh-101498 : Fix asyncio.Timeout example in docs (python#101499)
  pythongh-101454: fix documentation for END_ASYNC_FOR (python#101455)
  pythongh-101277: Isolate itertools, add group and _grouper types to module state (python#101302)
  pythongh-101317: Add `ssl_shutdown_timeout` parameter for `asyncio.StreamWriter.start_tls` (python#101335)
  datetime.rst: fix combine() signature (python#101490)
@workingpayload
workingpayload deleted the workingpayload/issue101498 branch February 2, 2023 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gvanrossum gvanrossum gvanrossum approved these changes
@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner
@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner
@kumaraditya303 kumaraditya303 Awaiting requested review from kumaraditya303 kumaraditya303 is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@gvanrossum gvanrossum

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@workingpayload @miss-islington @bedevere-bot @gvanrossum
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.