GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — Add JOBS parameter to docs Makefile by christopheNan · Pull Request #101395 · python/cpython

Conversation

christopheNan commented Jan 28, 2023

Copy link

Copy Markdown

Contributor

separate parameter JOBS in order to be able to specify it in command line (used by translators who build documentation in their language)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          Documentation Makefile

0734d36

separate parameter JOBS in order to be able to specify it in command line
(used by translators who build documentation in their language)

related to https://git.afpy.org/AFPy/python-docs-fr/pulls/23

bedevere-bot added the awaiting review label

Jan 28, 2023

christopheNan commented Jan 28, 2023

Copy link

Copy Markdown

Contributor Author

Would be nice to backport to 3.11

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

hugovk added skip issue skip news labels

Jan 29, 2023

hugovk commented Jan 29, 2023 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Member

Sounds reasonable. Do translators want to set it to some higher or lower value? Does auto not work for them?

Please could you move JOBS in between BLURB and PAPER?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

hugovk added needs backport to 3.10 needs backport to 3.11 only security fixes labels

Jan 29, 2023

hauntsaninja changed the title ~~Documentation Makefile adjustement~~ Documentation Makefile adjustment

Jan 29, 2023

christopheNan commented Jan 30, 2023

Copy link

Copy Markdown

Contributor Author

Sounds reasonable. Do translators want to set it to some higher or lower value? Does auto not work for them?

'auto' is good as a default value. As far as I am concerned, it happens that I lower the value (to 1). I ask for this modification as it is transparent for default usage of the Makefile.

hugovk reacted with thumbs up emoji

All reactions

👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.


          move the JOBS var to its alphabetical order place

cd406bd

hugovk approved these changes

Jan 31, 2023

View reviewed changes

hugovk left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

bedevere-bot added awaiting merge and removed awaiting review labels

Jan 31, 2023

hugovk changed the title ~~Documentation Makefile adjustment~~ Add JOBS parameter to docs Makefile

Jan 31, 2023

hugovk merged commit 1a62ae8 into python:main

Jan 31, 2023

bedevere-bot removed the awaiting merge label

Jan 31, 2023

miss-islington commented Jan 31, 2023

Copy link

Copy Markdown

Contributor

Thanks @christopheNan for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-bot commented Jan 31, 2023

Copy link

Copy Markdown

GH-101459 is a backport of this pull request to the 3.11 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-bot removed the needs backport to 3.11 only security fixes label

Jan 31, 2023

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Jan 31, 2023


          Add JOBS parameter to docs Makefile (pythonGH-101395)

21d7b13

(cherry picked from commit 1a62ae8)

Co-authored-by: Christophe Nanteuil <[email protected]>

bedevere-bot commented Jan 31, 2023

Copy link

Copy Markdown

GH-101460 is a backport of this pull request to the 3.10 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-bot removed the needs backport to 3.10 label

Jan 31, 2023

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Jan 31, 2023


          Add JOBS parameter to docs Makefile (pythonGH-101395)

a961d26

(cherry picked from commit 1a62ae8)

Co-authored-by: Christophe Nanteuil <[email protected]>

miss-islington added a commit that referenced this pull request

Jan 31, 2023


          Add JOBS parameter to docs Makefile (GH-101395)

71db9c9

(cherry picked from commit 1a62ae8)

Co-authored-by: Christophe Nanteuil <[email protected]>

miss-islington added a commit that referenced this pull request

Jan 31, 2023


          Add JOBS parameter to docs Makefile (GH-101395)

43af2db

(cherry picked from commit 1a62ae8)

Co-authored-by: Christophe Nanteuil <[email protected]>

mdboom pushed a commit to mdboom/cpython that referenced this pull request

Jan 31, 2023


          Add JOBS parameter to docs Makefile (python#101395)

87ea456

carljm added a commit to carljm/cpython that referenced this pull request

Jan 31, 2023


          Merge branch 'main' into inlinecomp2

ed3209b

* main:
  pythongh-101440: fix json snippet error in logging-cookbook.rst (python#101439)
  pythongh-99276 - Updated Doc/faq/general.rst (python#101396)
  Add JOBS parameter to docs Makefile (python#101395)
  pythongh-98831: rewrite GET_LEN, GET_ITER, BEFORE_WITH and a few simple opcodes in the instruction definition DSL (python#101443)
  pythongh-77607: Improve accuracy of os.path.join docs (python#101406)
  Fixes typo in asyncio.TaskGroup context manager code example (python#101449)
  pythongh-98831: Clean up and add cache size static_assert to macro (python#101442)
  pythongh-99955: use SUCCESS/ERROR return values in optimizer and assembler. Use RETURN_IF_ERROR where appropriate. Fix a couple of bugs. (python#101412)

egeakman added a commit to python/python-docs-tr that referenced this pull request

Feb 4, 2023


          Update Makefile

ae70aaa

python/cpython#101395

egeakman mentioned this pull request

Feb 4, 2023

Update Makefile python/python-docs-tr#110

Merged

Reviewers

hugovk

hugovk approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

christopheNan commented Jan 28, 2023

Uh oh!

christopheNan commented Jan 28, 2023

Uh oh!

hugovk commented Jan 29, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

christopheNan commented Jan 30, 2023

Uh oh!

hugovk left a comment

Choose a reason for hiding this comment

Uh oh!

miss-islington commented Jan 31, 2023

Uh oh!

bedevere-bot commented Jan 31, 2023

Uh oh!

bedevere-bot commented Jan 31, 2023

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

hugovk commented Jan 29, 2023 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.