GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fixes typo in asyncio.TaskGroup context manager code example by bcla22 · Pull Request #101449 · python/cpython

Conversation

@bcla22

@bcla22 bcla22 commented Jan 31, 2023

Copy link
Copy Markdown
Contributor

In the docs, an example using an asyncio.TaskGroup context manager to create two tasks and execute them concurrently has a comment which reads "The wait is implicit when the context manager exits.". Likely this is meant to read "The await is implicit when the context manager exits".

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Ben Clausi
Fix typo in asyncio.TaskGroup context manager code example
be63ce0
@bcla22
bcla22 requested review from 1st1, asvetlov, gvanrossum and kumaraditya303 as code owners January 31, 2023 04:00
@bedevere-bot bedevere-bot added awaiting review docs Documentation in the Doc dir skip news labels Jan 31, 2023
@ghost

ghost commented Jan 31, 2023 •
edited by ghost
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.
CLA signed
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
gvanrossum
gvanrossum approved these changes Jan 31, 2023
View reviewed changes

@gvanrossum gvanrossum left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, and this is sufficiently semantically subtle that it is worth fixing. Thanks!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bcla22 reacted with laugh emoji
All reactions
  • 😄 1 reaction
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Jan 31, 2023
@gvanrossum gvanrossum added skip issue needs backport to 3.11 only security fixes labels Jan 31, 2023
@gvanrossum
gvanrossum merged commit ef09bf6 into python:main Jan 31, 2023
@miss-islington

miss-islington commented Jan 31, 2023

Copy link
Copy Markdown
Contributor

Thanks @bcla22 for the PR, and @gvanrossum for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖
bcla22 reacted with rocket emoji
All reactions
  • 🚀 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting merge label Jan 31, 2023
@bedevere-bot

bedevere-bot commented Jan 31, 2023

Copy link
Copy Markdown

GH-101450 is a backport of this pull request to the 3.11 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Jan 31, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 31, 2023
@bcla22 @miss-islington
Fixes typo in asyncio.TaskGroup context manager code example (pythonG…
4dcd1e9 
…H-101449)

(cherry picked from commit ef09bf6)

Co-authored-by: Ben <[email protected]>
miss-islington added a commit that referenced this pull request Jan 31, 2023
@miss-islington @bcla22
Fixes typo in asyncio.TaskGroup context manager code example (GH-101449)
6a94f4c 
(cherry picked from commit ef09bf6)

Co-authored-by: Ben <[email protected]>
mdboom pushed a commit to mdboom/cpython that referenced this pull request Jan 31, 2023
@bcla22 @mdboom
Fixes typo in asyncio.TaskGroup context manager code example (python#…
e5ce461 
…101449)
carljm added a commit to carljm/cpython that referenced this pull request Jan 31, 2023
@carljm
Merge branch 'main' into inlinecomp2
ed3209b 
* main:
  pythongh-101440: fix json snippet error in logging-cookbook.rst (python#101439)
  pythongh-99276 - Updated Doc/faq/general.rst (python#101396)
  Add JOBS parameter to docs Makefile (python#101395)
  pythongh-98831: rewrite GET_LEN, GET_ITER, BEFORE_WITH and a few simple opcodes in the instruction definition DSL (python#101443)
  pythongh-77607: Improve accuracy of os.path.join docs (python#101406)
  Fixes typo in asyncio.TaskGroup context manager code example (python#101449)
  pythongh-98831: Clean up and add cache size static_assert to macro (python#101442)
  pythongh-99955: use SUCCESS/ERROR return values in optimizer and assembler. Use RETURN_IF_ERROR where appropriate. Fix a couple of bugs. (python#101412)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gvanrossum gvanrossum gvanrossum approved these changes
@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner
@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner
@kumaraditya303 kumaraditya303 Awaiting requested review from kumaraditya303 kumaraditya303 is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@bcla22 @miss-islington @bedevere-bot @gvanrossum
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.