GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-99276 - Updated Doc/faq/general.rst by workingpayload · Pull Request #101396 · python/cpython

Conversation

@workingpayload

@workingpayload workingpayload commented Jan 28, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor
  • Issue: Add link to the first article about Python #99276

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@workingpayload
Issue #99276 - Update Doc/faq/general.rst
ac7a9db
@bedevere-bot bedevere-bot added the awaiting review label Jan 28, 2023
@bedevere-bot bedevere-bot mentioned this pull request Jan 28, 2023
Add link to the first article about Python #99276
Closed
@bedevere-bot bedevere-bot added docs Documentation in the Doc dir skip news labels Jan 28, 2023
@ghost

ghost commented Jan 28, 2023 •
edited by ghost
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.
CLA signed
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@workingpayload
gh-99276 - Updated Doc/faq/general.rst
53b96b2
hugovk
hugovk requested changes Jan 29, 2023
View reviewed changes

@hugovk hugovk left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, but:

  • this is an article not a book, so doesn't belong in the books section
  • this article is already mentioned in the previous section about articles: https://docs.python.org/3/faq/general.html#are-there-any-published-articles-about-python-that-i-can-reference

Issue gh-99276 was about adding the https://ir.cwi.nl/pub/18204 article link to that articles section:

  • https://docs.python.org/3/faq/general.html#are-there-any-published-articles-about-python-that-i-can-reference

Please could you update the PR?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot added awaiting changes and removed awaiting review labels Jan 29, 2023
@bedevere-bot

bedevere-bot commented Jan 29, 2023

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@workingpayload

workingpayload commented Jan 29, 2023

Copy link
Copy Markdown
Contributor Author

Thanks for the PR, but:

  • this is an article not a book, so doesn't belong in the books section
  • this article is already mentioned in the previous section about articles: https://docs.python.org/3/faq/general.html#are-there-any-published-articles-about-python-that-i-can-reference

Issue gh-99276 was about adding the https://ir.cwi.nl/pub/18204 article link to that articles section:

  • https://docs.python.org/3/faq/general.html#are-there-any-published-articles-about-python-that-i-can-reference

Please could you update the PR?

Yeah Sure!!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@workingpayload
gh-99276 : Updated Doc/faq/general.rst
de44c07
@workingpayload

workingpayload commented Jan 29, 2023

Copy link
Copy Markdown
Contributor Author

I have made the requested changes; please review again
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot added awaiting change review and removed awaiting changes labels Jan 29, 2023
@bedevere-bot

bedevere-bot commented Jan 29, 2023

Copy link
Copy Markdown

Thanks for making the requested changes!

@hugovk: please review the changes made to this pull request.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot
bedevere-bot requested a review from hugovk January 29, 2023 17:38
@hugovk

hugovk commented Jan 29, 2023

Copy link
Copy Markdown
Member

Rather than adding that extra line, shall we add an inline link?

For example, to add the link around "very first article":

-The very first article about Python was written in 1991 and is now quite
-outdated.
+The `very first article <https://ir.cwi.nl/pub/18204>` about Python was 
+written in 1991 and is now quite outdated.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@workingpayload

workingpayload commented Jan 29, 2023

Copy link
Copy Markdown
Contributor Author

Rather than adding that extra line, shall we add an inline link?

For example, to add the link around "very first article":

-The very first article about Python was written in 1991 and is now quite
-outdated.
+The `very first article <https://ir.cwi.nl/pub/18204>` about Python was 
+written in 1991 and is now quite outdated.

Yeah sure!!
I'll do that.
Thank you for helping me out.
hugovk reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
workingpayload and others added 3 commits January 30, 2023 11:13
@workingpayload
Merge branch 'main' into workingpayload/issue99276
85e34c3
@workingpayload
gh-99276 : Updated Doc/faq/general.rst
f3d6eb1
@workingpayload
Merge branch 'workingpayload/issue99276' of https://github.com/workin…
5e9dd81 
…gpayload/cpython into workingpayload/issue99276
@workingpayload

workingpayload commented Jan 30, 2023

Copy link
Copy Markdown
Contributor Author

I have made the requested changes; please review again
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot

bedevere-bot commented Jan 30, 2023

Copy link
Copy Markdown

Thanks for making the requested changes!

@hugovk: please review the changes made to this pull request.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
hugovk
hugovk reviewed Jan 30, 2023
View reviewed changes
Comment thread Doc/faq/general.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Doc/faq/general.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
@workingpayload
gh-99276 : Updated Doc/faq/general.rst
96a2ebb
@workingpayload

workingpayload commented Jan 30, 2023

Copy link
Copy Markdown
Contributor Author

I have made the requested changes; please review again
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot

bedevere-bot commented Jan 30, 2023

Copy link
Copy Markdown

Thanks for making the requested changes!

@hugovk: please review the changes made to this pull request.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot
bedevere-bot requested a review from hugovk January 30, 2023 09:54
workingpayload and others added 2 commits January 30, 2023 15:29
@workingpayload @hugovk
Update Doc/faq/general.rst
f50ec70 
Co-authored-by: Hugo van Kemenade <[email protected]>
@workingpayload
Merge branch 'main' into workingpayload/issue99276
4976d3a
hugovk
hugovk reviewed Jan 30, 2023
View reviewed changes
Comment thread Doc/faq/general.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
@workingpayload @hugovk
Update Doc/faq/general.rst
a211ee5 
Co-authored-by: Hugo van Kemenade <[email protected]>
@workingpayload
workingpayload requested a review from hugovk January 30, 2023 10:50
hugovk
hugovk approved these changes Jan 30, 2023
View reviewed changes

@hugovk hugovk left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
workingpayload reacted with heart emoji
All reactions
  • ❤️ 1 reaction
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting change review labels Jan 30, 2023
@hugovk hugovk added needs backport to 3.10 needs backport to 3.11 only security fixes labels Jan 30, 2023
@hugovk
hugovk merged commit df0068c into python:main Jan 31, 2023
@miss-islington

miss-islington commented Jan 31, 2023

Copy link
Copy Markdown
Contributor

Thanks @workingpayload for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖
workingpayload reacted with heart emoji
All reactions
  • ❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting merge label Jan 31, 2023
@bedevere-bot

bedevere-bot commented Jan 31, 2023

Copy link
Copy Markdown

GH-101461 is a backport of this pull request to the 3.11 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Jan 31, 2023
@bedevere-bot

bedevere-bot commented Jan 31, 2023

Copy link
Copy Markdown

GH-101462 is a backport of this pull request to the 3.10 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.10 label Jan 31, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 31, 2023
@workingpayload @hugovk @miss-islington
pythongh-99276 - Updated Doc/faq/general.rst (pythonGH-101396)
de447d9 
(cherry picked from commit df0068c)

Co-authored-by: Raj <[email protected]>
Co-authored-by: Hugo van Kemenade <[email protected]>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 31, 2023
@workingpayload @hugovk @miss-islington
pythongh-99276 - Updated Doc/faq/general.rst (pythonGH-101396)
3232abc 
(cherry picked from commit df0068c)

Co-authored-by: Raj <[email protected]>
Co-authored-by: Hugo van Kemenade <[email protected]>
miss-islington added a commit that referenced this pull request Jan 31, 2023
@miss-islington @workingpayload @hugovk
gh-99276 - Updated Doc/faq/general.rst (GH-101396)
9e4ba5c 
(cherry picked from commit df0068c)

Co-authored-by: Raj <[email protected]>
Co-authored-by: Hugo van Kemenade <[email protected]>
hugovk added a commit that referenced this pull request Jan 31, 2023
@miss-islington @workingpayload @hugovk
[3.10] gh-99276 - Updated Doc/faq/general.rst (GH-101396) (#101462)
ca11848 
Co-authored-by: Raj <[email protected]>
Co-authored-by: Hugo van Kemenade <[email protected]>
mdboom pushed a commit to mdboom/cpython that referenced this pull request Jan 31, 2023
@workingpayload @hugovk @mdboom
pythongh-99276 - Updated Doc/faq/general.rst (python#101396)
9fd32e8 
Co-authored-by: Hugo van Kemenade <[email protected]>
carljm added a commit to carljm/cpython that referenced this pull request Jan 31, 2023
@carljm
Merge branch 'main' into inlinecomp2
ed3209b 
* main:
  pythongh-101440: fix json snippet error in logging-cookbook.rst (python#101439)
  pythongh-99276 - Updated Doc/faq/general.rst (python#101396)
  Add JOBS parameter to docs Makefile (python#101395)
  pythongh-98831: rewrite GET_LEN, GET_ITER, BEFORE_WITH and a few simple opcodes in the instruction definition DSL (python#101443)
  pythongh-77607: Improve accuracy of os.path.join docs (python#101406)
  Fixes typo in asyncio.TaskGroup context manager code example (python#101449)
  pythongh-98831: Clean up and add cache size static_assert to macro (python#101442)
  pythongh-99955: use SUCCESS/ERROR return values in optimizer and assembler. Use RETURN_IF_ERROR where appropriate. Fix a couple of bugs. (python#101412)
@workingpayload
workingpayload deleted the workingpayload/issue99276 branch February 1, 2023 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hugovk hugovk hugovk approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@workingpayload @bedevere-bot @hugovk @miss-islington
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.