GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-103462: Ensure SelectorSocketTransport.writelines registers a writer when data is still pending by alisaifee · Pull Request #103463 · python/cpython

Conversation

@alisaifee

@alisaifee alisaifee commented Apr 12, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Description

When the payload used with SelectorSocketTransport.writelines is too large to write in one call to either socket.send or socket.sendmsg the remaining buffer needs to be handled by registering a write handler.

Related Pull Request / Issue

  • Implement zero copy writes in SelectorSocketTransport in asyncio #91166
  • Issue: Calling SelectorSocketTransport.writelines with a very large payload doesn't get completely written to the socket #103462

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
alisaifee added 2 commits April 11, 2023 19:05
@alisaifee
Add explicit tests for writelines
273e1e7 
Includes two failing tests that demonstrate a bug
where if the data passed to writelines can't be sent
in one shot, the remaining buffer isn't written since
there is no registered write handler
@alisaifee
Schedule writer for remaining buffer in writelines
ce03f17 
If all the data in the buffer can't be written immediately
schedule a writer to handle the remaining data.
@alisaifee
alisaifee requested review from 1st1, asvetlov, gvanrossum and kumaraditya303 as code owners April 12, 2023 02:12
@bedevere-bot

bedevere-bot commented Apr 12, 2023

Copy link
Copy Markdown

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot mentioned this pull request Apr 12, 2023
Calling SelectorSocketTransport.writelines with a very large payload doesn't get completely written to the socket #103462
Closed
@bedevere-bot bedevere-bot added the awaiting review label Apr 12, 2023
@ghost

ghost commented Apr 12, 2023 •
edited by ghost
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.
CLA signed
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@alisaifee
Merge branch 'main' into fix-incomplete-writeline
8d2d34c
@bedevere-bot

bedevere-bot commented Apr 12, 2023

Copy link
Copy Markdown

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@alisaifee alisaifee changed the title gh-103462: Ensure SelectorSocketTransport.writelines schedules a writer when data is still pending gh-103462: Ensure SelectorSocketTransport.writelines registers a writer when data is still pending Apr 12, 2023
@alisaifee
Ensure tests using sendmsg are marked with skip
c5a071e 
When the platform (windows) doesn't support it
skip tests for writelines using sendmsg
@bedevere-bot

bedevere-bot commented Apr 12, 2023

Copy link
Copy Markdown

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.
alisaifee reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
kumaraditya303
kumaraditya303 reviewed Apr 12, 2023
View reviewed changes

@kumaraditya303 kumaraditya303 left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Can you add a news entry? Thanks

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
alisaifee reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
alisaifee added 2 commits April 12, 2023 06:05
@alisaifee
Add NEWS entry
7f2b1e7
@alisaifee
Merge branch 'main' into fix-incomplete-writeline
d2bdce2
@alisaifee

alisaifee commented Apr 12, 2023

Copy link
Copy Markdown
Contributor Author

LGTM, Can you add a news entry? Thanks

done!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
kumaraditya303
kumaraditya303 reviewed Apr 13, 2023
View reviewed changes
Comment thread Misc/NEWS.d/next/Library/2023-04-12-06-00-02.gh-issue-103462.w6yBlM.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
@kumaraditya303
Update Misc/NEWS.d/next/Library/2023-04-12-06-00-02.gh-issue-103462.w…
239a80f 
…6yBlM.rst
kumaraditya303
kumaraditya303 approved these changes Apr 13, 2023
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Apr 13, 2023
@kumaraditya303 kumaraditya303 linked an issue Apr 13, 2023 that may be closed by this pull request
Calling SelectorSocketTransport.writelines with a very large payload doesn't get completely written to the socket #103462
Closed
@kumaraditya303 kumaraditya303 added the topic-asyncio label Apr 13, 2023
@kumaraditya303
kumaraditya303 merged commit 19d2639 into python:main Apr 13, 2023
@bedevere-bot bedevere-bot removed the awaiting merge label Apr 13, 2023
carljm added a commit to carljm/cpython that referenced this pull request Apr 13, 2023
@carljm
Merge branch 'main' into superopt
9384106 
* main:
  pythongh-103479: [Enum] require __new__ to be considered a data type (pythonGH-103495)
  pythongh-103365: [Enum] STRICT boundary corrections (pythonGH-103494)
  pythonGH-103488: Use return-offset, not yield-offset. (pythonGH-103502)
  pythongh-103088: Fix test_venv error message to avoid bytes/str warning (pythonGH-103500)
  pythonGH-103082: Turn on branch events for FOR_ITER instructions. (python#103507)
  pythongh-102978: Fix mock.patch function signatures for class and staticmethod decorators (python#103228)
  pythongh-103462: Ensure SelectorSocketTransport.writelines registers a writer when data is still pending (python#103463)
  pythongh-95299: Rework test_cppext.py to not invoke setup.py directly (python#103316)
aisk pushed a commit to aisk/cpython that referenced this pull request Apr 18, 2023
@alisaifee @aisk
pythongh-103462: Ensure SelectorSocketTransport.writelines registers …
44b69f6 
…a writer when data is still pending (python#103463)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kumaraditya303 kumaraditya303 kumaraditya303 approved these changes
@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner
@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner
@gvanrossum gvanrossum Awaiting requested review from gvanrossum

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

topic-asyncio

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Calling SelectorSocketTransport.writelines with a very large payload doesn't get completely written to the socket

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@alisaifee @bedevere-bot @kumaraditya303
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.