GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-103088: Fix test error message by Zabolekar · Pull Request #103500 · python/cpython

Conversation

@Zabolekar

@Zabolekar Zabolekar commented Apr 13, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor
  • Issue: If the working directory and the venv are on different disks, venv doesn't work in bash on Windows #103088

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@Zabolekar
Fix test error message
bf3c063
@Zabolekar
Zabolekar requested a review from vsajip as a code owner April 13, 2023 08:12
@bedevere-bot bedevere-bot added the tests Tests in the Lib/test dir label Apr 13, 2023
@bedevere-bot bedevere-bot mentioned this pull request Apr 13, 2023
If the working directory and the venv are on different disks, venv doesn't work in bash on Windows #103088
Closed
@bedevere-bot bedevere-bot added the awaiting review label Apr 13, 2023
@arhadthedev

arhadthedev commented Apr 13, 2023

Copy link
Copy Markdown
Member

Triggering the buildbots to get logs with the new message.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@arhadthedev arhadthedev added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Apr 13, 2023
@bedevere-bot

bedevere-bot commented Apr 13, 2023

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @arhadthedev for commit bf3c063 🤖

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Apr 13, 2023
@arhadthedev

arhadthedev commented Apr 13, 2023

Copy link
Copy Markdown
Member

The tests are done:

======================================================================
FAIL: test_activate_shell_script_has_no_dos_newlines (test.test_venv.BasicTest.test_activate_shell_script_has_no_dos_newlines)
Test that the `activate` shell script contains no CR LF.
----------------------------------------------------------------------
Traceback (most recent call last):
  File "D:\buildarea\pull_request.bolen-windows10\build\Lib\test\test_venv.py", line 628, in test_activate_shell_script_has_no_dos_newlines
    self.assertFalse(line.endswith(b'\r\n'), error_message)
AssertionError: True is not false : CR LF found in line 1
----------------------------------------------------------------------
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@arhadthedev

arhadthedev commented Apr 13, 2023

Copy link
Copy Markdown
Member

According to https://git-scm.com/docs/gitattributes#_text, we need to check if core.autocrlf is set in git config on Windows because it overrides .gitattributes.

Zabolekar reacted with thumbs up emoji zooba reacted with thumbs down emoji
All reactions
  • 👍 1 reaction
  • 👎 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@zooba

zooba commented Apr 13, 2023

Copy link
Copy Markdown
Member

It only overrides the value of core.eol being used as the default, which is not what is happening here. We've explicitly set the line ending for the file, we just need anyone who's checked it out in the past to delete it and check it out again (tested on my own Windows machine, which has core.autocrlf set).

If we can't find a way to force the buildbots to do a clean checkout, instead of reusing their existing one, then we probably need to ping all the owners to log in and do it manually.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@zooba zooba added the skip news label Apr 13, 2023
@zooba

zooba commented Apr 13, 2023

Copy link
Copy Markdown
Member

The buildbot results look good (the expected failure), so merging this. Buildbot discussion back to #103088 please.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@zooba
zooba merged commit 4307fea into python:main Apr 13, 2023
@bedevere-bot bedevere-bot removed the awaiting review label Apr 13, 2023
carljm added a commit to carljm/cpython that referenced this pull request Apr 13, 2023
@carljm
Merge branch 'main' into superopt
9384106
* main:
  pythongh-103479: [Enum] require __new__ to be considered a data type (pythonGH-103495)
  pythongh-103365: [Enum] STRICT boundary corrections (pythonGH-103494)
  pythonGH-103488: Use return-offset, not yield-offset. (pythonGH-103502)
  pythongh-103088: Fix test_venv error message to avoid bytes/str warning (pythonGH-103500)
  pythonGH-103082: Turn on branch events for FOR_ITER instructions. (python#103507)
  pythongh-102978: Fix mock.patch function signatures for class and staticmethod decorators (python#103228)
  pythongh-103462: Ensure SelectorSocketTransport.writelines registers a writer when data is still pending (python#103463)
  pythongh-95299: Rework test_cppext.py to not invoke setup.py directly (python#103316)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vsajip vsajip Awaiting requested review from vsajip vsajip is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@Zabolekar @arhadthedev @bedevere-bot @zooba
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.