GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-103479: [Enum] require __new__ to be considered a data type by ethanfurman · Pull Request #103495 · python/cpython

Conversation

@ethanfurman

@ethanfurman ethanfurman commented Apr 13, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

or be a dataclass

  • Issue: Unexpected behavior change in subclassing Enum class as of 3.11 #103479

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@ethanfurman
require __new__ to be considered a data type
2e881fa
or be a dataclass
@ethanfurman ethanfurman added tests Tests in the Lib/test dir skip news stdlib Standard Library Python modules in the Lib/ directory 3.11 only security fixes 3.12 only security fixes needs backport to 3.11 only security fixes labels Apr 13, 2023
@ethanfurman ethanfurman self-assigned this Apr 13, 2023
@bedevere-bot bedevere-bot mentioned this pull request Apr 13, 2023
Unexpected behavior change in subclassing Enum class as of 3.11 #103479
Closed
@bedevere-bot bedevere-bot added the awaiting core review label Apr 13, 2023
@ethanfurman
ethanfurman merged commit a6f9594 into python:main Apr 13, 2023
@miss-islington

miss-islington commented Apr 13, 2023

Copy link
Copy Markdown
Contributor

Thanks @ethanfurman for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-bot bedevere-bot removed the awaiting core review label Apr 13, 2023
@miss-islington

miss-islington commented Apr 13, 2023

Copy link
Copy Markdown
Contributor

Sorry, @ethanfurman, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker a6f95941a3d686707fb38e0f37758e666f25e180 3.11

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@ethanfurman
ethanfurman deleted the enum-init_not_new branch April 13, 2023 15:32
@bedevere-bot

bedevere-bot commented Apr 13, 2023

Copy link
Copy Markdown

GH-103514 is a backport of this pull request to the 3.11 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Apr 13, 2023
ethanfurman added a commit to ethanfurman/cpython that referenced this pull request Apr 13, 2023
@ethanfurman
[3.11] pythongh-103479: [Enum] require __new__ to be considered a da…
ab60fdd
…ta type (pythonGH-103495)

a mixin must either have a __new__ method, or be a dataclass, to be interpreted as a data-type.
                    (cherry picked from commit a6f9594)

                    Co-authored-by: Ethan Furman <[email protected]>
carljm added a commit to carljm/cpython that referenced this pull request Apr 13, 2023
@carljm
Merge branch 'main' into superopt
9384106
* main:
  pythongh-103479: [Enum] require __new__ to be considered a data type (pythonGH-103495)
  pythongh-103365: [Enum] STRICT boundary corrections (pythonGH-103494)
  pythonGH-103488: Use return-offset, not yield-offset. (pythonGH-103502)
  pythongh-103088: Fix test_venv error message to avoid bytes/str warning (pythonGH-103500)
  pythonGH-103082: Turn on branch events for FOR_ITER instructions. (python#103507)
  pythongh-102978: Fix mock.patch function signatures for class and staticmethod decorators (python#103228)
  pythongh-103462: Ensure SelectorSocketTransport.writelines registers a writer when data is still pending (python#103463)
  pythongh-95299: Rework test_cppext.py to not invoke setup.py directly (python#103316)
ethanfurman added a commit that referenced this pull request Apr 13, 2023
@ethanfurman
[3.11] gh-103479: [Enum] require __new__ to be considered a data type (…
3b929a7
…GH-103495) (GH-103514)

a mixin must either have a __new__ method, or be a dataclass, to be interpreted as a data-type; an __init__ method is not enough (restores pre-3.11 behavior for non-dataclasses).

(cherry picked from commit a6f9594)
Co-authored-by: Ethan Furman <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@ethanfurman ethanfurman

Labels

3.11 only security fixes 3.12 only security fixes skip news stdlib Standard Library Python modules in the Lib/ directory tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@ethanfurman @miss-islington @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.