GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-103365: [Enum] STRICT boundary corrections by ethanfurman · Pull Request #103494 · python/cpython

Conversation

@ethanfurman

@ethanfurman ethanfurman commented Apr 13, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • fix bitwise operations
  • make STRICT default for Flag
  • Issue: enum.CONFORM behavior breaks backwards compatibility #103365
  • Issue: Change in Flag enum behaviour in v3.11rc2 #96865

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@ethanfurman
STRICT boundary:
00c812f 
- fix bitwise operations
- make default for Flag
@ethanfurman ethanfurman added docs Documentation in the Doc dir stdlib Standard Library Python modules in the Lib/ directory 3.11 only security fixes 3.12 only security fixes needs backport to 3.11 only security fixes labels Apr 13, 2023
@ethanfurman ethanfurman self-assigned this Apr 13, 2023
@bedevere-bot bedevere-bot mentioned this pull request Apr 13, 2023
enum.CONFORM behavior breaks backwards compatibility #103365
Closed
@bedevere-bot bedevere-bot added the awaiting core review label Apr 13, 2023
@ethanfurman ethanfurman changed the title gh-103365: [Enum] STRICT boundary corrections gh-103479: [Enum] STRICT boundary corrections Apr 13, 2023
@bedevere-bot bedevere-bot mentioned this pull request Apr 13, 2023
Unexpected behavior change in subclassing Enum class as of 3.11 #103479
Closed
@ethanfurman
Merge branch 'main' into enum-skipflag
e19d945
@ethanfurman ethanfurman changed the title gh-103479: [Enum] STRICT boundary corrections gh-103365: [Enum] STRICT boundary corrections Apr 13, 2023
@ethanfurman
ethanfurman merged commit 2194071 into python:main Apr 13, 2023
@bedevere-bot bedevere-bot removed the awaiting core review label Apr 13, 2023
@miss-islington

miss-islington commented Apr 13, 2023

Copy link
Copy Markdown
Contributor

Thanks @ethanfurman for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 13, 2023
@ethanfurman @miss-islington
pythongh-103365: [Enum] STRICT boundary corrections (pythonGH-103494)
4598cf6 
STRICT boundary:

- fix bitwise operations
- make default for Flag
(cherry picked from commit 2194071)

Co-authored-by: Ethan Furman <[email protected]>
@bedevere-bot

bedevere-bot commented Apr 13, 2023

Copy link
Copy Markdown

GH-103513 is a backport of this pull request to the 3.11 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Apr 13, 2023
@ethanfurman
ethanfurman deleted the enum-skipflag branch April 13, 2023 15:32
miss-islington added a commit that referenced this pull request Apr 13, 2023
@miss-islington @ethanfurman
gh-103365: [Enum] STRICT boundary corrections (GH-103494)
804a973 
STRICT boundary:

- fix bitwise operations
- make default for Flag
(cherry picked from commit 2194071)

Co-authored-by: Ethan Furman <[email protected]>
carljm added a commit to carljm/cpython that referenced this pull request Apr 13, 2023
@carljm
Merge branch 'main' into superopt
9384106 
* main:
  pythongh-103479: [Enum] require __new__ to be considered a data type (pythonGH-103495)
  pythongh-103365: [Enum] STRICT boundary corrections (pythonGH-103494)
  pythonGH-103488: Use return-offset, not yield-offset. (pythonGH-103502)
  pythongh-103088: Fix test_venv error message to avoid bytes/str warning (pythonGH-103500)
  pythonGH-103082: Turn on branch events for FOR_ITER instructions. (python#103507)
  pythongh-102978: Fix mock.patch function signatures for class and staticmethod decorators (python#103228)
  pythongh-103462: Ensure SelectorSocketTransport.writelines registers a writer when data is still pending (python#103463)
  pythongh-95299: Rework test_cppext.py to not invoke setup.py directly (python#103316)
@The-Compiler The-Compiler mentioned this pull request Jun 8, 2023
3.11.4: ValueError when inverting enum.Flag member with mask member #105497
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@ethanfurman ethanfurman

Labels

3.11 only security fixes 3.12 only security fixes docs Documentation in the Doc dir stdlib Standard Library Python modules in the Lib/ directory

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@ethanfurman @miss-islington @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.