GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-104057: Fix direct invocation of test_module by Eclips4 · Pull Request #104059 · python/cpython

Conversation

@Eclips4

@Eclips4 Eclips4 commented May 1, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Fix #104057

  • Issue: Some test modules fail when run as a script #104057

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@Eclips4
Fix path
d9931f6
@bedevere-bot bedevere-bot added awaiting review tests Tests in the Lib/test dir labels May 1, 2023
@Eclips4

Eclips4 commented May 1, 2023

Copy link
Copy Markdown
Member Author

cc @AlexWaygood

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@Eclips4 Eclips4 changed the title Fix direct invocation of test_module gh-104057: Fix direct invocation of test_module May 1, 2023
@bedevere-bot bedevere-bot mentioned this pull request May 1, 2023
Some test modules fail when run as a script #104057
Closed
@zware zware added the skip news label May 1, 2023
zware
zware approved these changes May 1, 2023
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels May 1, 2023
@zware
zware enabled auto-merge (squash) May 1, 2023 19:53
@Eclips4

Eclips4 commented May 1, 2023

Copy link
Copy Markdown
Member Author

Hello @zware!
Should it be backported to 3.11 branch?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@Eclips4

Eclips4 commented May 1, 2023

Copy link
Copy Markdown
Member Author

Also, I found an few similiar issues in tests.
Should I create an new issue for each of them?
I would create a one issue and just mention it in PR's.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@AlexWaygood AlexWaygood added the needs backport to 3.11 only security fixes label May 1, 2023
@AlexWaygood

AlexWaygood commented May 1, 2023

Copy link
Copy Markdown
Member

Using one issue and linking multiple PRs to it would be best.

Eclips4 and zware reacted with thumbs up emoji Eclips4 reacted with heart emoji
All reactions
  • 👍 2 reactions
  • ❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@Eclips4

Eclips4 commented May 1, 2023

Copy link
Copy Markdown
Member Author

Using one issue and linking multiple PRs to it would be best.

Thanks for your answer, Alex!
Should I create new issue, or just rename #104057 ?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@zware
zware merged commit d448fcb into python:main May 1, 2023
@miss-islington

miss-islington commented May 1, 2023

Copy link
Copy Markdown
Contributor

Thanks @Eclips4 for the PR, and @zware for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-bot bedevere-bot removed the awaiting merge label May 1, 2023
@miss-islington

miss-islington commented May 1, 2023

Copy link
Copy Markdown
Contributor

Sorry, @Eclips4 and @zware, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker d448fcb0323bf00cb4ff4a1e65e8424a73b5f0d4 3.11

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@miss-islington miss-islington assigned zware May 1, 2023
@zware

zware commented May 1, 2023

Copy link
Copy Markdown
Member

Using one issue and linking multiple PRs to it would be best.

Thanks for your answer, Alex! Should I create new issue, or just rename #104057 ?

I'll reopen and rename #104057.

AlexWaygood and Eclips4 reacted with thumbs up emoji
All reactions
  • 👍 2 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@zware

zware commented May 1, 2023

Copy link
Copy Markdown
Member

Hello @zware! Should it be backported to 3.11 branch?

Apparently not :). That line doesn't exist in 3.11; if there's a similar issue in that branch, we should just create a clean PR against 3.11.

AlexWaygood and Eclips4 reacted with laugh emoji
All reactions
  • 😄 2 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@zware zware removed the needs backport to 3.11 only security fixes label May 1, 2023
@AlexWaygood

AlexWaygood commented May 1, 2023

Copy link
Copy Markdown
Member

Apparently not :). That line doesn't exist in 3.11

Oops, sorry 'bout that! I should have checked before adding the label.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@Eclips4
Eclips4 deleted the issue-104057 branch May 1, 2023 20:46
carljm added a commit to carljm/cpython that referenced this pull request May 1, 2023
@carljm
Merge branch 'main' into inlinecomp2
1274e2b
* main: (463 commits)
  pythongh-104057: Fix direct invocation of test_super (python#104064)
  pythongh-87092: Expose assembler to unit tests (python#103988)
  pythongh-97696: asyncio eager tasks factory (python#102853)
  pythongh-84436: Immortalize in _PyStructSequence_InitBuiltinWithFlags() (pythongh-104054)
  pythongh-104057: Fix direct invocation of test_module (pythonGH-104059)
  pythongh-100458: Clarify Enum.__format__() change of mixed-in types in the whatsnew/3.11.rst (pythonGH-100387)
  pythongh-104018: disallow "z" format specifier in %-format of byte strings (pythonGH-104033)
  pythongh-104016: Fixed off by 1 error in f string tokenizer (python#104047)
  pythonGH-103629: Update Unpack's repr in compliance with PEP 692 (python#104048)
  pythongh-102799: replace sys.exc_info by sys.exception in inspect and traceback modules (python#104032)
  Fix typo in "expected" word in few source files (python#104034)
  pythongh-103824: fix use-after-free error in Parser/tokenizer.c (python#103993)
  pythongh-104035: Do not ignore user-defined `__{get,set}state__` in slotted frozen dataclasses (python#104041)
  pythongh-104028: Reduce object creation while calling callback function from gc (pythongh-104030)
  pythongh-104036: Fix direct invocation of test_typing (python#104037)
  pythongh-102213: Optimize the performance of `__getattr__` (pythonGH-103761)
  pythongh-103895: Improve how invalid `Exception.__notes__` are displayed (python#103897)
  Adjust expression from `==` to `!=` in alignment with the meaning of the paragraph. (pythonGH-104021)
  pythongh-88496: Fix IDLE test hang on macOS (python#104025)
  Improve int test coverage (python#104024)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zware zware zware approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@zware zware

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Some test modules fail when run as a script

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@Eclips4 @AlexWaygood @miss-islington @zware @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.