GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — Document Python build requirements by vstinner · Pull Request #108646 · python/cpython

Conversation

vstinner commented Aug 29, 2023 •

edited by AA-Turner

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Member

Autoconf and aclocal: issue Improve and simplify configure.ac checks #89886
SQLite 3.15.2: issue Bump required SQLite version to 3.15.2 #105875
Tcl/Tk 8.5.12: issue Drop support of Tcl/Tk older than 8.5.12 #91152

📚 Documentation preview 📚: https://cpython-previews--108646.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

erlend-aasland reacted with thumbs up emoji

All reactions

👍 1 reaction


          Document Python build requirements

76cfe6f

* Autoconf and aclocal: issue pythonGH-89886
* SQLite 3.15.2: issue pythonGH-105875
* Tcl/Tk 8.5.12: issue pythonGH-91152

vstinner added skip issue skip news labels

Aug 29, 2023

vstinner requested review from corona10 and erlend-aasland as code owners

August 29, 2023 16:00

bedevere-bot added docs

Documentation in the Doc dir

awaiting core review labels

Aug 29, 2023

vstinner commented Aug 29, 2023

Copy link

Copy Markdown

Member Author

@erlend-aasland: Please check the Autoconf, aclocal and SQLite minimum versions. -- I copied versions from What's New in Python 3.13
@serhiy-storchaka: Please check the Tcl/Tk minimum version.

erlend-aasland reacted with thumbs up emoji

All reactions

👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

AA-Turner reviewed

Aug 29, 2023

View reviewed changes

Comment thread

Doc/whatsnew/3.13.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.


          Use :file:configure syntax

ccd7ae6

erlend-aasland reviewed

Aug 29, 2023

View reviewed changes

Comment thread

Doc/using/configure.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

erlend-aasland reviewed

Aug 29, 2023

View reviewed changes

Comment thread

Doc/using/configure.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.


          Address Erlend's review

0263d53

vstinner commented Aug 29, 2023

Copy link

Copy Markdown

Member Author

@erlend-aasland: Please review the updated PR.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

AA-Turner reviewed

Aug 29, 2023

View reviewed changes

Comment thread

Doc/using/configure.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.


          recommended minimum version

82be2e8

erlend-aasland approved these changes

Aug 30, 2023

View reviewed changes

bedevere-bot added awaiting merge and removed awaiting core review labels

Aug 30, 2023

serhiy-storchaka reviewed

Aug 30, 2023

View reviewed changes

serhiy-storchaka left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tcl/Tk version 8.4 is required in 3.5.

Tcl/Tk version 8.3.1 is required in 3.1.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

serhiy-storchaka commented Aug 30, 2023

Copy link

Copy Markdown

Member

The earliest versionchanged here is for 3.5, so I think we can omit 3.1, but add to 3.5.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.


          History of Tcl/Tk requirement

d5d6d45

vstinner commented Aug 30, 2023

Copy link

Copy Markdown

Member Author

Tcl/Tk version 8.4 is required in 3.5.
Tcl/Tk version 8.3.1 is required in 3.1.

Good to know. I completed the doc.

@serhiy-storchaka: Would you mind to review the updated PR?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

erlend-aasland commented Aug 30, 2023 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Contributor

I'm not sure what it is worth, but here's more details on SQLite requirements:

3.10: Require SQLite 3.7.15

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.


          Complete SQLite requirement history

f3cea5f

vstinner commented Aug 30, 2023

Copy link

Copy Markdown

Member Author

3.10: Require SQLite 3.7.15

Added.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

serhiy-storchaka approved these changes

Aug 30, 2023

View reviewed changes

serhiy-storchaka left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Seems that other extension modules either shipped with some default version (like zlib or decimal), or do not have explicit version requirements.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

vstinner commented Aug 30, 2023

Copy link

Copy Markdown

Member Author

Seems that other extension modules either shipped with some default version (like zlib or decimal), or do not have explicit version requirements.

If someone has information about minimum version, please go ahead and propose a doc PR :-) I don't recall any information about that.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

vstinner merged commit e012cf7 into python:main

Aug 30, 2023

bedevere-bot removed the awaiting merge label

Aug 30, 2023

vstinner commented Aug 30, 2023

Copy link

Copy Markdown

Member Author

Merged, I added Erlend and Serhiy as co-authors of the PR :-)

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

vstinner deleted the doc_build_req branch

August 30, 2023 13:29

carljm added a commit to carljm/cpython that referenced this pull request

Aug 30, 2023


          Merge branch 'main' into icompexc

37377e6

* main:
  pythongh-108520: Fix bad fork detection in nested multiprocessing use case (python#108568)
  pythongh-108590: Revert pythongh-108657 (commit 400a1ce) (python#108686)
  pythongh-108494: Argument Clinic: Document how to generate code that uses the limited C API (python#108584)
  Document Python build requirements (python#108646)
  pythongh-101100: Fix Sphinx warnings in the Logging Cookbook (python#108678)
  Fix typo in multiprocessing docs (python#108666)
  pythongh-108669: unittest: Fix documentation for TestResult.collectedDurations (python#108670)
  pythongh-108590: Fix sqlite3.iterdump for invalid Unicode in TEXT columns (python#108657)
  Revert "pythongh-103224: Use the realpath of the Python executable in `test_venv` (pythonGH-103243)" (pythonGH-108667)
  pythongh-106320: Remove private _Py_ForgetReference() (python#108664)
  Mention Ellipsis pickling in the docs (python#103660)
  Revert "Use non alternate name for Kyiv (pythonGH-108533)" (pythonGH-108649)
  pythongh-108278: Deprecate passing the first param of sqlite3.Connection callback APIs by keyword (python#108632)
  pythongh-108455: peg_generator: install two stubs packages before running mypy (python#108637)
  pythongh-107801: Improve the accuracy of io.IOBase.seek docs (python#108268)

Reviewers

AA-Turner

AA-Turner left review comments

serhiy-storchaka

serhiy-storchaka approved these changes

erlend-aasland

erlend-aasland approved these changes

corona10

Awaiting requested review from corona10

corona10 is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

docs

Documentation in the Doc dir

skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

vstinner commented Aug 29, 2023 • edited by AA-Turner Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vstinner commented Aug 29, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

vstinner commented Aug 29, 2023

Uh oh!

Uh oh!

serhiy-storchaka left a comment

Choose a reason for hiding this comment

Uh oh!

serhiy-storchaka commented Aug 30, 2023

Uh oh!

vstinner commented Aug 30, 2023

Uh oh!

erlend-aasland commented Aug 30, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vstinner commented Aug 30, 2023

Uh oh!

serhiy-storchaka left a comment

Choose a reason for hiding this comment

Uh oh!

vstinner commented Aug 30, 2023

Uh oh!

vstinner commented Aug 30, 2023

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

vstinner commented Aug 29, 2023 •

edited by AA-Turner

Loading

Uh oh!

There was an error while loading. Please reload this page.

erlend-aasland commented Aug 30, 2023 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.