GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-108590: Revert gh-108657 (commit 400a1cebc) by erlend-aasland · Pull Request #108686 · python/cpython

Conversation

@erlend-aasland

@erlend-aasland erlend-aasland commented Aug 30, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Reverted per Serhiy's request.

  • Issue: sqlite3.iterdump() incompatible with binary data #108590

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@erlend-aasland
pythongh-108590: Revert pythongh-108657 (commit 400a1ce)
cd05820
Reverted per Serhiy's request.
@erlend-aasland
erlend-aasland requested a review from berkerpeksag as a code owner August 30, 2023 14:26
@erlend-aasland erlend-aasland added the needs backport to 3.11 only security fixes label Aug 30, 2023
@bedevere-bot bedevere-bot mentioned this pull request Aug 30, 2023
sqlite3.iterdump() incompatible with binary data #108590
Closed
2 tasks done
@bedevere-bot bedevere-bot added the awaiting core review label Aug 30, 2023
@erlend-aasland
erlend-aasland enabled auto-merge (squash) August 30, 2023 14:27
@erlend-aasland
erlend-aasland merged commit 2a3926f into python:main Aug 30, 2023
@miss-islington

miss-islington commented Aug 30, 2023

Copy link
Copy Markdown
Contributor

Thanks @erlend-aasland for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-bot bedevere-bot removed the awaiting core review label Aug 30, 2023
@miss-islington

This comment was marked as outdated.

Sign in to view
@miss-islington miss-islington assigned erlend-aasland Aug 30, 2023
@erlend-aasland

This comment was marked as outdated.

Sign in to view
@erlend-aasland
erlend-aasland deleted the sqlite/revert-400a1cebc branch August 30, 2023 14:54
carljm added a commit to carljm/cpython that referenced this pull request Aug 30, 2023
@carljm
Merge branch 'main' into icompexc
37377e6
* main:
  pythongh-108520: Fix bad fork detection in nested multiprocessing use case (python#108568)
  pythongh-108590: Revert pythongh-108657 (commit 400a1ce) (python#108686)
  pythongh-108494: Argument Clinic: Document how to generate code that uses the limited C API (python#108584)
  Document Python build requirements (python#108646)
  pythongh-101100: Fix Sphinx warnings in the Logging Cookbook (python#108678)
  Fix typo in multiprocessing docs (python#108666)
  pythongh-108669: unittest: Fix documentation for TestResult.collectedDurations (python#108670)
  pythongh-108590: Fix sqlite3.iterdump for invalid Unicode in TEXT columns (python#108657)
  Revert "pythongh-103224: Use the realpath of the Python executable in `test_venv` (pythonGH-103243)" (pythonGH-108667)
  pythongh-106320: Remove private _Py_ForgetReference() (python#108664)
  Mention Ellipsis pickling in the docs (python#103660)
  Revert "Use non alternate name for Kyiv (pythonGH-108533)" (pythonGH-108649)
  pythongh-108278: Deprecate passing the first param of sqlite3.Connection callback APIs by keyword (python#108632)
  pythongh-108455: peg_generator: install two stubs packages before running mypy (python#108637)
  pythongh-107801: Improve the accuracy of io.IOBase.seek docs (python#108268)
erlend-aasland added a commit to erlend-aasland/cpython that referenced this pull request Aug 30, 2023
@erlend-aasland
[3.11] pythongh-108590: Revert pythongh-108657 (commit 400a1ce) (pyth…
8888729
…on#108686)

(cherry picked from commit 2a3926f)

Reverted per Serhiy's request.
@bedevere-bot

bedevere-bot commented Aug 30, 2023

Copy link
Copy Markdown

GH-108694 is a backport of this pull request to the 3.11 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Aug 30, 2023
erlend-aasland added a commit that referenced this pull request Aug 30, 2023
@erlend-aasland
[3.11] gh-108590: Revert gh-108657 (commit 400a1ce) (#108686) (#108694)
6f24420
(cherry picked from commit 2a3926f)

Reverted per Serhiy's request.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@berkerpeksag berkerpeksag Awaiting requested review from berkerpeksag

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@erlend-aasland erlend-aasland

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@erlend-aasland @miss-islington @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.