GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — gh-108590: Fix sqlite3.iterdump for invalid unicode in text columns. by CorvinM · Pull Request #108657 · python/cpython

Conversation

CorvinM commented Aug 29, 2023 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Contributor

Fixes an exception where sqlite3.iterdump would fail to decode if someone stuffed invalid unicode into a database column marked as TEXT (or alias of, like VARCHAR).
See #108590 for more info

Issue: sqlite3.iterdump() incompatible with binary data #108590

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          pythongh-108590: Fix sqlite3.iterdump for invalid unicode in text col…

a689bbd

…umns.

bedevere-bot mentioned this pull request

Aug 29, 2023

sqlite3.iterdump() incompatible with binary data #108590

Closed

2 tasks done

CorvinM commented

Aug 29, 2023

View reviewed changes

Comment thread

Lib/sqlite3/dump.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

CorvinM marked this pull request as ready for review

August 29, 2023 22:49

CorvinM requested review from berkerpeksag and erlend-aasland as code owners

August 29, 2023 22:49

bedevere-bot added the awaiting review label

Aug 29, 2023


          📜🤖 Added by blurb_it.

03f41df

erlend-aasland reviewed

Aug 30, 2023

View reviewed changes

Comment thread

Lib/sqlite3/dump.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Misc/NEWS.d/next/Library/2023-08-29-22-53-48.gh-issue-108590.6k0pOl.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Lib/sqlite3/dump.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

CorvinM and others added 3 commits

August 30, 2023 03:41


          Update Misc/NEWS.d/next/Library/2023-08-29-22-53-48.gh-issue-108590.6…

e2939d5

…k0pOl.rst

Co-authored-by: Erlend E. Aasland <[email protected]>


          Update Lib/sqlite3/dump.py

0643ffc

Co-authored-by: Erlend E. Aasland <[email protected]>


          Address comments

608d919

erlend-aasland reviewed

Aug 30, 2023

View reviewed changes

Comment thread

Lib/sqlite3/dump.py Resolved

Uh oh!

There was an error while loading. Please reload this page.


          Use contextmanager

cc7fba8

erlend-aasland approved these changes

Aug 30, 2023

View reviewed changes

erlend-aasland left a comment

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this, Corvin; it is a nice solution to this corner case.

I'll make some final adjustments before landing.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

CorvinM reacted with thumbs up emoji

All reactions

👍 1 reaction

bedevere-bot added awaiting merge and removed awaiting review labels

Aug 30, 2023


          Style nits and a comment

c1b730d

erlend-aasland enabled auto-merge (squash)

August 30, 2023 08:28

erlend-aasland added needs backport to 3.11

only security fixes

needs backport to 3.12 only security fixes labels

Aug 30, 2023

erlend-aasland linked an issue

Aug 30, 2023

that may be closed by this pull request

sqlite3.iterdump() incompatible with binary data #108590

Closed

2 tasks done

erlend-aasland commented Aug 30, 2023

Copy link

Copy Markdown

Contributor

@CorvinM, you may also be interested in looking at #108364

CorvinM reacted with thumbs up emoji

All reactions

👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

CorvinM commented Aug 30, 2023

Copy link

Copy Markdown

Contributor Author

Thank you for the speedy reviews and helpful feedback 😄 Let me know if you want me to pick up anything else with this (e.g., backports)

erlend-aasland reacted with heart emoji

All reactions

❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

erlend-aasland merged commit 400a1ce into python:main

Aug 30, 2023

This comment was marked as outdated.

bedevere-bot removed the awaiting merge label

Aug 30, 2023

miss-islington commented Aug 30, 2023

Copy link

Copy Markdown

Contributor

Sorry, @CorvinM and @erlend-aasland, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 400a1cebc743515e40157ed7af86e48d654290ce 3.12

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

miss-islington assigned erlend-aasland

Aug 30, 2023

miss-islington commented Aug 30, 2023

Copy link

Copy Markdown

Contributor

Sorry, @CorvinM and @erlend-aasland, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 400a1cebc743515e40157ed7af86e48d654290ce 3.11

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

erlend-aasland commented Aug 30, 2023

Copy link

Copy Markdown

Contributor

@CorvinM, can you handle the backports? You can use the cherry-picker. See the devguide.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

CorvinM commented Aug 30, 2023

Copy link

Copy Markdown

Contributor Author

@CorvinM, can you handle the backports? You can use the cherry-picker. See the devguide.

Sure

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

CorvinM added a commit to CorvinM/cpython that referenced this pull request

Aug 30, 2023


          [3.12] pythongh-108590: Fix sqlite3.iterdump for invalid Unicode in T…

805b2fd

…EXT columns (pythonGH-108657)

Co-authored-by: Erlend E. Aasland <[email protected]>.
(cherry picked from commit 400a1ce)

Co-authored-by: Corvin <[email protected]>

CorvinM mentioned this pull request

Aug 30, 2023

[3.12] gh-108590: Fix sqlite3.iterdump for invalid Unicode in TEXT columns (GH-108657) #108673

Closed

bedevere-bot commented Aug 30, 2023

Copy link

Copy Markdown

GH-108673 is a backport of this pull request to the 3.12 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-bot removed the needs backport to 3.12 only security fixes label

Aug 30, 2023

CorvinM added a commit to CorvinM/cpython that referenced this pull request

Aug 30, 2023


          [3.11] pythongh-108590: Fix sqlite3.iterdump for invalid Unicode in T…

766d626

…EXT columns (pythonGH-108657)

Co-authored-by: Erlend E. Aasland <[email protected]>.
(cherry picked from commit 400a1ce)

Co-authored-by: Corvin <[email protected]>

CorvinM mentioned this pull request

Aug 30, 2023

[3.11] gh-108590: Fix sqlite3.iterdump for invalid Unicode in TEXT columns (GH-108657) #108674

Merged

bedevere-bot commented Aug 30, 2023

Copy link

Copy Markdown

GH-108674 is a backport of this pull request to the 3.11 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-bot removed the needs backport to 3.11 only security fixes label

Aug 30, 2023

erlend-aasland pushed a commit that referenced this pull request

Aug 30, 2023


          [3.11] gh-108590: Fix sqlite3.iterdump for invalid Unicode in TEXT co…

5a6d123

…lumns (GH-108657) (#108674)

(cherry picked from commit 400a1ce)

erlend-aasland added a commit to erlend-aasland/cpython that referenced this pull request

Aug 30, 2023


          pythongh-108590: Revert pythongh-108657 (commit 400a1ce)

cd05820

Reverted per Serhiy's request.

erlend-aasland added a commit that referenced this pull request

Aug 30, 2023


          gh-108590: Revert gh-108657 (commit 400a1ce) (#108686)

2a3926f

Reverted per Serhiy's request.

carljm added a commit to carljm/cpython that referenced this pull request

Aug 30, 2023


          Merge branch 'main' into icompexc

37377e6

* main:
  pythongh-108520: Fix bad fork detection in nested multiprocessing use case (python#108568)
  pythongh-108590: Revert pythongh-108657 (commit 400a1ce) (python#108686)
  pythongh-108494: Argument Clinic: Document how to generate code that uses the limited C API (python#108584)
  Document Python build requirements (python#108646)
  pythongh-101100: Fix Sphinx warnings in the Logging Cookbook (python#108678)
  Fix typo in multiprocessing docs (python#108666)
  pythongh-108669: unittest: Fix documentation for TestResult.collectedDurations (python#108670)
  pythongh-108590: Fix sqlite3.iterdump for invalid Unicode in TEXT columns (python#108657)
  Revert "pythongh-103224: Use the realpath of the Python executable in `test_venv` (pythonGH-103243)" (pythonGH-108667)
  pythongh-106320: Remove private _Py_ForgetReference() (python#108664)
  Mention Ellipsis pickling in the docs (python#103660)
  Revert "Use non alternate name for Kyiv (pythonGH-108533)" (pythonGH-108649)
  pythongh-108278: Deprecate passing the first param of sqlite3.Connection callback APIs by keyword (python#108632)
  pythongh-108455: peg_generator: install two stubs packages before running mypy (python#108637)
  pythongh-107801: Improve the accuracy of io.IOBase.seek docs (python#108268)

erlend-aasland added a commit to erlend-aasland/cpython that referenced this pull request

Aug 30, 2023


          [3.11] pythongh-108590: Revert pythongh-108657 (commit 400a1ce) (pyth…

…on#108686)

(cherry picked from commit 2a3926f)

Reverted per Serhiy's request.

erlend-aasland added a commit that referenced this pull request

Aug 30, 2023


          [3.11] gh-108590: Revert gh-108657 (commit 400a1ce) (#108686) (#108694)

6f24420

(cherry picked from commit 2a3926f)

Reverted per Serhiy's request.

Reviewers

erlend-aasland

erlend-aasland approved these changes

berkerpeksag

Awaiting requested review from berkerpeksag

+1 more reviewer

dotysan

dotysan left review comments

Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

erlend-aasland

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

sqlite3.iterdump() incompatible with binary data

Uh oh!

There was an error while loading. Please reload this page.

5 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

CorvinM commented Aug 29, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

erlend-aasland left a comment

Choose a reason for hiding this comment

Uh oh!

erlend-aasland commented Aug 30, 2023

Uh oh!

CorvinM commented Aug 30, 2023

Uh oh!

This comment was marked as outdated.

miss-islington commented Aug 30, 2023

Uh oh!

miss-islington commented Aug 30, 2023

Uh oh!

erlend-aasland commented Aug 30, 2023

Uh oh!

CorvinM commented Aug 30, 2023

Uh oh!

bedevere-bot commented Aug 30, 2023

Uh oh!

bedevere-bot commented Aug 30, 2023

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

CorvinM commented Aug 29, 2023 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.