GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [doc] Remove no longer valid note on platform.win32_ver by andresdelfino · Pull Request #22005 · python/cpython

Conversation

@andresdelfino

@andresdelfino andresdelfino commented Aug 29, 2020

Copy link
Copy Markdown
Contributor

The comment no longer applies since v3.5.1rc1: b9f4fea

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@andresdelfino
Remove outdated comment
01043cc
@bedevere-bot bedevere-bot added the docs Documentation in the Doc dir label Aug 29, 2020
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Aug 29, 2020
@bedevere-bot bedevere-bot added the awaiting review label Aug 29, 2020
@vsajip vsajip added skip issue skip news labels Sep 13, 2020
@andresdelfino andresdelfino changed the title [doc] Remove outdated comment in platform [doc] Remove outdated comment on platform.win32_ver Oct 21, 2020
@andresdelfino

andresdelfino commented Oct 21, 2020

Copy link
Copy Markdown
Contributor Author

@zooba as you commited the change that made this obsolete, perhaps you can verify? b9f4fea

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@andresdelfino

andresdelfino commented Nov 2, 2020

Copy link
Copy Markdown
Contributor Author

@mhammond perhaps you can confirm? :)

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@mhammond

mhammond commented Nov 2, 2020

Copy link
Copy Markdown
Contributor

That change looks correct to me.

andresdelfino reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@andresdelfino andresdelfino changed the title [doc] Remove outdated comment on platform.win32_ver [doc] Remove no longer valid note on platform.win32_ver Nov 3, 2020
@zooba zooba added needs backport to 3.8 labels Nov 6, 2020
@zooba

zooba commented Nov 6, 2020

Copy link
Copy Markdown
Member

Thanks for this! (Sorry I didn't see it, GitHub notifications are a mess...)

andresdelfino reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@zooba
zooba merged commit 7c01f15 into python:master Nov 6, 2020
@miss-islington

miss-islington commented Nov 6, 2020

Copy link
Copy Markdown
Contributor

Thanks @andresdelfino for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8, 3.9.
🐍🍒⛏🤖

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-bot bedevere-bot removed awaiting review needs backport to 3.9 labels Nov 6, 2020
@bedevere-bot

bedevere-bot commented Nov 6, 2020

Copy link
Copy Markdown

GH-23183 is a backport of this pull request to the 3.9 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-bot

bedevere-bot commented Nov 6, 2020

Copy link
Copy Markdown

GH-23184 is a backport of this pull request to the 3.8 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-bot bedevere-bot removed the needs backport to 3.8 label Nov 6, 2020
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 6, 2020
@andresdelfino @miss-islington
Remove outdated reference to pywin32 from platform module (pythonGH-2…
b527f79
…2005)

(cherry picked from commit 7c01f15)

Co-authored-by: Andre Delfino <[email protected]>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 6, 2020
@andresdelfino @miss-islington
Remove outdated reference to pywin32 from platform module (pythonGH-2…
64a3636
…2005)

(cherry picked from commit 7c01f15)

Co-authored-by: Andre Delfino <[email protected]>
@andresdelfino
andresdelfino deleted the remove_outdated_win32 branch November 6, 2020 19:00
miss-islington added a commit that referenced this pull request Nov 6, 2020
@miss-islington @andresdelfino
Remove outdated reference to pywin32 from platform module (GH-22005)
6255296
(cherry picked from commit 7c01f15)

Co-authored-by: Andre Delfino <[email protected]>
shihai1991 added a commit to shihai1991/cpython that referenced this pull request Nov 7, 2020
@shihai1991
Merge remote-tracking branch 'origin/master' into bpo_41073_add_types…
2d72953
…lots1

* origin/master: (80 commits)
  bpo-42282: Fold constants inside named expressions (pythonGH-23190)
  bpo-41028: Doc: Move switchers to docsbuild-scripts. (pythonGH-20969)
  bpo-42133: update parts of the stdlib to fall back to `__spec__.loader` when `__loader__` is missing (python#22929)
  Remove outdated reference to pywin32 from platform module (pythonGH-22005)
  bpo-41832: PyType_FromModuleAndSpec() now accepts NULL tp_doc (pythonGH-23123)
  Minor grammar edits for the descriptor howto guide (GH-python#23175)
  bpo-42179: Doc/tutorial: Remove mention of __cause__ (pythonGH-23162)
  bpo-26389: Allow passing an exception object in the traceback module (pythonGH-22610)
  bpo-42260: PyConfig_Read() only parses argv once (pythonGH-23168)
  bpo-42260: Add _PyConfig_FromDict() (pythonGH-23167)
  bpo-41877 Check for asert, aseert, assrt in mocks (pythonGH-23165)
  [docs] fix wrongly named AsyncContextDecorator (pythonGH-23164)
  bpo-42262: Add Py_NewRef() and Py_XNewRef() (pythonGH-23152)
  bpo-42266: Handle monkey-patching descriptors in LOAD_ATTR cache (pythonGH-23157)
  bpo-40816 Add AsyncContextDecorator class (pythonGH-20516)
  bpo-42260: Add _PyInterpreterState_SetConfig() (pythonGH-23158)
  Disable peg generator tests when building with PGO (pythonGH-23141)
  bpo-1635741: _sqlite3 uses PyModule_AddObjectRef() (pythonGH-23148)
  bpo-1635741: Fix PyInit_pyexpat() error handling (pythonGH-22489)
  bpo-42260: Main init modify sys.flags in-place (pythonGH-23150)
  ...
miss-islington added a commit that referenced this pull request Nov 17, 2020
@miss-islington @andresdelfino
[3.8] Remove outdated reference to pywin32 from platform module (GH-2…
545dcb1
…2005) (GH-23184)

(cherry picked from commit 7c01f15)


Co-authored-by: Andre Delfino <[email protected]>
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
@andresdelfino @adorilson
Remove outdated reference to pywin32 from platform module (pythonGH-2…
c51db35
…2005)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

7 participants

@andresdelfino @mhammond @zooba @miss-islington @bedevere-bot @vsajip @the-knights-who-say-ni
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.