GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-42179: Doc/tutorial: Remove mention of __cause__ by methane · Pull Request #23162 · python/cpython

Conversation

@methane

@methane methane commented Nov 5, 2020 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Ref: bpo-42179

https://bugs.python.org/issue37826

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@methane
bpo-37826: Doc/tutorial: Remove mention to __cause__
c704d93
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Nov 5, 2020
@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting core review labels Nov 5, 2020
@methane methane changed the title bpo-37826: Doc/tutorial: Remove mention to __cause__ bpo-42179: Doc/tutorial: Remove mention to __cause__ Nov 5, 2020
@merwok merwok changed the title bpo-42179: Doc/tutorial: Remove mention to __cause__ bpo-42179: Doc/tutorial: Remove mention of __cause__ Nov 5, 2020
merwok
merwok reviewed Nov 5, 2020
View reviewed changes
Comment thread Doc/tutorial/errors.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Doc/tutorial/errors.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Doc/tutorial/errors.rst Outdated
inside an exception handler or :keyword:`finally` section. Exception chaining
can be disabled by using ``from None`` idiom:
Exception chaining happens automatically when an exception is raised inside an
exception handler or :keyword:`finally` section. Exception chaining can be

@merwok merwok Nov 5, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think of adding: an exception handler (an :keyboard:`except` block)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@willingc willingc Nov 5, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or possibly a :keyboard: `try` block's exception handler

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@merwok merwok Nov 5, 2020

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I used a parenthetical on purpose to signify that «exception handler» == «except block» (I wrote try block by mistaked at first).
Otherwise it could be confusing what an exception handler is (is it a function you call in except? is it excepthook?)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@methane methane Nov 5, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We already use :keyword:`finally` section.
How about just :keyword:`except` or :keyword:`finally` section for consistency?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
merwok and willingc reacted with thumbs up emoji
All reactions
  • 👍 2 reactions
@willingc willingc mentioned this pull request Nov 5, 2020
bpo-42179: Clarify exception chaining #23160
Merged
methane added 2 commits November 6, 2020 08:01
@methane
fixup
7508f69
@methane
fixup
b43dfa6
@methane methane added skip news needs backport to 3.9 labels Nov 5, 2020
willingc
willingc approved these changes Nov 6, 2020
View reviewed changes

@willingc willingc left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @methane and @merwok.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Nov 6, 2020
@methane
methane merged commit bde33e4 into python:master Nov 6, 2020
@methane
methane deleted the tut-remove-cause branch November 6, 2020 02:45
@miss-islington

miss-islington commented Nov 6, 2020

Copy link
Copy Markdown
Contributor

Thanks @methane for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting merge label Nov 6, 2020
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 6, 2020
@methane @miss-islington
bpo-42179: Doc/tutorial: Remove mention of __cause__ (pythonGH-23162)
bf2829b 
(cherry picked from commit bde33e4)

Co-authored-by: Inada Naoki <[email protected]>
@bedevere-bot bedevere-bot removed the needs backport to 3.9 label Nov 6, 2020
@bedevere-bot

bedevere-bot commented Nov 6, 2020

Copy link
Copy Markdown

GH-23173 is a backport of this pull request to the 3.9 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington added a commit that referenced this pull request Nov 6, 2020
@miss-islington @methane
bpo-42179: Doc/tutorial: Remove mention of __cause__ (GH-23162)
e74fb2d 
(cherry picked from commit bde33e4)

Co-authored-by: Inada Naoki <[email protected]>
shihai1991 added a commit to shihai1991/cpython that referenced this pull request Nov 6, 2020
@shihai1991
Merge remote-tracking branch 'origin/master' into bpo_41832
15e18cc 
* origin/master:
  bpo-42179: Doc/tutorial: Remove mention of __cause__ (pythonGH-23162)
  bpo-26389: Allow passing an exception object in the traceback module (pythonGH-22610)
  bpo-42260: PyConfig_Read() only parses argv once (pythonGH-23168)
  bpo-42260: Add _PyConfig_FromDict() (pythonGH-23167)
  bpo-41877 Check for asert, aseert, assrt in mocks (pythonGH-23165)
  [docs] fix wrongly named AsyncContextDecorator (pythonGH-23164)
  bpo-42262: Add Py_NewRef() and Py_XNewRef() (pythonGH-23152)
  bpo-42266: Handle monkey-patching descriptors in LOAD_ATTR cache (pythonGH-23157)
  bpo-40816 Add AsyncContextDecorator class (pythonGH-20516)
shihai1991 added a commit to shihai1991/cpython that referenced this pull request Nov 7, 2020
@shihai1991
Merge remote-tracking branch 'origin/master' into bpo_41073_add_types…
2d72953 
…lots1

* origin/master: (80 commits)
  bpo-42282: Fold constants inside named expressions (pythonGH-23190)
  bpo-41028: Doc: Move switchers to docsbuild-scripts. (pythonGH-20969)
  bpo-42133: update parts of the stdlib to fall back to `__spec__.loader` when `__loader__` is missing (python#22929)
  Remove outdated reference to pywin32 from platform module (pythonGH-22005)
  bpo-41832: PyType_FromModuleAndSpec() now accepts NULL tp_doc (pythonGH-23123)
  Minor grammar edits for the descriptor howto guide (GH-python#23175)
  bpo-42179: Doc/tutorial: Remove mention of __cause__ (pythonGH-23162)
  bpo-26389: Allow passing an exception object in the traceback module (pythonGH-22610)
  bpo-42260: PyConfig_Read() only parses argv once (pythonGH-23168)
  bpo-42260: Add _PyConfig_FromDict() (pythonGH-23167)
  bpo-41877 Check for asert, aseert, assrt in mocks (pythonGH-23165)
  [docs] fix wrongly named AsyncContextDecorator (pythonGH-23164)
  bpo-42262: Add Py_NewRef() and Py_XNewRef() (pythonGH-23152)
  bpo-42266: Handle monkey-patching descriptors in LOAD_ATTR cache (pythonGH-23157)
  bpo-40816 Add AsyncContextDecorator class (pythonGH-20516)
  bpo-42260: Add _PyInterpreterState_SetConfig() (pythonGH-23158)
  Disable peg generator tests when building with PGO (pythonGH-23141)
  bpo-1635741: _sqlite3 uses PyModule_AddObjectRef() (pythonGH-23148)
  bpo-1635741: Fix PyInit_pyexpat() error handling (pythonGH-22489)
  bpo-42260: Main init modify sys.flags in-place (pythonGH-23150)
  ...
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
@methane @adorilson
bpo-42179: Doc/tutorial: Remove mention of __cause__ (pythonGH-23162)
7e47a79
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@merwok merwok merwok left review comments
@willingc willingc willingc approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@methane @miss-islington @bedevere-bot @merwok @willingc @the-knights-who-say-ni
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.